Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: clinton.a.taylor@intel.com
To: Intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v4] drm/i915/gt: Implement WA_1406941453
Date: Tue, 25 Aug 2020 19:57:24 -0700	[thread overview]
Message-ID: <20200826025724.20944-1-clinton.a.taylor@intel.com> (raw)
In-Reply-To: <20200805232920.15085-1-clinton.a.taylor@intel.com>

From: Clint Taylor <clinton.a.taylor@intel.com>

Enable HW Default flip for small PL.

bspec: 52890
bspec: 53508
bspec: 53273

v2: rebase to drm-tip
v3: move from ctx to gt workarounds. Remove whitelist.
v4: move to rcs WA init

Cc: Matt Atwood <matthew.s.atwood@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 +++++++
 drivers/gpu/drm/i915/i915_reg.h             | 1 +
 2 files changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index a3f72b75c61e..b0a7cb056633 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1725,6 +1725,13 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
 			     FF_DOP_CLOCK_GATE_DISABLE);
 	}
 
+	if (IS_GEN(i915, 12)) {
+		/* Wa_1406941453:gen12 */
+		wa_masked_en(wal,
+			     GEN10_SAMPLER_MODE,
+			     ENABLE_SMALLPL);
+	}
+
 	if (IS_GEN(i915, 11)) {
 		/* This is not an Wa. Enable for better image quality */
 		wa_masked_en(wal,
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index ac691927e29d..ab4b1abd4364 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -9315,6 +9315,7 @@ enum {
 #define   GEN11_LSN_UNSLCVC_GAFS_HALF_SF_MAXALLOC	(1 << 7)
 
 #define GEN10_SAMPLER_MODE		_MMIO(0xE18C)
+#define   ENABLE_SMALLPL			REG_BIT(15)
 #define   GEN11_SAMPLER_ENABLE_HEADLESS_MSG	REG_BIT(5)
 
 /* IVYBRIDGE DPF */
-- 
2.28.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-08-26  2:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05 23:29 [Intel-gfx] [PATCH v2] drm/i915/gt: Implement WA_1406941453 clinton.a.taylor
2020-08-05 23:50 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Implement WA_1406941453 (rev2) Patchwork
2020-08-06  0:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-08-06 17:02   ` James Ausmus
2020-08-06 17:46     ` Vudum, Lakshminarayana
2020-08-06 17:10 ` Patchwork
2020-08-06 17:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-07  0:27 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-08-12 21:53 ` [Intel-gfx] [PATCH v2] drm/i915/gt: Implement WA_1406941453 Matt Roper
2020-08-25 21:54 ` [Intel-gfx] [PATCH v3] " clinton.a.taylor
2020-08-25 22:11   ` Matt Roper
2020-08-25 22:41     ` Taylor, Clinton A
2020-08-25 22:36 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Implement WA_1406941453 (rev3) Patchwork
2020-08-26  2:57 ` clinton.a.taylor [this message]
2020-08-26  4:34   ` [Intel-gfx] [PATCH v4] drm/i915/gt: Implement WA_1406941453 Matt Roper
2020-08-26  3:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Implement WA_1406941453 (rev4) Patchwork
2020-08-26  5:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-08-26 18:22   ` Souza, Jose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200826025724.20944-1-clinton.a.taylor@intel.com \
    --to=clinton.a.taylor@intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox