Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/display: Fix DRRS debugfs

From: Anshuman Gupta <anshuman.gupta@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Hariom Pandey <hariom.pandey@intel.com>,
	Srinivas K <srinivasx.k@intel.com>
Subject: Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/display: Fix DRRS debugfs
Date: Wed, 26 Aug 2020 12:44:58 +0530	[thread overview]
Message-ID: <20200826071454.GH25390@intel.com> (raw)
In-Reply-To: <20200825171331.17971-3-jose.souza@intel.com>

On 2020-08-25 at 10:13:31 -0700, José Roberto de Souza wrote:
> Supported and enabled are different things so printing both.
> 
> v3: using drrs->type instead of vbt.drrs_type
> 
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Cc: Srinivas K <srinivasx.k@intel.com>
> Cc: Hariom Pandey <hariom.pandey@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index f549381048b3..65ccf5d6cd39 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -1069,10 +1069,18 @@ static void drrs_status_per_crtc(struct seq_file *m,
>  
>  	drm_connector_list_iter_begin(dev, &conn_iter);
>  	drm_for_each_connector_iter(connector, &conn_iter) {
> +		bool supported = false;
> +
>  		if (connector->state->crtc != &intel_crtc->base)
>  			continue;
>  
>  		seq_printf(m, "%s:\n", connector->name);
> +
> +		if (connector->connector_type == DRM_MODE_CONNECTOR_eDP &&
> +		    drrs->type == SEAMLESS_DRRS_SUPPORT)
> +			supported = true;
> +
> +		seq_printf(m, "\tDRRS Supported: %s\n", yesno(supported));
pritning format will looks confusing if a crtc attached to more then a one connector,
somewhat below,

CRTC 1:  eDP-1:

        DRRS Supported : Yes
DP-1:
	DRRS Supported : No
Better to keep seq_printf(m, "\tDRRS Supported: %s\n", yesno(supported)) outside
drm_for_each_connector_iter loop.

Thanks,
Anshuman Gupta.

>  	}
>  	drm_connector_list_iter_end(&conn_iter);
>  
> @@ -1083,7 +1091,7 @@ static void drrs_status_per_crtc(struct seq_file *m,
>  
>  		mutex_lock(&drrs->mutex);
>  		/* DRRS Supported */
> -		seq_puts(m, "\tDRRS Supported: Yes\n");
> +		seq_puts(m, "\tDRRS Enabled: Yes\n");
>  
>  		/* disable_drrs() will make drrs->dp NULL */
>  		if (!drrs->dp) {
> @@ -1118,7 +1126,7 @@ static void drrs_status_per_crtc(struct seq_file *m,
>  		mutex_unlock(&drrs->mutex);
>  	} else {
>  		/* DRRS not supported. Print the VBT parameter*/
> -		seq_puts(m, "\tDRRS Supported : No");
> +		seq_puts(m, "\tDRRS Enabled : No");
>  	}
>  	seq_puts(m, "\n");
>  }
> -- 
> 2.28.0
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx