Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karthik B S <karthik.b.s@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: paulo.r.zanoni@intel.com, michel@daenzer.net,
	dri-devel@lists.freedesktop.org, daniel.vetter@intel.com,
	harry.wentland@amd.com, nicholas.kazlauskas@amd.com
Subject: [Intel-gfx] [PATCH v9 4/8] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips
Date: Wed, 16 Sep 2020 20:38:20 +0530	[thread overview]
Message-ID: <20200916150824.15749-5-karthik.b.s@intel.com> (raw)
In-Reply-To: <20200916150824.15749-1-karthik.b.s@intel.com>

Since the flip done event will be sent in the flip_done_handler,
no need to add the event to the list and delay it for later.

v2: -Moved the async check above vblank_get as it
     was causing issues for PSR.

v3: -No need to wait for vblank to pass, as this wait was causing a
     16ms delay once every few flips.

v4: -Rebased.

v5: -Rebased.

v6: -Rebased.

v7: -No need of irq disable if we are not doing vblank evade. (Ville)

v8: -Rebased.

v9: -Move the return in intel_pipe_update_end before tracepoint. (Ville)

Signed-off-by: Karthik B S <karthik.b.s@intel.com>
Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_sprite.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
index 63040cb0d4e1..76a3d9bfe0de 100644
--- a/drivers/gpu/drm/i915/display/intel_sprite.c
+++ b/drivers/gpu/drm/i915/display/intel_sprite.c
@@ -93,6 +93,9 @@ void intel_pipe_update_start(const struct intel_crtc_state *new_crtc_state)
 	DEFINE_WAIT(wait);
 	u32 psr_status;
 
+	if (new_crtc_state->uapi.async_flip)
+		return;
+
 	vblank_start = adjusted_mode->crtc_vblank_start;
 	if (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)
 		vblank_start = DIV_ROUND_UP(vblank_start, 2);
@@ -200,6 +203,9 @@ void intel_pipe_update_end(struct intel_crtc_state *new_crtc_state)
 	ktime_t end_vbl_time = ktime_get();
 	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
 
+	if (new_crtc_state->uapi.async_flip)
+		return;
+
 	trace_intel_pipe_update_end(crtc, end_vbl_count, scanline_end);
 
 	/* We're still in the vblank-evade critical section, this can't race.
-- 
2.22.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-09-16 15:35 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 15:08 [Intel-gfx] [PATCH v9 0/8] Asynchronous flip implementation for i915 Karthik B S
2020-09-16 15:08 ` [Intel-gfx] [PATCH v9 1/8] drm/i915: Add enable/disable flip done and flip done handler Karthik B S
2020-09-16 15:08 ` [Intel-gfx] [PATCH v9 2/8] drm/i915: Add support for async flips in I915 Karthik B S
2020-09-16 15:08 ` [Intel-gfx] [PATCH v9 3/8] drm/i915: Add checks specific to async flips Karthik B S
2020-09-18  9:02   ` [Intel-gfx] [PATCH v10 " Karthik B S
2020-09-18 11:51     ` Ville Syrjälä
2020-09-21 10:49       ` Karthik B S
2020-09-16 15:08 ` Karthik B S [this message]
2020-09-16 15:08 ` [Intel-gfx] [PATCH v9 5/8] drm/i915: Add dedicated plane hook for async flip case Karthik B S
2020-09-18  7:00   ` [Intel-gfx] [PATCH v10 " Karthik B S
2020-09-18 11:53     ` Ville Syrjälä
2020-09-21 10:52       ` Karthik B S
2020-09-16 15:08 ` [Intel-gfx] [PATCH v9 6/8] drm/i915: WA for platforms with double buffered address update enable bit Karthik B S
2020-09-18 11:54   ` Ville Syrjälä
2020-09-21 10:53     ` Karthik B S
2020-09-16 15:08 ` [Intel-gfx] [PATCH v9 7/8] Documentation/gpu: Add asynchronous flip documentation for i915 Karthik B S
2020-09-18 11:58   ` Ville Syrjälä
2020-09-21 10:55     ` Karthik B S
2020-09-16 15:08 ` [Intel-gfx] [PATCH v9 8/8] drm/i915: Enable async flips in i915 Karthik B S
2020-09-18 12:03   ` Ville Syrjälä
2020-09-21 10:59     ` Karthik B S
2020-09-16 15:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Asynchronous flip implementation for i915 (rev9) Patchwork
2020-09-16 15:48 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-09-16 16:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-16 21:27 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-09-18  7:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Asynchronous flip implementation for i915 (rev10) Patchwork
2020-09-18  7:56 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-09-18  8:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-18  9:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-09-18  9:58 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Asynchronous flip implementation for i915 (rev11) Patchwork
2020-09-18 10:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-18 12:17 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200916150824.15749-5-karthik.b.s@intel.com \
    --to=karthik.b.s@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michel@daenzer.net \
    --cc=nicholas.kazlauskas@amd.com \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox