Re: [Intel-gfx] [PATCH 5/5] drm/<drivers>: Constify struct drm_driver

From: kernel test robot <lkp@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	DRI Development <dri-devel@lists.freedesktop.org>
Cc: kbuild-all@lists.01.org, Leo Li <sunpeng.li@amd.com>,
	nouveau@lists.freedesktop.org,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Maxime Ripard <mripard@kernel.org>,
	virtualization@lists.linux-foundation.org,
	Eric Anholt <eric@anholt.net>, Gerd Hoffmann <kraxel@redhat.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [Intel-gfx] [PATCH 5/5] drm/<drivers>: Constify struct drm_driver
Date: Fri, 23 Oct 2020 23:22:10 +0800	[thread overview]
Message-ID: <202010232330.oXa38Y7D-lkp@intel.com> (raw)
In-Reply-To: <20201023122811.2374118-5-daniel.vetter@ffwll.ch>

[-- Attachment #1: Type: text/plain, Size: 2234 bytes --]

Hi Daniel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next linus/master v5.9 next-20201023]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-radeon-Stop-changing-the-drm_driver-struct/20201023-203020
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: arm64-randconfig-r011-20201022 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9e2fdb03c9047a5d4b24b3e95f0370bcc59eec5e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Vetter/drm-radeon-Stop-changing-the-drm_driver-struct/20201023-203020
        git checkout 9e2fdb03c9047a5d4b24b3e95f0370bcc59eec5e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c:921:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
     921 | const static struct drm_driver ade_driver = {
         | ^~~~~

vim +/static +921 drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c

   920	
 > 921	const static struct drm_driver ade_driver = {
   922		.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
   923		.fops = &ade_fops,
   924		DRM_GEM_CMA_DRIVER_OPS,
   925		.name = "kirin",
   926		.desc = "Hisilicon Kirin620 SoC DRM Driver",
   927		.date = "20150718",
   928		.major = 1,
   929		.minor = 0,
   930	};
   931	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34713 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx