Re: [Intel-gfx] [PXP CLEAN PATCH v06 08/27] drm/i915/pxp: Read register to check hardware session state

From: kernel test robot <lkp@intel.com>
To: Sean Z Huang <sean.z.huang@intel.com>, Intel-gfx@lists.freedesktop.org
Cc: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PXP CLEAN PATCH v06 08/27] drm/i915/pxp: Read register to check hardware session state
Date: Sat, 14 Nov 2020 10:42:28 +0800	[thread overview]
Message-ID: <202011141006.EL4mL39j-lkp@intel.com> (raw)
In-Reply-To: <20201114003716.4875-8-sean.z.huang@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2866 bytes --]

Hi Sean,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20201113]
[also build test WARNING on v5.10-rc3]
[cannot apply to drm-intel/for-linux-next char-misc/char-misc-testing v5.10-rc3 v5.10-rc2 v5.10-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sean-Z-Huang/drm-i915-pxp-Introduce-Intel-PXP-component/20201114-084506
base:    92edc4aef86780a8ad01b092c6d6630bb3cb423d
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/a8b258b463bb1fd193cf33be15a5909bc428d52b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sean-Z-Huang/drm-i915-pxp-Introduce-Intel-PXP-component/20201114-084506
        git checkout a8b258b463bb1fd193cf33be15a5909bc428d52b
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/pxp/intel_pxp_sm.c:13:5: warning: no previous prototype for 'pxp_sm_reg_read' [-Wmissing-prototypes]
      13 | int pxp_sm_reg_read(struct drm_i915_private *i915, u32 offset, u32 *regval)
         |     ^~~~~~~~~~~~~~~
   drivers/gpu/drm/i915/pxp/intel_pxp_sm.c:195:13: warning: 'check_if_protected_type0_sessions_are_attacked' defined but not used [-Wunused-function]
     195 | static bool check_if_protected_type0_sessions_are_attacked(struct drm_i915_private *i915)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/i915/pxp/intel_pxp_sm.c:162:12: warning: 'sync_hw_sw_state' defined but not used [-Wunused-function]
     162 | static int sync_hw_sw_state(struct drm_i915_private *i915, int session_index, int session_type)
         |            ^~~~~~~~~~~~~~~~

vim +/pxp_sm_reg_read +13 drivers/gpu/drm/i915/pxp/intel_pxp_sm.c

    12	
  > 13	int pxp_sm_reg_read(struct drm_i915_private *i915, u32 offset, u32 *regval)
    14	{
    15		intel_wakeref_t wakeref;
    16		int err = 0;
    17	
    18		if (!i915 || !regval) {
    19			err = -EINVAL;
    20			drm_dbg(&i915->drm, "Failed to %s bad params\n", __func__);
    21			goto end;
    22		}
    23	
    24		with_intel_runtime_pm(&i915->runtime_pm, wakeref) {
    25			i915_reg_t reg_offset = {offset};
    26			*regval = intel_uncore_read(&i915->uncore, reg_offset);
    27		}
    28	end:
    29		return err;
    30	}
    31	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 77405 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx