From: Imre Deak <imre.deak@intel.com>
To: "Chery, Nanley G" <nanley.g.chery@intel.com>
Cc: "Nikula, Jani" <jani.nikula@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Chris Wilson <chris@chris-wilson.co.uk>,
"Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color
Date: Mon, 14 Dec 2020 18:22:27 +0200 [thread overview]
Message-ID: <20201214162227.GA3566534@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <ac393a9d1b774766a35c299915f0cca5@intel.com>
On Fri, Dec 11, 2020 at 09:04:02AM +0200, Chery, Nanley G wrote:
> [...]
> > > We probably don't have to update the header, but we noticed in our
> > > testing that the clear color prefers an alignment greater than 64B.
> > > Unfortunately, I can't find any bspec note about this. As long as the
> > > buffer creators are aware though, I think we should be fine. I don't
> > > know if this is the best forum to bring it up, but I thought I'd
> > > share.
> >
> > Yes, would be good to clarify this and get it also to the spec. Then the
> > driver should also check the alignment of the 3rd FB plane.
>
> I plan to run some more tests and file a bug in the spec.
Ok, thanks. Note that this patch has a problem with synchornization and
based on Chris' response I'm planning to update it once I figured out
the proper way to map the CC plane. Until that you could still use it on
TGL if you wait for the RT result explicitly after the fast clear and
before flipping to it (that's what the IGT test does atm).
> I see that the IGT test only clears the fb once. Just to confirm, is the
> clear color offset read from on every frame? Userspace would like to be
> able to pass different clear colors for an fb.
Yes, every time you do a flip the kernel will re-read the CC value and
program it to the display.
--Imre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-12-14 16:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 18:26 [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color Imre Deak
2020-11-23 18:26 ` [Intel-gfx] [PATCH 2/2] drm/i915/tgl: Add Clear Color support for TGL Render Decompression Imre Deak
2020-11-27 9:27 ` Kahola, Mika
2020-12-01 12:34 ` Chris Wilson
2020-12-01 20:50 ` Imre Deak
2020-12-01 21:10 ` Chris Wilson
2020-12-01 21:31 ` Imre Deak
2020-11-23 20:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color Patchwork
2020-11-23 20:56 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-11-23 21:24 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-11-24 15:12 ` Imre Deak
2020-11-24 17:15 ` Vudum, Lakshminarayana
2020-11-24 17:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-11-24 21:57 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-11-26 8:24 ` [Intel-gfx] [PATCH 1/2] " Kahola, Mika
2020-11-27 14:31 ` Imre Deak
2020-11-27 15:19 ` Daniel Vetter
2020-11-27 18:06 ` Imre Deak
2020-12-01 0:18 ` Chery, Nanley G
2020-12-01 12:04 ` Imre Deak
2020-12-11 7:04 ` Chery, Nanley G
2020-12-14 16:22 ` Imre Deak [this message]
2020-11-30 10:00 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214162227.GA3566534@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=nanley.g.chery@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox