From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Nanley G Chery <nanley.g.chery@intel.com>,
Rafael Antognolli <rafael.antognolli@intel.com>,
intel-gfx@lists.freedesktop.org,
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,
Ville Syrjala <ville.syrjala@intel.com>,
Shashank Sharma <shashank.sharma@intel.com>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/tgl: Add Clear Color support for TGL Render Decompression
Date: Tue, 1 Dec 2020 23:31:09 +0200 [thread overview]
Message-ID: <20201201213109.GA2934188@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <160685704629.19969.3005909283019006262@build.alporthouse.com>
On Tue, Dec 01, 2020 at 09:10:46PM +0000, Chris Wilson wrote:
> Quoting Imre Deak (2020-12-01 20:50:21)
> > On Tue, Dec 01, 2020 at 12:34:35PM +0000, Chris Wilson wrote:
> > > There's also the matter of coherency. Is the object coherent for reads
> > > from the CPU? -- in most cases it will not be, but you should check
> > > obj->cache_coherency to see if the read requires a preceding
> > > cache_clflush_range() / drm_clflush_virt_range().
> >
> > Ok, at this point for the TGL-only modifier, we could then just
> > warn_on(!bo_cache_coherent_for_read) due to HAS_LLC.
>
> Stupid question, is the same path required for dg1?
>
> That makes everything more difficult as the struct pages are gone.
Yes, same path. So we do need a different way to map.
--Imre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-12-01 21:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 18:26 [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color Imre Deak
2020-11-23 18:26 ` [Intel-gfx] [PATCH 2/2] drm/i915/tgl: Add Clear Color support for TGL Render Decompression Imre Deak
2020-11-27 9:27 ` Kahola, Mika
2020-12-01 12:34 ` Chris Wilson
2020-12-01 20:50 ` Imre Deak
2020-12-01 21:10 ` Chris Wilson
2020-12-01 21:31 ` Imre Deak [this message]
2020-11-23 20:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color Patchwork
2020-11-23 20:56 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-11-23 21:24 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-11-24 15:12 ` Imre Deak
2020-11-24 17:15 ` Vudum, Lakshminarayana
2020-11-24 17:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-11-24 21:57 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-11-26 8:24 ` [Intel-gfx] [PATCH 1/2] " Kahola, Mika
2020-11-27 14:31 ` Imre Deak
2020-11-27 15:19 ` Daniel Vetter
2020-11-27 18:06 ` Imre Deak
2020-12-01 0:18 ` Chery, Nanley G
2020-12-01 12:04 ` Imre Deak
2020-12-11 7:04 ` Chery, Nanley G
2020-12-14 16:22 ` Imre Deak
2020-11-30 10:00 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201213109.GA2934188@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nanley.g.chery@intel.com \
--cc=rafael.antognolli@intel.com \
--cc=shashank.sharma@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox