From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, Matthew Auld <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Mark private i915_gem_stolen functions as static
Date: Fri, 15 Jan 2021 10:56:09 -0500 [thread overview]
Message-ID: <20210115155609.GA3226@intel.com> (raw)
In-Reply-To: <20210115142623.29897-1-chris@chris-wilson.co.uk>
On Fri, Jan 15, 2021 at 02:26:23PM +0000, Chris Wilson wrote:
> drivers/gpu/drm/i915/gem/i915_gem_stolen.c:624:5: error: no previous prototype for ‘__i915_gem_object_create_stolen’ [-Werror=missing-prototypes]
> int __i915_gem_object_create_stolen(struct intel_memory_region *mem,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/i915/gem/i915_gem_stolen.c:649:5: error: no previous prototype for ‘_i915_gem_object_stolen_init’ [-Werror=missing-prototypes]
> int _i915_gem_object_stolen_init(struct intel_memory_region *mem,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> index 27d95bddbf4d..b221492531ef 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> @@ -621,9 +621,9 @@ static const struct drm_i915_gem_object_ops i915_gem_object_stolen_ops = {
> .release = i915_gem_object_release_stolen,
> };
>
> -int __i915_gem_object_create_stolen(struct intel_memory_region *mem,
> - struct drm_i915_gem_object *obj,
> - struct drm_mm_node *stolen)
> +static int __i915_gem_object_create_stolen(struct intel_memory_region *mem,
> + struct drm_i915_gem_object *obj,
> + struct drm_mm_node *stolen)
> {
> static struct lock_class_key lock_class;
> unsigned int cache_level;
> @@ -646,10 +646,10 @@ int __i915_gem_object_create_stolen(struct intel_memory_region *mem,
> return 0;
> }
>
> -int _i915_gem_object_stolen_init(struct intel_memory_region *mem,
> - struct drm_i915_gem_object *obj,
> - resource_size_t size,
> - unsigned int flags)
> +static int _i915_gem_object_stolen_init(struct intel_memory_region *mem,
> + struct drm_i915_gem_object *obj,
> + resource_size_t size,
> + unsigned int flags)
> {
> struct drm_i915_private *i915 = mem->i915;
> struct drm_mm_node *stolen;
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-15 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 14:26 [Intel-gfx] [PATCH] drm/i915/gem: Mark private i915_gem_stolen functions as static Chris Wilson
2021-01-15 15:56 ` Rodrigo Vivi [this message]
2021-01-15 20:13 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2021-01-15 20:43 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115155609.GA3226@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox