* [Intel-gfx] [PATCH] drm/i915/gem: Mark private i915_gem_stolen functions as static
@ 2021-01-15 14:26 Chris Wilson
2021-01-15 15:56 ` Rodrigo Vivi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2021-01-15 14:26 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld, Chris Wilson
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:624:5: error: no previous prototype for ‘__i915_gem_object_create_stolen’ [-Werror=missing-prototypes]
int __i915_gem_object_create_stolen(struct intel_memory_region *mem,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:649:5: error: no previous prototype for ‘_i915_gem_object_stolen_init’ [-Werror=missing-prototypes]
int _i915_gem_object_stolen_init(struct intel_memory_region *mem,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index 27d95bddbf4d..b221492531ef 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
@@ -621,9 +621,9 @@ static const struct drm_i915_gem_object_ops i915_gem_object_stolen_ops = {
.release = i915_gem_object_release_stolen,
};
-int __i915_gem_object_create_stolen(struct intel_memory_region *mem,
- struct drm_i915_gem_object *obj,
- struct drm_mm_node *stolen)
+static int __i915_gem_object_create_stolen(struct intel_memory_region *mem,
+ struct drm_i915_gem_object *obj,
+ struct drm_mm_node *stolen)
{
static struct lock_class_key lock_class;
unsigned int cache_level;
@@ -646,10 +646,10 @@ int __i915_gem_object_create_stolen(struct intel_memory_region *mem,
return 0;
}
-int _i915_gem_object_stolen_init(struct intel_memory_region *mem,
- struct drm_i915_gem_object *obj,
- resource_size_t size,
- unsigned int flags)
+static int _i915_gem_object_stolen_init(struct intel_memory_region *mem,
+ struct drm_i915_gem_object *obj,
+ resource_size_t size,
+ unsigned int flags)
{
struct drm_i915_private *i915 = mem->i915;
struct drm_mm_node *stolen;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/gem: Mark private i915_gem_stolen functions as static
2021-01-15 14:26 [Intel-gfx] [PATCH] drm/i915/gem: Mark private i915_gem_stolen functions as static Chris Wilson
@ 2021-01-15 15:56 ` Rodrigo Vivi
2021-01-15 20:13 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2021-01-15 20:43 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Rodrigo Vivi @ 2021-01-15 15:56 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, Matthew Auld
On Fri, Jan 15, 2021 at 02:26:23PM +0000, Chris Wilson wrote:
> drivers/gpu/drm/i915/gem/i915_gem_stolen.c:624:5: error: no previous prototype for ‘__i915_gem_object_create_stolen’ [-Werror=missing-prototypes]
> int __i915_gem_object_create_stolen(struct intel_memory_region *mem,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/i915/gem/i915_gem_stolen.c:649:5: error: no previous prototype for ‘_i915_gem_object_stolen_init’ [-Werror=missing-prototypes]
> int _i915_gem_object_stolen_init(struct intel_memory_region *mem,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> index 27d95bddbf4d..b221492531ef 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> @@ -621,9 +621,9 @@ static const struct drm_i915_gem_object_ops i915_gem_object_stolen_ops = {
> .release = i915_gem_object_release_stolen,
> };
>
> -int __i915_gem_object_create_stolen(struct intel_memory_region *mem,
> - struct drm_i915_gem_object *obj,
> - struct drm_mm_node *stolen)
> +static int __i915_gem_object_create_stolen(struct intel_memory_region *mem,
> + struct drm_i915_gem_object *obj,
> + struct drm_mm_node *stolen)
> {
> static struct lock_class_key lock_class;
> unsigned int cache_level;
> @@ -646,10 +646,10 @@ int __i915_gem_object_create_stolen(struct intel_memory_region *mem,
> return 0;
> }
>
> -int _i915_gem_object_stolen_init(struct intel_memory_region *mem,
> - struct drm_i915_gem_object *obj,
> - resource_size_t size,
> - unsigned int flags)
> +static int _i915_gem_object_stolen_init(struct intel_memory_region *mem,
> + struct drm_i915_gem_object *obj,
> + resource_size_t size,
> + unsigned int flags)
> {
> struct drm_i915_private *i915 = mem->i915;
> struct drm_mm_node *stolen;
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gem: Mark private i915_gem_stolen functions as static
2021-01-15 14:26 [Intel-gfx] [PATCH] drm/i915/gem: Mark private i915_gem_stolen functions as static Chris Wilson
2021-01-15 15:56 ` Rodrigo Vivi
@ 2021-01-15 20:13 ` Patchwork
2021-01-15 20:43 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2021-01-15 20:13 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Mark private i915_gem_stolen functions as static
URL : https://patchwork.freedesktop.org/series/85919/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-O:drivers/gpu/drm/i915/gem/i915_gem_stolen.c:624:5: warning: symbol '__i915_gem_object_create_stolen' was not declared. Should it be static?
-O:drivers/gpu/drm/i915/gem/i915_gem_stolen.c:649:5: warning: symbol '_i915_gem_object_stolen_init' was not declared. Should it be static?
+
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Mark private i915_gem_stolen functions as static
2021-01-15 14:26 [Intel-gfx] [PATCH] drm/i915/gem: Mark private i915_gem_stolen functions as static Chris Wilson
2021-01-15 15:56 ` Rodrigo Vivi
2021-01-15 20:13 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
@ 2021-01-15 20:43 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2021-01-15 20:43 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4745 bytes --]
== Series Details ==
Series: drm/i915/gem: Mark private i915_gem_stolen functions as static
URL : https://patchwork.freedesktop.org/series/85919/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9624 -> Patchwork_19375
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19375 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19375, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19375/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19375:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-n3050: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19375/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
Known issues
------------
Here are the changes found in Patchwork_19375 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#1982] / [i915#402])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19375/fi-tgl-y/igt@debugfs_test@read_all_entries.html
* igt@i915_getparams_basic@basic-eu-total:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#402])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/fi-tgl-y/igt@i915_getparams_basic@basic-eu-total.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19375/fi-tgl-y/igt@i915_getparams_basic@basic-eu-total.html
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [PASS][7] -> [INCOMPLETE][8] ([i915#142] / [i915#2405])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19375/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
* igt@runner@aborted:
- fi-byt-j1900: NOTRUN -> [FAIL][9] ([i915#1814] / [i915#2505])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19375/fi-byt-j1900/igt@runner@aborted.html
- fi-bsw-n3050: NOTRUN -> [FAIL][10] ([i915#1436])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19375/fi-bsw-n3050/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_render_tiled_blits@basic:
- fi-tgl-y: [DMESG-WARN][11] ([i915#402]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/fi-tgl-y/igt@gem_render_tiled_blits@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19375/fi-tgl-y/igt@gem_render_tiled_blits@basic.html
* igt@i915_selftest@live@blt:
- fi-snb-2600: [DMESG-FAIL][13] ([i915#1409]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9624/fi-snb-2600/igt@i915_selftest@live@blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19375/fi-snb-2600/igt@i915_selftest@live@blt.html
[i915#1409]: https://gitlab.freedesktop.org/drm/intel/issues/1409
[i915#142]: https://gitlab.freedesktop.org/drm/intel/issues/142
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (42 -> 39)
------------------------------
Missing (3): fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9624 -> Patchwork_19375
CI-20190529: 20190529
CI_DRM_9624: c94178b94789eadad87ec0e784572da0f288db55 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5959: c5cf0734c4f6c1fa17a6a15b5aa721c3a0b8c494 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19375: 981b4e75cd00f7c8bc253d773f308822752a027c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
981b4e75cd00 drm/i915/gem: Mark private i915_gem_stolen functions as static
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19375/index.html
[-- Attachment #1.2: Type: text/html, Size: 5676 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-15 20:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-15 14:26 [Intel-gfx] [PATCH] drm/i915/gem: Mark private i915_gem_stolen functions as static Chris Wilson
2021-01-15 15:56 ` Rodrigo Vivi
2021-01-15 20:13 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2021-01-15 20:43 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox