* [Intel-gfx] [PATCH i-g-t 1/3] intel_gpu_top: Update manual page for recent additions
@ 2021-02-01 10:45 Tvrtko Ursulin
2021-02-01 10:45 ` [Intel-gfx] [PATCH i-g-t 2/3] intel_gpu_top: Add option to hide inactive clients Tvrtko Ursulin
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2021-02-01 10:45 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Document numeric busyness overlay and sort selection.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
man/intel_gpu_top.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/man/intel_gpu_top.rst b/man/intel_gpu_top.rst
index 35ab10da9bb4..b18fd9675bb7 100644
--- a/man/intel_gpu_top.rst
+++ b/man/intel_gpu_top.rst
@@ -55,6 +55,8 @@ Supported keys:
'q' Exit from the tool.
'1' Toggle between aggregated engine class and physical engine mode.
+ 'n' Toggle display of numeric client busyness overlay.
+ 's' Toggle between sort modes (runtime, total runtime, client id).
DEVICE SELECTION
================
--
2.27.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Intel-gfx] [PATCH i-g-t 2/3] intel_gpu_top: Add option to hide inactive clients 2021-02-01 10:45 [Intel-gfx] [PATCH i-g-t 1/3] intel_gpu_top: Update manual page for recent additions Tvrtko Ursulin @ 2021-02-01 10:45 ` Tvrtko Ursulin 2021-02-01 10:56 ` Chris Wilson 2021-02-01 10:45 ` [Intel-gfx] [PATCH i-g-t 3/3] intel_gpu_top: Fix interactive header Tvrtko Ursulin 2021-02-01 10:55 ` [Intel-gfx] [PATCH i-g-t 1/3] intel_gpu_top: Update manual page for recent additions Chris Wilson 2 siblings, 1 reply; 6+ messages in thread From: Tvrtko Ursulin @ 2021-02-01 10:45 UTC (permalink / raw) To: igt-dev; +Cc: Intel-gfx From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Allow hiding inactive clients (used no GPU time ever) in interactive mode by pressing 'i'. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> --- man/intel_gpu_top.rst | 1 + tools/intel_gpu_top.c | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/man/intel_gpu_top.rst b/man/intel_gpu_top.rst index b18fd9675bb7..118d8b953a70 100644 --- a/man/intel_gpu_top.rst +++ b/man/intel_gpu_top.rst @@ -57,6 +57,7 @@ Supported keys: '1' Toggle between aggregated engine class and physical engine mode. 'n' Toggle display of numeric client busyness overlay. 's' Toggle between sort modes (runtime, total runtime, client id). + 'i' Toggle display of clients which used no GPU time. DEVICE SELECTION ================ diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index 60ff62d28e5d..dffc6ebecc57 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -1933,6 +1933,7 @@ print_clients_header(struct clients *clients, int lines, } static bool numeric_clients; +static bool filter_idle; static int print_client(struct client *c, struct engines *engines, double t, int lines, @@ -1942,6 +1943,9 @@ print_client(struct client *c, struct engines *engines, double t, int lines, unsigned int i; if (output_mode == INTERACTIVE) { + if (filter_idle && !c->total_runtime) + return lines; + lines++; printf("%6u %17s ", c->pid, c->print_name); @@ -2118,6 +2122,9 @@ static void process_stdin(unsigned int timeout_us) case '1': class_view ^= true; break; + case 'i': + filter_idle ^= true; + break; case 'n': numeric_clients ^= true; break; -- 2.27.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t 2/3] intel_gpu_top: Add option to hide inactive clients 2021-02-01 10:45 ` [Intel-gfx] [PATCH i-g-t 2/3] intel_gpu_top: Add option to hide inactive clients Tvrtko Ursulin @ 2021-02-01 10:56 ` Chris Wilson 0 siblings, 0 replies; 6+ messages in thread From: Chris Wilson @ 2021-02-01 10:56 UTC (permalink / raw) To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx Quoting Tvrtko Ursulin (2021-02-01 10:45:23) > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Allow hiding inactive clients (used no GPU time ever) in interactive mode > by pressing 'i'. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Ok, that's where you meant. Coffee not winning the battle today. Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH i-g-t 3/3] intel_gpu_top: Fix interactive header 2021-02-01 10:45 [Intel-gfx] [PATCH i-g-t 1/3] intel_gpu_top: Update manual page for recent additions Tvrtko Ursulin 2021-02-01 10:45 ` [Intel-gfx] [PATCH i-g-t 2/3] intel_gpu_top: Add option to hide inactive clients Tvrtko Ursulin @ 2021-02-01 10:45 ` Tvrtko Ursulin 2021-02-01 10:47 ` [Intel-gfx] [igt-dev] " Chris Wilson 2021-02-01 10:55 ` [Intel-gfx] [PATCH i-g-t 1/3] intel_gpu_top: Update manual page for recent additions Chris Wilson 2 siblings, 1 reply; 6+ messages in thread From: Tvrtko Ursulin @ 2021-02-01 10:45 UTC (permalink / raw) To: igt-dev; +Cc: Intel-gfx From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Client stats refactoring broke the header layout with an extra newline. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> --- tools/intel_gpu_top.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index dffc6ebecc57..9b8302de54da 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -1523,7 +1523,7 @@ print_header(const struct igt_device_card *card, printf("\033[H\033[J"); if (lines++ < con_h) - printf("intel-gpu-top: %s @ %s\n", + printf("intel-gpu-top: %s @ %s - ", codename, card->card); if (lines++ < con_h) { printf("%s/%s MHz; %s%% RC6; ", -- 2.27.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/3] intel_gpu_top: Fix interactive header 2021-02-01 10:45 ` [Intel-gfx] [PATCH i-g-t 3/3] intel_gpu_top: Fix interactive header Tvrtko Ursulin @ 2021-02-01 10:47 ` Chris Wilson 0 siblings, 0 replies; 6+ messages in thread From: Chris Wilson @ 2021-02-01 10:47 UTC (permalink / raw) To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx Quoting Tvrtko Ursulin (2021-02-01 10:45:24) > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Client stats refactoring broke the header layout with an extra newline. Argh; keep the newline, or at least check the terminal width and make the newline conditional. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t 1/3] intel_gpu_top: Update manual page for recent additions 2021-02-01 10:45 [Intel-gfx] [PATCH i-g-t 1/3] intel_gpu_top: Update manual page for recent additions Tvrtko Ursulin 2021-02-01 10:45 ` [Intel-gfx] [PATCH i-g-t 2/3] intel_gpu_top: Add option to hide inactive clients Tvrtko Ursulin 2021-02-01 10:45 ` [Intel-gfx] [PATCH i-g-t 3/3] intel_gpu_top: Fix interactive header Tvrtko Ursulin @ 2021-02-01 10:55 ` Chris Wilson 2 siblings, 0 replies; 6+ messages in thread From: Chris Wilson @ 2021-02-01 10:55 UTC (permalink / raw) To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx Quoting Tvrtko Ursulin (2021-02-01 10:45:22) > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Document numeric busyness overlay and sort selection. I looked for a 'h' or '?' screen. Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-01 10:56 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-02-01 10:45 [Intel-gfx] [PATCH i-g-t 1/3] intel_gpu_top: Update manual page for recent additions Tvrtko Ursulin 2021-02-01 10:45 ` [Intel-gfx] [PATCH i-g-t 2/3] intel_gpu_top: Add option to hide inactive clients Tvrtko Ursulin 2021-02-01 10:56 ` Chris Wilson 2021-02-01 10:45 ` [Intel-gfx] [PATCH i-g-t 3/3] intel_gpu_top: Fix interactive header Tvrtko Ursulin 2021-02-01 10:47 ` [Intel-gfx] [igt-dev] " Chris Wilson 2021-02-01 10:55 ` [Intel-gfx] [PATCH i-g-t 1/3] intel_gpu_top: Update manual page for recent additions Chris Wilson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox