Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [Intel-gfx] [PATCH v2 1/7] drm/i915: Remove dead TPS3->TPS2 fallback code
Date: Thu, 18 Mar 2021 18:10:09 +0200	[thread overview]
Message-ID: <20210318161015.22070-2-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20210318161015.22070-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

If we ever get here with TPS3 then intel_dp_training_pattern()
is just broken. Replace the creful fallback with just
MISSING_CASE().

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index d46cd205241c..d1945bff6980 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2503,11 +2503,9 @@ cpt_set_link_train(struct intel_dp *intel_dp,
 	case DP_TRAINING_PATTERN_2:
 		*DP |= DP_LINK_TRAIN_PAT_2_CPT;
 		break;
-	case DP_TRAINING_PATTERN_3:
-		drm_dbg_kms(&dev_priv->drm,
-			    "TPS3 not supported, using TPS2 instead\n");
-		*DP |= DP_LINK_TRAIN_PAT_2_CPT;
-		break;
+	default:
+		MISSING_CASE(intel_dp_training_pattern_symbol(dp_train_pat));
+		return;
 	}
 
 	intel_de_write(dev_priv, intel_dp->output_reg, intel_dp->DP);
@@ -2808,11 +2806,9 @@ g4x_set_link_train(struct intel_dp *intel_dp,
 	case DP_TRAINING_PATTERN_2:
 		*DP |= DP_LINK_TRAIN_PAT_2;
 		break;
-	case DP_TRAINING_PATTERN_3:
-		drm_dbg_kms(&dev_priv->drm,
-			    "TPS3 not supported, using TPS2 instead\n");
-		*DP |= DP_LINK_TRAIN_PAT_2;
-		break;
+	default:
+		MISSING_CASE(intel_dp_training_pattern_symbol(dp_train_pat));
+		return;
 	}
 
 	intel_de_write(dev_priv, intel_dp->output_reg, intel_dp->DP);
-- 
2.26.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-03-18 16:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 16:10 [Intel-gfx] [PATCH v2 0/7] drm/i915: Shuffle DP code around Ville Syrjala
2021-03-18 16:10 ` Ville Syrjala [this message]
2021-03-18 16:10 ` [Intel-gfx] [PATCH v2 2/7] drm/i915: Remove dead signal level debugs Ville Syrjala
2021-03-18 16:10 ` [Intel-gfx] [PATCH v2 3/7] drm/i915: Relocate intel_dp_program_link_training_pattern() Ville Syrjala
2021-03-18 16:10 ` [Intel-gfx] [PATCH v2 4/7] drm/i915: Split intel_ddi_encoder_reset() from intel_dp_encoder_reset() Ville Syrjala
2021-03-18 16:10 ` [Intel-gfx] [PATCH v2 5/7] drm/i915: Introduce g4x_dp.c Ville Syrjala
2021-03-18 16:10 ` [Intel-gfx] [PATCH v2 6/7] drm/i915: Introduce g4x_hdmi.c Ville Syrjala
2021-03-18 16:10 ` [Intel-gfx] [PATCH v2 7/7] drm/i915: Give g4x_{dp, hdmi}.c g4x_ namespace Ville Syrjala
2021-03-18 18:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Shuffle DP code around (rev2) Patchwork
2021-03-18 18:02 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-03-18 18:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-18 23:39 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210318161015.22070-2-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox