* [Intel-gfx] [PATCH] drm/i915/gvt: Fix error code in intel_gvt_init_device()
@ 2021-04-14 6:01 Dan Carpenter
2021-04-14 6:18 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-04-14 6:01 UTC (permalink / raw)
To: Zhenyu Wang
Cc: fred gao, David Airlie, intel-gfx, kernel-janitors, dri-devel,
intel-gvt-dev
The intel_gvt_init_vgpu_type_groups() function is only called from
intel_gvt_init_device(). If it fails then the intel_gvt_init_device()
prints the error code and propagates it back again. That's a bug
because false is zero/success. The fix is to modify it to return zero
or negative error codes and make everything consistent.
Fixes: c5d71cb31723 ("drm/i915/gvt: Move vGPU type related code into gvt file")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/i915/gvt/gvt.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/gvt.c b/drivers/gpu/drm/i915/gvt/gvt.c
index 2ecb8534930b..1deb253ffe80 100644
--- a/drivers/gpu/drm/i915/gvt/gvt.c
+++ b/drivers/gpu/drm/i915/gvt/gvt.c
@@ -126,7 +126,7 @@ static bool intel_get_gvt_attrs(struct attribute_group ***intel_vgpu_type_groups
return true;
}
-static bool intel_gvt_init_vgpu_type_groups(struct intel_gvt *gvt)
+static int intel_gvt_init_vgpu_type_groups(struct intel_gvt *gvt)
{
int i, j;
struct intel_vgpu_type *type;
@@ -144,7 +144,7 @@ static bool intel_gvt_init_vgpu_type_groups(struct intel_gvt *gvt)
gvt_vgpu_type_groups[i] = group;
}
- return true;
+ return 0;
unwind:
for (j = 0; j < i; j++) {
@@ -152,7 +152,7 @@ static bool intel_gvt_init_vgpu_type_groups(struct intel_gvt *gvt)
kfree(group);
}
- return false;
+ return -ENOMEM;
}
static void intel_gvt_cleanup_vgpu_type_groups(struct intel_gvt *gvt)
@@ -373,7 +373,7 @@ int intel_gvt_init_device(struct drm_i915_private *i915)
goto out_clean_thread;
ret = intel_gvt_init_vgpu_type_groups(gvt);
- if (ret == false) {
+ if (ret) {
gvt_err("failed to init vgpu type groups: %d\n", ret);
goto out_clean_types;
}
--
2.30.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gvt: Fix error code in intel_gvt_init_device()
2021-04-14 6:01 [Intel-gfx] [PATCH] drm/i915/gvt: Fix error code in intel_gvt_init_device() Dan Carpenter
@ 2021-04-14 6:18 ` Patchwork
2021-04-14 6:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2021-04-14 6:18 UTC (permalink / raw)
To: Dan Carpenter; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gvt: Fix error code in intel_gvt_init_device()
URL : https://patchwork.freedesktop.org/series/89047/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Fix error code in intel_gvt_init_device()
2021-04-14 6:01 [Intel-gfx] [PATCH] drm/i915/gvt: Fix error code in intel_gvt_init_device() Dan Carpenter
2021-04-14 6:18 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
@ 2021-04-14 6:41 ` Patchwork
2021-04-14 7:54 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-04-15 11:53 ` [Intel-gfx] [PATCH] " Zhenyu Wang
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2021-04-14 6:41 UTC (permalink / raw)
To: Dan Carpenter; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 5874 bytes --]
== Series Details ==
Series: drm/i915/gvt: Fix error code in intel_gvt_init_device()
URL : https://patchwork.freedesktop.org/series/89047/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9966 -> Patchwork_19930
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/index.html
Known issues
------------
Here are the changes found in Patchwork_19930 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-icl-y: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/fi-icl-y/igt@amdgpu/amd_basic@semaphore.html
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [PASS][2] -> [FAIL][3] ([i915#1888])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
* igt@gem_huc_copy@huc-copy:
- fi-icl-y: NOTRUN -> [SKIP][4] ([i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/fi-icl-y/igt@gem_huc_copy@huc-copy.html
* igt@i915_selftest@live@requests:
- fi-kbl-soraka: [PASS][5] -> [INCOMPLETE][6] ([i915#2782])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/fi-kbl-soraka/igt@i915_selftest@live@requests.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/fi-kbl-soraka/igt@i915_selftest@live@requests.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][7] -> [FAIL][8] ([i915#1372])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
- fi-icl-y: NOTRUN -> [SKIP][9] ([fdo#109284] / [fdo#111827]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/fi-icl-y/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-y: NOTRUN -> [SKIP][10] ([fdo#109285])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/fi-icl-y/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-icl-y: NOTRUN -> [SKIP][11] ([fdo#109278])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/fi-icl-y/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_mmap_gtt:
- fi-icl-y: NOTRUN -> [SKIP][12] ([fdo#110189]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/fi-icl-y/igt@kms_psr@primary_mmap_gtt.html
* igt@prime_vgem@basic-userptr:
- fi-icl-y: NOTRUN -> [SKIP][13] ([i915#3301])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/fi-icl-y/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-kbl-r: NOTRUN -> [FAIL][14] ([i915#1569] / [i915#192] / [i915#193] / [i915#194])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/fi-kbl-r/igt@runner@aborted.html
- fi-kbl-soraka: NOTRUN -> [FAIL][15] ([i915#1436])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/fi-kbl-soraka/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-tgl-y: [DMESG-WARN][16] ([i915#1982] / [k.org#205379]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/fi-tgl-y/igt@i915_module_load@reload.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/fi-tgl-y/igt@i915_module_load@reload.html
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1569]: https://gitlab.freedesktop.org/drm/intel/issues/1569
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#192]: https://gitlab.freedesktop.org/drm/intel/issues/192
[i915#193]: https://gitlab.freedesktop.org/drm/intel/issues/193
[i915#194]: https://gitlab.freedesktop.org/drm/intel/issues/194
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (46 -> 41)
------------------------------
Additional (1): fi-icl-y
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bdw-gvtdvm fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9966 -> Patchwork_19930
CI-20190529: 20190529
CI_DRM_9966: 0f7f5236775ef3b8bb2ed5ba456797850f0c4e93 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6064: 48d89e2c65c54883b0776930a884e6d3bcefb45b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19930: 3db6e7bc06bba9186afcd117107fe67cbbb2ed59 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3db6e7bc06bb drm/i915/gvt: Fix error code in intel_gvt_init_device()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/index.html
[-- Attachment #1.2: Type: text/html, Size: 6768 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gvt: Fix error code in intel_gvt_init_device()
2021-04-14 6:01 [Intel-gfx] [PATCH] drm/i915/gvt: Fix error code in intel_gvt_init_device() Dan Carpenter
2021-04-14 6:18 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-04-14 6:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-04-14 7:54 ` Patchwork
2021-04-15 11:53 ` [Intel-gfx] [PATCH] " Zhenyu Wang
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2021-04-14 7:54 UTC (permalink / raw)
To: Dan Carpenter; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30278 bytes --]
== Series Details ==
Series: drm/i915/gvt: Fix error code in intel_gvt_init_device()
URL : https://patchwork.freedesktop.org/series/89047/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9966_full -> Patchwork_19930_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19930_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@clone:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099]) +7 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-snb5/igt@gem_ctx_persistence@clone.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-tglb: [PASS][2] -> [TIMEOUT][3] ([i915#3063])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-tglb8/igt@gem_eio@in-flight-contexts-1us.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-tglb6/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][4] -> [FAIL][5] ([i915#2846])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-glk9/igt@gem_exec_fair@basic-deadline.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-glk3/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-kbl: NOTRUN -> [FAIL][6] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl3/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [PASS][7] -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-glk8/igt@gem_exec_fair@basic-throttle@rcs0.html
- shard-iclb: [PASS][11] -> [FAIL][12] ([i915#2849])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-iclb4/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_reloc@basic-wide-active@bcs0:
- shard-apl: NOTRUN -> [FAIL][13] ([i915#2389]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl8/igt@gem_exec_reloc@basic-wide-active@bcs0.html
* igt@gem_pwrite@basic-exhaustion:
- shard-kbl: NOTRUN -> [WARN][14] ([i915#2658])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl4/igt@gem_pwrite@basic-exhaustion.html
- shard-apl: NOTRUN -> [WARN][15] ([i915#2658])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl1/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_userptr_blits@mmap-offset-invalidate-active@wb:
- shard-snb: NOTRUN -> [SKIP][16] ([fdo#109271]) +398 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-snb2/igt@gem_userptr_blits@mmap-offset-invalidate-active@wb.html
* igt@gem_userptr_blits@process-exit-mmap-busy@uc:
- shard-kbl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#1699]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl3/igt@gem_userptr_blits@process-exit-mmap-busy@uc.html
* igt@gem_userptr_blits@set-cache-level:
- shard-kbl: NOTRUN -> [FAIL][18] ([i915#3324])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl4/igt@gem_userptr_blits@set-cache-level.html
- shard-apl: NOTRUN -> [FAIL][19] ([i915#3324])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl1/igt@gem_userptr_blits@set-cache-level.html
* igt@i915_hangman@engine-error@vecs0:
- shard-kbl: NOTRUN -> [SKIP][20] ([fdo#109271]) +69 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl4/igt@i915_hangman@engine-error@vecs0.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][21] -> [INCOMPLETE][22] ([i915#2782])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-snb5/igt@i915_selftest@live@hangcheck.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-snb6/igt@i915_selftest@live@hangcheck.html
* igt@kms_ccs@pipe-c-random-ccs-data:
- shard-skl: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111304])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl8/igt@kms_ccs@pipe-c-random-ccs-data.html
* igt@kms_chamelium@dp-crc-single:
- shard-kbl: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl4/igt@kms_chamelium@dp-crc-single.html
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827]) +6 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl9/igt@kms_chamelium@hdmi-aspect-ratio.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +15 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl1/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-c-ctm-red-to-blue:
- shard-snb: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +22 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-snb2/igt@kms_color_chamelium@pipe-c-ctm-red-to-blue.html
* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][28] ([i915#1319]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl1/igt@kms_content_protection@atomic-dpms.html
- shard-kbl: NOTRUN -> [TIMEOUT][29] ([i915#1319])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl4/igt@kms_content_protection@atomic-dpms.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][30] -> [DMESG-WARN][31] ([i915#180]) +6 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_flip@2x-flip-vs-panning-vs-hang:
- shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271]) +57 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl9/igt@kms_flip@2x-flip-vs-panning-vs-hang.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: NOTRUN -> [FAIL][33] ([i915#79])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [PASS][34] -> [FAIL][35] ([i915#79]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-glk5/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: [PASS][36] -> [FAIL][37] ([i915#2122]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#2672])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#2642])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#2672])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#533])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl1/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][42] ([fdo#108145] / [i915#265])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][43] -> [FAIL][44] ([fdo#108145] / [i915#265])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][45] ([i915#265])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][46] ([fdo#108145] / [i915#265])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
- shard-apl: NOTRUN -> [FAIL][47] ([fdo#108145] / [i915#265]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#2733])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl2/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#658])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
- shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#658]) +3 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl2/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-skl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#658]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [PASS][52] -> [SKIP][53] ([fdo#109441]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-iclb5/igt@kms_psr@psr2_sprite_render.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-skl: [PASS][54] -> [INCOMPLETE][55] ([i915#198] / [i915#2828])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl5/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@kms_vblank@pipe-d-wait-forked-hang:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271]) +229 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl8/igt@kms_vblank@pipe-d-wait-forked-hang.html
* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#2437]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl2/igt@kms_writeback@writeback-check-output.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][58] -> [FAIL][59] ([i915#1542])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl1/igt@perf@polling-parameterized.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl5/igt@perf@polling-parameterized.html
* igt@sysfs_clients@recycle:
- shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2994])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl4/igt@sysfs_clients@recycle.html
* igt@sysfs_clients@sema-25:
- shard-skl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#2994])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl4/igt@sysfs_clients@sema-25.html
* igt@sysfs_clients@split-50:
- shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#2994]) +2 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl1/igt@sysfs_clients@split-50.html
#### Possible fixes ####
* igt@gem_create@create-clear:
- shard-glk: [FAIL][63] ([i915#1888] / [i915#3160]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-glk4/igt@gem_create@create-clear.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-glk2/igt@gem_create@create-clear.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][65] ([i915#2369] / [i915#3063]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-tglb3/igt@gem_eio@unwedge-stress.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-tglb7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [INCOMPLETE][67] ([i915#2369]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl2/igt@gem_exec_capture@pi@rcs0.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl6/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][69] ([i915#2842]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][71] ([i915#2842]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [SKIP][73] ([fdo#109271]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl6/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_mmap_gtt@big-copy-xy:
- shard-glk: [FAIL][75] ([i915#307]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-glk7/igt@gem_mmap_gtt@big-copy-xy.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-glk5/igt@gem_mmap_gtt@big-copy-xy.html
* igt@gem_vm_create@destroy-race:
- shard-tglb: [TIMEOUT][77] ([i915#2795]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-tglb5/igt@gem_vm_create@destroy-race.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-tglb1/igt@gem_vm_create@destroy-race.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][79] ([i915#1436] / [i915#716]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl8/igt@gen9_exec_parse@allowed-single.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl4/igt@gen9_exec_parse@allowed-single.html
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [FAIL][81] ([i915#2574]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-tglb8/igt@kms_async_flips@test-time-stamp.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-tglb3/igt@kms_async_flips@test-time-stamp.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [DMESG-WARN][83] ([i915#180]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-apl8/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl8/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled:
- shard-glk: [FAIL][85] ([i915#52] / [i915#54]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-glk2/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-glk9/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-kbl: [DMESG-WARN][87] ([i915#180]) -> [PASS][88] +3 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl6/igt@kms_flip@flip-vs-suspend@a-dp1.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl3/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip@plain-flip-ts-check@c-edp1:
- shard-skl: [FAIL][89] ([i915#2122]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl6/igt@kms_flip@plain-flip-ts-check@c-edp1.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl10/igt@kms_flip@plain-flip-ts-check@c-edp1.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [FAIL][91] ([i915#1188]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl10/igt@kms_hdr@bpc-switch.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl9/igt@kms_hdr@bpc-switch.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-skl: [INCOMPLETE][93] ([i915#198]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl9/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][95] ([fdo#108145] / [i915#265]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][97] ([fdo#109441]) -> [PASS][98] +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-b-accuracy-idle:
- shard-glk: [FAIL][99] ([i915#43]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-glk5/igt@kms_vblank@pipe-b-accuracy-idle.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-glk1/igt@kms_vblank@pipe-b-accuracy-idle.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: [INCOMPLETE][101] ([i915#155] / [i915#2828] / [i915#794]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@perf@polling-small-buf:
- shard-skl: [FAIL][103] ([i915#1722]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl5/igt@perf@polling-small-buf.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl2/igt@perf@polling-small-buf.html
* igt@sysfs_heartbeat_interval@mixed@vcs0:
- shard-skl: [FAIL][105] ([i915#1731]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl7/igt@sysfs_heartbeat_interval@mixed@vcs0.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl8/igt@sysfs_heartbeat_interval@mixed@vcs0.html
#### Warnings ####
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [SKIP][107] ([fdo#109271]) -> [FAIL][108] ([i915#2842])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs0.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [FAIL][109] ([i915#307]) -> [FAIL][110] ([i915#2428])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-iclb2/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-iclb3/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [DMESG-WARN][111] ([i915#180]) -> [INCOMPLETE][112] ([i915#155] / [i915#2405])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl7/igt@gem_workarounds@suspend-resume-fd.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
- shard-iclb: [SKIP][113] ([i915#658]) -> [SKIP][114] ([i915#2920])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-iclb4/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-iclb: [SKIP][115] ([i915#2920]) -> [SKIP][116] ([i915#658]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-iclb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123]) ([i915#180] / [i915#2505] / [i915#3002] / [i915#92]) -> ([FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl6/igt@runner@aborted.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl7/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl7/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl7/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl7/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl1/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-kbl7/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl1/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl7/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl1/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl7/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl6/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl6/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl1/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl7/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-kbl7/igt@runner@aborted.html
- shard-apl: ([FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136]) ([i915#180] / [i915#1814] / [i915#3002]) -> ([FAIL][137], [FAIL][138]) ([i915#3002])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-apl6/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-apl2/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-apl2/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-apl8/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl7/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-apl2/igt@runner@aborted.html
- shard-skl: ([FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143]) ([i915#1436] / [i915#1814] / [i915#2029] / [i915#2369] / [i915#3002]) -> ([FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147]) ([i915#1814] / [i915#2029] / [i915#2292] / [i915#3002])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl2/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl2/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl2/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl9/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9966/shard-skl8/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl6/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl5/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl2/igt@runner@aborted.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/shard-skl5/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1699]: https://gitlab.freedesktop.org/drm/intel/issues/1699
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2428]: https://gitlab.freedesktop.org/drm/intel/issues/2428
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2574]: https://gitlab.freedesktop.org/drm/intel/issues/2574
[i915#2642]: https://gitlab.freedesktop.org/drm/intel/issues/2642
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2733]: https://gitlab.freedesktop.org/drm/intel/issues/2733
[i915#
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19930/index.html
[-- Attachment #1.2: Type: text/html, Size: 37136 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix error code in intel_gvt_init_device()
2021-04-14 6:01 [Intel-gfx] [PATCH] drm/i915/gvt: Fix error code in intel_gvt_init_device() Dan Carpenter
` (2 preceding siblings ...)
2021-04-14 7:54 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-04-15 11:53 ` Zhenyu Wang
3 siblings, 0 replies; 5+ messages in thread
From: Zhenyu Wang @ 2021-04-15 11:53 UTC (permalink / raw)
To: Dan Carpenter
Cc: fred gao, David Airlie, intel-gfx, kernel-janitors, dri-devel,
intel-gvt-dev
[-- Attachment #1.1: Type: text/plain, Size: 2248 bytes --]
On 2021.04.14 09:01:38 +0300, Dan Carpenter wrote:
> The intel_gvt_init_vgpu_type_groups() function is only called from
> intel_gvt_init_device(). If it fails then the intel_gvt_init_device()
> prints the error code and propagates it back again. That's a bug
> because false is zero/success. The fix is to modify it to return zero
> or negative error codes and make everything consistent.
>
> Fixes: c5d71cb31723 ("drm/i915/gvt: Move vGPU type related code into gvt file")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Thanks, Dan! Applied this.
> drivers/gpu/drm/i915/gvt/gvt.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/gvt.c b/drivers/gpu/drm/i915/gvt/gvt.c
> index 2ecb8534930b..1deb253ffe80 100644
> --- a/drivers/gpu/drm/i915/gvt/gvt.c
> +++ b/drivers/gpu/drm/i915/gvt/gvt.c
> @@ -126,7 +126,7 @@ static bool intel_get_gvt_attrs(struct attribute_group ***intel_vgpu_type_groups
> return true;
> }
>
> -static bool intel_gvt_init_vgpu_type_groups(struct intel_gvt *gvt)
> +static int intel_gvt_init_vgpu_type_groups(struct intel_gvt *gvt)
> {
> int i, j;
> struct intel_vgpu_type *type;
> @@ -144,7 +144,7 @@ static bool intel_gvt_init_vgpu_type_groups(struct intel_gvt *gvt)
> gvt_vgpu_type_groups[i] = group;
> }
>
> - return true;
> + return 0;
>
> unwind:
> for (j = 0; j < i; j++) {
> @@ -152,7 +152,7 @@ static bool intel_gvt_init_vgpu_type_groups(struct intel_gvt *gvt)
> kfree(group);
> }
>
> - return false;
> + return -ENOMEM;
> }
>
> static void intel_gvt_cleanup_vgpu_type_groups(struct intel_gvt *gvt)
> @@ -373,7 +373,7 @@ int intel_gvt_init_device(struct drm_i915_private *i915)
> goto out_clean_thread;
>
> ret = intel_gvt_init_vgpu_type_groups(gvt);
> - if (ret == false) {
> + if (ret) {
> gvt_err("failed to init vgpu type groups: %d\n", ret);
> goto out_clean_types;
> }
> --
> 2.30.2
>
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-15 12:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-14 6:01 [Intel-gfx] [PATCH] drm/i915/gvt: Fix error code in intel_gvt_init_device() Dan Carpenter
2021-04-14 6:18 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-04-14 6:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-14 7:54 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-04-15 11:53 ` [Intel-gfx] [PATCH] " Zhenyu Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox