Re: [Intel-gfx] [PATCH 5/5] drm/i915/debugfs: pass intel_connector to intel_connector_debugfs_add()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5620 bytes --]

Hi Jani,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip next-20210830]
[cannot apply to v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jani-Nikula/drm-i915-display-debugfs-cleanups/20210830-205450
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/3398bb6468f037af818548e7987e8fd062278824
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jani-Nikula/drm-i915-display-debugfs-cleanups/20210830-205450
        git checkout 3398bb6468f037af818548e7987e8fd062278824
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/display/intel_display_debugfs.c:2447:6: error: conflicting types for 'intel_connector_debugfs_add'
    2447 | void intel_connector_debugfs_add(struct intel_connector *intel_connector)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/i915/display/intel_display_debugfs.c:10:
   drivers/gpu/drm/i915/display/intel_display_debugfs.h:15:6: note: previous declaration of 'intel_connector_debugfs_add' was here
      15 | void intel_connector_debugfs_add(struct drm_connector *connector);
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
--
   drivers/gpu/drm/i915/display/intel_connector.c: In function 'intel_connector_register':
>> drivers/gpu/drm/i915/display/intel_connector.c:127:30: error: passing argument 1 of 'intel_connector_debugfs_add' from incompatible pointer type [-Werror=incompatible-pointer-types]
     127 |  intel_connector_debugfs_add(intel_connector);
         |                              ^~~~~~~~~~~~~~~
         |                              |
         |                              struct intel_connector *
   In file included from drivers/gpu/drm/i915/display/intel_connector.c:36:
   drivers/gpu/drm/i915/display/intel_display_debugfs.h:15:56: note: expected 'struct drm_connector *' but argument is of type 'struct intel_connector *'
      15 | void intel_connector_debugfs_add(struct drm_connector *connector);
         |                                  ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
   cc1: all warnings being treated as errors


vim +/intel_connector_debugfs_add +2447 drivers/gpu/drm/i915/display/intel_display_debugfs.c

  2439	
  2440	/**
  2441	 * intel_connector_debugfs_add - add i915 specific connector debugfs files
  2442	 * @connector: pointer to a registered drm_connector
  2443	 *
  2444	 * Cleanup will be done by drm_connector_unregister() through a call to
  2445	 * drm_debugfs_connector_remove().
  2446	 */
> 2447	void intel_connector_debugfs_add(struct intel_connector *intel_connector)
  2448	{
  2449		struct drm_connector *connector = &intel_connector->base;
  2450		struct dentry *root = connector->debugfs_entry;
  2451		struct drm_i915_private *dev_priv = to_i915(connector->dev);
  2452	
  2453		/* The connector must have been registered beforehands. */
  2454		if (!root)
  2455			return;
  2456	
  2457		if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
  2458			debugfs_create_file("i915_panel_timings", S_IRUGO, root,
  2459					    connector, &i915_panel_fops);
  2460			debugfs_create_file("i915_psr_sink_status", S_IRUGO, root,
  2461					    connector, &i915_psr_sink_status_fops);
  2462		}
  2463	
  2464		if (HAS_PSR(dev_priv) &&
  2465		    connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
  2466			debugfs_create_file("i915_psr_status", 0444, root,
  2467					    connector, &i915_psr_status_fops);
  2468		}
  2469	
  2470		if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
  2471		    connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
  2472		    connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) {
  2473			debugfs_create_file("i915_hdcp_sink_capability", S_IRUGO, root,
  2474					    connector, &i915_hdcp_sink_capability_fops);
  2475		}
  2476	
  2477		if (DISPLAY_VER(dev_priv) >= 11 &&
  2478		    ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
  2479		    !to_intel_connector(connector)->mst_port) ||
  2480		    connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
  2481			debugfs_create_file("i915_dsc_fec_support", 0644, root,
  2482					    connector, &i915_dsc_fec_support_fops);
  2483	
  2484			debugfs_create_file("i915_dsc_bpp", 0644, root,
  2485					    connector, &i915_dsc_bpp_fops);
  2486		}
  2487	
  2488		if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
  2489		    connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
  2490		    connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
  2491		    connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
  2492		    connector->connector_type == DRM_MODE_CONNECTOR_HDMIB)
  2493			debugfs_create_file("i915_lpsp_capability", 0444, root,
  2494					    connector, &i915_lpsp_capability_fops);
  2495	}
  2496	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65210 bytes --]