From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/5] drm/i915/debugfs: clean up LPSP status
Date: Wed, 1 Sep 2021 12:13:03 -0400 [thread overview]
Message-ID: <YS+mjy+DNyZ4rMCr@intel.com> (raw)
In-Reply-To: <c7c2db4e1434ed9a3545f2561a03dc593db5e674.1630327990.git.jani.nikula@intel.com>
On Mon, Aug 30, 2021 at 03:53:40PM +0300, Jani Nikula wrote:
> Clean up the LPSP status printout. No functional changes.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> .../drm/i915/display/intel_display_debugfs.c | 37 ++++++-------------
> 1 file changed, 11 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 8fdacb252bb1..d2a14a9c6857 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -1323,9 +1323,6 @@ static int i915_drrs_status(struct seq_file *m, void *unused)
> return 0;
> }
>
> -#define LPSP_STATUS(COND) (COND ? seq_puts(m, "LPSP: enabled\n") : \
> - seq_puts(m, "LPSP: disabled\n"))
> -
> static bool
> intel_lpsp_power_well_enabled(struct drm_i915_private *i915,
> enum i915_power_well_id power_well_id)
> @@ -1344,32 +1341,20 @@ intel_lpsp_power_well_enabled(struct drm_i915_private *i915,
> static int i915_lpsp_status(struct seq_file *m, void *unused)
> {
> struct drm_i915_private *i915 = node_to_i915(m->private);
> -
> - if (DISPLAY_VER(i915) >= 13) {
> - LPSP_STATUS(!intel_lpsp_power_well_enabled(i915,
> - SKL_DISP_PW_2));
> + bool lpsp_enabled = false;
> +
> + if (DISPLAY_VER(i915) >= 13 || IS_DISPLAY_VER(i915, 9, 10)) {
> + lpsp_enabled = !intel_lpsp_power_well_enabled(i915, SKL_DISP_PW_2);
> + } else if (IS_DISPLAY_VER(i915, 11, 12)) {
> + lpsp_enabled = !intel_lpsp_power_well_enabled(i915, ICL_DISP_PW_3);
> + } else if (IS_HASWELL(i915) || IS_BROADWELL(i915)) {
> + lpsp_enabled = !intel_lpsp_power_well_enabled(i915, HSW_DISP_PW_GLOBAL);
> + } else {
> + seq_puts(m, "LPSP: not supported\n");
> return 0;
> }
>
> - switch (DISPLAY_VER(i915)) {
> - case 12:
> - case 11:
> - LPSP_STATUS(!intel_lpsp_power_well_enabled(i915, ICL_DISP_PW_3));
> - break;
> - case 10:
> - case 9:
> - LPSP_STATUS(!intel_lpsp_power_well_enabled(i915, SKL_DISP_PW_2));
> - break;
> - default:
> - /*
> - * Apart from HASWELL/BROADWELL other legacy platform doesn't
> - * support lpsp.
> - */
> - if (IS_HASWELL(i915) || IS_BROADWELL(i915))
> - LPSP_STATUS(!intel_lpsp_power_well_enabled(i915, HSW_DISP_PW_GLOBAL));
> - else
> - seq_puts(m, "LPSP: not supported\n");
> - }
> + seq_printf(m, "LPSP: %s\n", enableddisabled(lpsp_enabled));
>
> return 0;
> }
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-09-01 16:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 12:53 [Intel-gfx] [PATCH 0/5] drm/i915/display: debugfs cleanups Jani Nikula
2021-08-30 12:53 ` [Intel-gfx] [PATCH 1/5] drm/i915/debugfs: clean up LPSP status Jani Nikula
2021-09-01 16:13 ` Rodrigo Vivi [this message]
2021-08-30 12:53 ` [Intel-gfx] [PATCH 2/5] drm/i915/debugfs: clean up LPSP capable Jani Nikula
2021-09-01 16:14 ` Rodrigo Vivi
2021-09-02 11:14 ` Jani Nikula
2021-08-30 12:53 ` [Intel-gfx] [PATCH 3/5] drm/i915/debugfs: register LPSP capability on all platforms Jani Nikula
2021-09-01 16:19 ` Rodrigo Vivi
2021-08-30 12:53 ` [Intel-gfx] [PATCH 4/5] drm/i915/display: stop returning errors from debugfs registration Jani Nikula
2021-09-01 16:20 ` Rodrigo Vivi
2021-09-01 17:02 ` Jani Nikula
2021-09-02 12:15 ` Vivi, Rodrigo
2021-08-30 12:53 ` [Intel-gfx] [PATCH 5/5] drm/i915/debugfs: pass intel_connector to intel_connector_debugfs_add() Jani Nikula
2021-08-30 14:02 ` [Intel-gfx] [PATCH v2] " Jani Nikula
2021-08-30 20:48 ` [Intel-gfx] [PATCH 5/5] " kernel test robot
2021-08-31 16:00 ` kernel test robot
2021-09-01 16:09 ` Rodrigo Vivi
2021-09-01 16:11 ` Rodrigo Vivi
2021-09-01 17:03 ` Jani Nikula
2021-08-30 13:31 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/display: debugfs cleanups Patchwork
2021-08-30 14:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: debugfs cleanups (rev2) Patchwork
2021-08-30 16:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS+mjy+DNyZ4rMCr@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox