From: Sean Paul <sean@poorly.run>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Sean Paul <sean@poorly.run>,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org,
Sean Paul <seanpaul@chromium.org>,
Rob Clark <robdclark@gmail.com>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH v2 10/13] drm/msm/dpu: Remove encoder->enable() hack
Date: Fri, 17 Sep 2021 13:25:25 -0400 [thread overview]
Message-ID: <20210917172525.GQ2515@art_vandelay> (raw)
In-Reply-To: <CAE-0n53uAEcj8Rpx36cRUU34k9mqtg2_tiXW_4+CYmrcihguHg@mail.gmail.com>
On Thu, Sep 16, 2021 at 08:53:50PM -0700, Stephen Boyd wrote:
> Quoting Sean Paul (2021-09-15 13:38:29)
> > From: Sean Paul <seanpaul@chromium.org>
> >
> > encoder->commit() was being misused because there were some global
> > resources which needed to be tweaked in encoder->enable() which were not
> > accessible in dpu_encoder.c. That is no longer true and the redirect
> > serves no purpose any longer. So remove the indirection.
>
> When did it become false? Just curious when this became obsolete.
In commit
commit cd6d923167b1bf3e051f9d90fa129456d78ef06e
Author: Rob Clark <robdclark@chromium.org>
Date: Thu Aug 29 09:45:17 2019 -0700
drm/msm/dpu: async commit support
There was a call to dpu_crtc_commit_kickoff() which was removed from
dpu_kms_encoder_enable(). That was the bit which required the back-and-forth
between ->enable() and ->commit().
>
> >
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> > Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-11-sean@poorly.run #v1
> >
> > Changes in v2:
> > -None
> > ---
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Tested-by: Stephen Boyd <swboyd@chromium.org>
Thanks!
--
Sean Paul, Software Engineer, Google / Chromium OS
next prev parent reply other threads:[~2021-09-17 17:25 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 20:38 [Intel-gfx] [PATCH v2 00/13] drm/hdcp: Pull HDCP auth/exchange/check into helpers Sean Paul
2021-09-15 20:38 ` [Intel-gfx] [PATCH v2 01/13] drm/hdcp: Add drm_hdcp_atomic_check() Sean Paul
2021-09-15 20:38 ` [Intel-gfx] [PATCH v2 02/13] drm/hdcp: Avoid changing crtc state in hdcp atomic check Sean Paul
2021-09-15 20:38 ` [Intel-gfx] [PATCH v2 03/13] drm/hdcp: Update property value on content type and user changes Sean Paul
2021-09-16 22:48 ` kernel test robot
2021-09-15 20:38 ` [Intel-gfx] [PATCH v2 04/13] drm/hdcp: Expand HDCP helper library for enable/disable/check Sean Paul
2021-09-17 10:58 ` [Intel-gfx] [kbuild] " Dan Carpenter
2021-09-21 23:34 ` [Intel-gfx] [Freedreno] " abhinavk
2021-09-28 17:33 ` Sean Paul
2021-09-28 21:28 ` abhinavk
2021-09-15 20:38 ` [Intel-gfx] [PATCH v2 05/13] drm/i915/hdcp: Consolidate HDCP setup/state cache Sean Paul
2021-09-15 20:38 ` [Intel-gfx] [PATCH v2 06/13] drm/i915/hdcp: Retain hdcp_capable return codes Sean Paul
2021-09-15 20:38 ` [Intel-gfx] [PATCH v2 07/13] drm/i915/hdcp: Use HDCP helpers for i915 Sean Paul
2021-09-17 0:10 ` kernel test robot
2021-09-15 20:38 ` [Intel-gfx] [PATCH v2 08/13] drm/msm/dpu_kms: Re-order dpu includes Sean Paul
2021-09-17 3:54 ` Stephen Boyd
2021-09-22 2:26 ` [Intel-gfx] [Freedreno] " abhinavk
2021-09-15 20:38 ` [Intel-gfx] [PATCH v2 09/13] drm/msm/dpu: Remove useless checks in dpu_encoder Sean Paul
2021-09-17 3:54 ` Stephen Boyd
2021-09-15 20:38 ` [Intel-gfx] [PATCH v2 10/13] drm/msm/dpu: Remove encoder->enable() hack Sean Paul
2021-09-17 3:53 ` Stephen Boyd
2021-09-17 17:25 ` Sean Paul [this message]
2021-09-15 20:38 ` [Intel-gfx] [PATCH v2 11/13] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules Sean Paul
2021-09-17 3:51 ` Stephen Boyd
2021-09-15 20:38 ` [Intel-gfx] [PATCH v2 12/13] dt-bindings: msm/dp: Add bindings for HDCP registers Sean Paul
2021-09-16 12:21 ` Rob Herring
2021-09-16 12:58 ` Rob Herring
2021-09-15 20:38 ` [Intel-gfx] [PATCH v2 13/13] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers Sean Paul
2021-09-17 4:30 ` kernel test robot
2021-09-17 6:00 ` Stephen Boyd
2021-09-17 21:05 ` Sean Paul
2021-09-22 2:25 ` [Intel-gfx] [Freedreno] " abhinavk
2021-09-28 18:02 ` Sean Paul
2021-09-28 21:35 ` abhinavk
2021-09-29 14:52 ` Sean Paul
2021-09-15 21:58 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/hdcp: Pull HDCP auth/exchange/check into helpers Patchwork
2021-09-17 12:49 ` Jani Nikula
2021-09-17 12:51 ` [Intel-gfx] [PATCH v2 00/13] " Jani Nikula
2021-09-22 2:30 ` [Intel-gfx] [Freedreno] " abhinavk
2021-09-28 18:06 ` Sean Paul
2021-09-28 21:23 ` abhinavk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210917172525.GQ2515@art_vandelay \
--to=sean@poorly.run \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox