From: John.C.Harrison@Intel.com
To: IGT-Dev@Lists.FreeDesktop.Org
Cc: Intel-GFX@Lists.FreeDesktop.Org,
John Harrison <John.C.Harrison@Intel.com>
Subject: [Intel-gfx] [PATCH v2 i-g-t] tests/i915: Skip gem_exec_fair on GuC based platforms
Date: Thu, 14 Oct 2021 12:42:38 -0700 [thread overview]
Message-ID: <20211014194238.1078854-1-John.C.Harrison@Intel.com> (raw)
From: John Harrison <John.C.Harrison@Intel.com>
The gem_exec_fair test is specifically testing scheduler algorithm
performance. However, GuC does not implement the same algorithm as
execlist mode and this test is not applicable. So, until sw arch
approves a new algorithm and it is implemented in GuC, stop running
the test.
v2: Add exceptions for TGL/RKL/ADL-S - review feedback from Tvrtko.
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
tests/i915/gem_exec_fair.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/tests/i915/gem_exec_fair.c b/tests/i915/gem_exec_fair.c
index ef5a450f6..fc690f438 100644
--- a/tests/i915/gem_exec_fair.c
+++ b/tests/i915/gem_exec_fair.c
@@ -1302,6 +1302,8 @@ igt_main
int i915 = -1;
igt_fixture {
+ uint32_t devid;
+
igt_require_sw_sync();
i915 = drm_open_driver_master(DRIVER_INTEL);
@@ -1314,6 +1316,14 @@ igt_main
igt_require(gem_scheduler_enabled(i915));
igt_require(gem_scheduler_has_ctx_priority(i915));
+ /*
+ * These tests are for a specific scheduling model which is
+ * not currently implemented by GuC. So skip on GuC platforms.
+ */
+ devid = intel_get_drm_devid(i915);
+ igt_require((intel_gen(devid) < 12) || IS_TIGERLAKE(devid) ||
+ IS_ROCKETLAKE(devid) || IS_ALDERLAKE_S(devid));
+
cfg = intel_ctx_cfg_all_physical(i915);
igt_info("CS timestamp frequency: %d\n",
--
2.25.1
next reply other threads:[~2021-10-14 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 19:42 John.C.Harrison [this message]
2021-10-15 14:52 ` [Intel-gfx] [igt-dev] [PATCH v2 i-g-t] tests/i915: Skip gem_exec_fair on GuC based platforms Dixit, Ashutosh
2021-10-15 21:46 ` John Harrison
2021-10-15 22:41 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014194238.1078854-1-John.C.Harrison@Intel.com \
--to=john.c.harrison@intel.com \
--cc=IGT-Dev@Lists.FreeDesktop.Org \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox