From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: <John.C.Harrison@Intel.com>
Cc: <IGT-Dev@Lists.FreeDesktop.Org>, <Intel-GFX@Lists.FreeDesktop.Org>
Subject: Re: [Intel-gfx] [igt-dev] [PATCH v2 i-g-t] tests/i915: Skip gem_exec_fair on GuC based platforms
Date: Fri, 15 Oct 2021 07:52:46 -0700 [thread overview]
Message-ID: <87k0iecpc1.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20211014194238.1078854-1-John.C.Harrison@Intel.com>
On Thu, 14 Oct 2021 12:42:38 -0700, <John.C.Harrison@Intel.com> wrote:
>
> + /*
> + * These tests are for a specific scheduling model which is
> + * not currently implemented by GuC. So skip on GuC platforms.
> + */
> + devid = intel_get_drm_devid(i915);
> + igt_require((intel_gen(devid) < 12) || IS_TIGERLAKE(devid) ||
> + IS_ROCKETLAKE(devid) || IS_ALDERLAKE_S(devid));
As I hinted on v1 let's just do this here:
igt_require(gem_has_guc_submission(i915));
So that we can can have a single unified way of detecting if GuC is being
used throughout IGT. Today it is gem_has_guc_submission() and it works with
the current kernel.
next prev parent reply other threads:[~2021-10-15 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 19:42 [Intel-gfx] [PATCH v2 i-g-t] tests/i915: Skip gem_exec_fair on GuC based platforms John.C.Harrison
2021-10-15 14:52 ` Dixit, Ashutosh [this message]
2021-10-15 21:46 ` [Intel-gfx] [igt-dev] " John Harrison
2021-10-15 22:41 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0iecpc1.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=IGT-Dev@Lists.FreeDesktop.Org \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=John.C.Harrison@Intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox