public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 2/4] drm/i915/dg2: Add Wa_16011777198
Date: Thu, 11 Nov 2021 13:56:42 -0800	[thread overview]
Message-ID: <20211111215644.1123373-3-matthew.d.roper@intel.com> (raw)
In-Reply-To: <20211111215644.1123373-1-matthew.d.roper@intel.com>

Coarse power gating for render should not be enabled on some DG2
steppings.

Bspec: 52698
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_rc6.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
index 43093dd2d0c9..c3155ee58689 100644
--- a/drivers/gpu/drm/i915/gt/intel_rc6.c
+++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
@@ -117,10 +117,17 @@ static void gen11_rc6_enable(struct intel_rc6 *rc6)
 			GEN6_RC_CTL_RC6_ENABLE |
 			GEN6_RC_CTL_EI_MODE(1);
 
-	pg_enable =
-		GEN9_RENDER_PG_ENABLE |
-		GEN9_MEDIA_PG_ENABLE |
-		GEN11_MEDIA_SAMPLER_PG_ENABLE;
+	/* Wa_16011777198 - Render powergating must remain disabled */
+	if (IS_DG2_GRAPHICS_STEP(gt->i915, G10, STEP_A0, STEP_C0) ||
+	    IS_DG2_GRAPHICS_STEP(gt->i915, G11, STEP_A0, STEP_B0))
+		pg_enable =
+			GEN9_MEDIA_PG_ENABLE |
+			GEN11_MEDIA_SAMPLER_PG_ENABLE;
+	else
+		pg_enable =
+			GEN9_RENDER_PG_ENABLE |
+			GEN9_MEDIA_PG_ENABLE |
+			GEN11_MEDIA_SAMPLER_PG_ENABLE;
 
 	if (GRAPHICS_VER(gt->i915) >= 12) {
 		for (i = 0; i < I915_MAX_VCS; i++)
-- 
2.33.0


  parent reply	other threads:[~2021-11-11 21:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 21:56 [Intel-gfx] [PATCH 0/4] i915: Additional DG2 workarounds Matt Roper
2021-11-11 21:56 ` [Intel-gfx] [PATCH 1/4] drm/i915/dg2: Add Wa_14010547955 Matt Roper
2021-11-12  9:33   ` Jani Nikula
2021-11-11 21:56 ` Matt Roper [this message]
2021-11-11 21:56 ` [Intel-gfx] [PATCH 3/4] drm/i915/dg2: Add Wa_16013000631 Matt Roper
2021-11-12  5:15   ` [Intel-gfx] [PATCH v2 " Matt Roper
2021-11-11 21:56 ` [Intel-gfx] [PATCH 4/4] drm/i915/dg2: extend Wa_1409120013 to DG2 Matt Roper
2021-11-11 22:13 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Additional DG2 workarounds Patchwork
2021-11-11 22:17 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-11-11 22:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-11-12  6:19 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Additional DG2 workarounds (rev2) Patchwork
2021-11-12  6:22 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-11-12  6:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-11-12  8:30 ` [Intel-gfx] ✓ Fi.CI.IGT: success for i915: Additional DG2 workarounds Patchwork
2021-11-12 13:08 ` [Intel-gfx] ✓ Fi.CI.IGT: success for i915: Additional DG2 workarounds (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211111215644.1123373-3-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox