Re: [Intel-gfx] [PATCH v4 1/6] drm/i915: Add support for moving fence waiting

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3696 bytes --]

Hi "Thomas,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-tip/drm-tip]
[also build test ERROR on drm-exynos/exynos-drm-next drm/drm-next v5.16-rc1 next-20211118]
[cannot apply to drm-intel/for-linux-next tegra-drm/drm/tegra/for-next airlied/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-ttm-Async-migration/20211118-210436
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-randconfig-r001-20211118 (attached as .config)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/316dda0c6b91d043111cb348b43be6a6f2e3bb0a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Thomas-Hellstr-m/drm-i915-ttm-Async-migration/20211118-210436
        git checkout 316dda0c6b91d043111cb348b43be6a6f2e3bb0a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/i915_vma.c:478:13: error: implicit declaration of function 'i915_vma_verify_bind_complete' [-Werror,-Wimplicit-function-declaration]
           GEM_BUG_ON(i915_vma_verify_bind_complete(vma));
                      ^
   1 error generated.


vim +/i915_vma_verify_bind_complete +478 drivers/gpu/drm/i915/i915_vma.c

   463	
   464	void __iomem *i915_vma_pin_iomap(struct i915_vma *vma)
   465	{
   466		void __iomem *ptr;
   467		int err;
   468	
   469		if (!i915_gem_object_is_lmem(vma->obj)) {
   470			if (GEM_WARN_ON(!i915_vma_is_map_and_fenceable(vma))) {
   471				err = -ENODEV;
   472				goto err;
   473			}
   474		}
   475	
   476		GEM_BUG_ON(!i915_vma_is_ggtt(vma));
   477		GEM_BUG_ON(!i915_vma_is_bound(vma, I915_VMA_GLOBAL_BIND));
 > 478		GEM_BUG_ON(i915_vma_verify_bind_complete(vma));
   479	
   480		ptr = READ_ONCE(vma->iomap);
   481		if (ptr == NULL) {
   482			/*
   483			 * TODO: consider just using i915_gem_object_pin_map() for lmem
   484			 * instead, which already supports mapping non-contiguous chunks
   485			 * of pages, that way we can also drop the
   486			 * I915_BO_ALLOC_CONTIGUOUS when allocating the object.
   487			 */
   488			if (i915_gem_object_is_lmem(vma->obj))
   489				ptr = i915_gem_object_lmem_io_map(vma->obj, 0,
   490								  vma->obj->base.size);
   491			else
   492				ptr = io_mapping_map_wc(&i915_vm_to_ggtt(vma->vm)->iomap,
   493							vma->node.start,
   494							vma->node.size);
   495			if (ptr == NULL) {
   496				err = -ENOMEM;
   497				goto err;
   498			}
   499	
   500			if (unlikely(cmpxchg(&vma->iomap, NULL, ptr))) {
   501				io_mapping_unmap(ptr);
   502				ptr = vma->iomap;
   503			}
   504		}
   505	
   506		__i915_vma_pin(vma);
   507	
   508		err = i915_vma_pin_fence(vma);
   509		if (err)
   510			goto err_unpin;
   511	
   512		i915_vma_set_ggtt_write(vma);
   513	
   514		/* NB Access through the GTT requires the device to be awake. */
   515		return ptr;
   516	
   517	err_unpin:
   518		__i915_vma_unpin(vma);
   519	err:
   520		return IO_ERR_PTR(err);
   521	}
   522	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35610 bytes --]