From: Matthew Auld <matthew.auld@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v4 3/6] drm/i915/ttm: Drop region reference counting
Date: Thu, 18 Nov 2021 14:19:59 +0000 [thread overview]
Message-ID: <09879562-fe04-e167-bc03-5d21e4fd9744@intel.com> (raw)
In-Reply-To: <20211118130230.154988-4-thomas.hellstrom@linux.intel.com>
On 18/11/2021 13:02, Thomas Hellström wrote:
> There is an interesting refcounting loop:
> struct intel_memory_region has a struct ttm_resource_manager,
> ttm_resource_manager->move may hold a reference to i915_request,
> i915_request may hold a reference to intel_context,
> intel_context may hold a reference to drm_i915_gem_object,
> drm_i915_gem_object may hold a reference to intel_memory_region.
>
> Break this loop by dropping region reference counting.
>
> In addition, Have regions with a manager moving fence make sure
> that all region objects are released before freeing the region.
>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
next prev parent reply other threads:[~2021-11-18 14:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 13:02 [Intel-gfx] [PATCH v4 0/6] drm/i915/ttm: Async migration Thomas Hellström
2021-11-18 13:02 ` [Intel-gfx] [PATCH v4 1/6] drm/i915: Add support for moving fence waiting Thomas Hellström
2021-11-18 14:12 ` Matthew Auld
2021-11-20 9:09 ` kernel test robot
2021-11-18 13:02 ` [Intel-gfx] [PATCH v4 2/6] drm/i915/ttm: Move the i915_gem_obj_copy_ttm() function Thomas Hellström
2021-11-18 13:02 ` [Intel-gfx] [PATCH v4 3/6] drm/i915/ttm: Drop region reference counting Thomas Hellström
2021-11-18 14:19 ` Matthew Auld [this message]
2021-11-18 13:02 ` [Intel-gfx] [PATCH v4 4/6] drm/i915/ttm: Correctly handle waiting for gpu when shrinking Thomas Hellström
2021-11-18 14:30 ` Matthew Auld
2021-11-18 13:02 ` [Intel-gfx] [PATCH v4 5/6] drm/i915/ttm: Implement asynchronous TTM moves Thomas Hellström
2021-11-19 17:18 ` Matthew Auld
2021-11-18 13:02 ` [Intel-gfx] [PATCH v4 6/6] drm/i915/ttm: Update i915_gem_obj_copy_ttm() to be asynchronous Thomas Hellström
2021-11-19 17:22 ` Matthew Auld
2021-11-18 15:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/ttm: Async migration (rev5) Patchwork
2021-11-18 15:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-11-19 5:34 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09879562-fe04-e167-bc03-5d21e4fd9744@intel.com \
--to=matthew.auld@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox