Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] dma_fence_array: Fix PENDING_ERROR leak in dma_fence_array_signaled()
@ 2021-11-29  7:35 Thomas Hellström
  2021-11-29  8:21 ` Christian König
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Thomas Hellström @ 2021-11-29  7:35 UTC (permalink / raw)
  To: intel-gfx, dri-devel
  Cc: linaro-mm-sig, Thomas Hellström, Chris Wilson,
	Christian König

If a dma_fence_array is reported signaled by a call to
dma_fence_is_signaled(), it may leak the PENDING_ERROR status.

Fix this by clearing the PENDING_ERROR status if we return true in
dma_fence_array_signaled().

Fixes: 1f70b8b812f3 ("dma-fence: Propagate errors to dma-fence-array container")
Cc: linaro-mm-sig@lists.linaro.org
Cc: Christian König <ckoenig.leichtzumerken@gmail.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 drivers/dma-buf/dma-fence-array.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/dma-buf/dma-fence-array.c b/drivers/dma-buf/dma-fence-array.c
index d3fbd950be94..3e07f961e2f3 100644
--- a/drivers/dma-buf/dma-fence-array.c
+++ b/drivers/dma-buf/dma-fence-array.c
@@ -104,7 +104,11 @@ static bool dma_fence_array_signaled(struct dma_fence *fence)
 {
 	struct dma_fence_array *array = to_dma_fence_array(fence);
 
-	return atomic_read(&array->num_pending) <= 0;
+	if (atomic_read(&array->num_pending) > 0)
+		return false;
+
+	dma_fence_array_clear_pending_error(array);
+	return true;
 }
 
 static void dma_fence_array_release(struct dma_fence *fence)
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-11-30  8:43 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-29  7:35 [Intel-gfx] [PATCH] dma_fence_array: Fix PENDING_ERROR leak in dma_fence_array_signaled() Thomas Hellström
2021-11-29  8:21 ` Christian König
2021-11-29 12:23   ` Thomas Hellström
2021-11-29 12:33     ` Christian König
2021-11-29 12:46       ` Thomas Hellström
2021-11-29 12:55         ` Christian König
2021-11-29 13:14           ` Joonas Lahtinen
2021-11-30  8:43             ` [Intel-gfx] [Linaro-mm-sig] " Daniel Vetter
2021-11-29  9:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-11-29 11:16 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox