From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v3 3/8] drm/i915/migrate: fix length calculation
Date: Mon, 6 Dec 2021 13:31:35 +0000 [thread overview]
Message-ID: <20211206133140.3166205-4-matthew.auld@intel.com> (raw)
In-Reply-To: <20211206133140.3166205-1-matthew.auld@intel.com>
No need to insert PTEs for the PTE window itself, also foreach expects a
length not an end offset, which could be gigantic here with a second
engine.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Ramalingam C <ramalingam.c@intel.com>
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index 6f2c4388ebb4..0192b61ab541 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -134,7 +134,7 @@ static struct i915_address_space *migrate_vm(struct intel_gt *gt)
goto err_vm;
/* Now allow the GPU to rewrite the PTE via its own ppGTT */
- vm->vm.foreach(&vm->vm, base, base + sz, insert_pte, &d);
+ vm->vm.foreach(&vm->vm, base, d.offset - base, insert_pte, &d);
}
return &vm->vm;
--
2.31.1
next prev parent reply other threads:[~2021-12-06 13:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 13:31 [Intel-gfx] [PATCH v3 0/8] DG2 accelerated migration/clearing support Matthew Auld
2021-12-06 13:31 ` [Intel-gfx] [PATCH v3 1/8] drm/i915/migrate: don't check the scratch page Matthew Auld
2021-12-06 13:31 ` [Intel-gfx] [PATCH v3 2/8] drm/i915/migrate: fix offset calculation Matthew Auld
2021-12-06 13:31 ` Matthew Auld [this message]
2021-12-06 13:31 ` [Intel-gfx] [PATCH v3 4/8] drm/i915/selftests: handle object rounding Matthew Auld
2021-12-06 13:31 ` [Intel-gfx] [PATCH v3 5/8] drm/i915/gtt: allow overriding the pt alignment Matthew Auld
2021-12-13 15:32 ` Ramalingam C
2021-12-06 13:31 ` [Intel-gfx] [PATCH v3 6/8] drm/i915/gtt: add xehpsdv_ppgtt_insert_entry Matthew Auld
2021-12-06 13:31 ` [Intel-gfx] [PATCH v3 7/8] drm/i915/migrate: add acceleration support for DG2 Matthew Auld
2021-12-14 10:56 ` Ramalingam C
2021-12-14 12:32 ` Matthew Auld
2021-12-16 15:01 ` Ramalingam C
2021-12-06 13:31 ` [Intel-gfx] [PATCH v3 8/8] drm/i915/migrate: turn on acceleration " Matthew Auld
2021-12-06 14:05 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for DG2 accelerated migration/clearing support (rev2) Patchwork
2021-12-06 14:49 ` [Intel-gfx] [PATCH v3 0/8] DG2 accelerated migration/clearing support Daniel Stone
2021-12-06 15:13 ` Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206133140.3166205-4-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox