public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/guc: Remove racey GEM_BUG_ON
@ 2021-12-09 18:51 Matthew Brost
  2021-12-09 19:26 ` Daniele Ceraolo Spurio
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Matthew Brost @ 2021-12-09 18:51 UTC (permalink / raw)
  To: intel-gfx, dri-devel

A full GT can race with the last context put resulting in the context
ref count being zero but the destroyed bit not yet being set. Remove
GEM_BUG_ON in scrub_guc_desc_for_outstanding_g2h that asserts the
destroyed bit must be set in ref count is zero.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 9b7b4f4e0d91..0f99bb83293a 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -1040,8 +1040,6 @@ static void scrub_guc_desc_for_outstanding_g2h(struct intel_guc *guc)
 
 		spin_unlock(&ce->guc_state.lock);
 
-		GEM_BUG_ON(!do_put && !destroyed);
-
 		if (pending_enable || destroyed || deregister) {
 			decr_outstanding_submission_g2h(guc);
 			if (deregister)
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-12-11  0:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-09 18:51 [Intel-gfx] [PATCH] drm/i915/guc: Remove racey GEM_BUG_ON Matthew Brost
2021-12-09 19:26 ` Daniele Ceraolo Spurio
2021-12-09 19:57   ` Matthew Brost
2021-12-09 20:04     ` Daniele Ceraolo Spurio
2021-12-10  9:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-12-11  0:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox