public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/guc: Use correct context lock when callig clr_context_registered
@ 2021-12-09 18:48 Matthew Brost
  2021-12-09 19:14 ` Daniele Ceraolo Spurio
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Matthew Brost @ 2021-12-09 18:48 UTC (permalink / raw)
  To: intel-gfx, dri-devel

s/ce/cn/ when grabbing guc_state.lock before calling
clr_context_registered.

Fixes: 0f7976506de61 ("drm/i915/guc: Rework and simplify locking")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Cc: <stable@vger.kernel.org>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 1f9d4fde421f..9b7b4f4e0d91 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -1937,9 +1937,9 @@ static int steal_guc_id(struct intel_guc *guc, struct intel_context *ce)
 		list_del_init(&cn->guc_id.link);
 		ce->guc_id = cn->guc_id;
 
-		spin_lock(&ce->guc_state.lock);
+		spin_lock(&cn->guc_state.lock);
 		clr_context_registered(cn);
-		spin_unlock(&ce->guc_state.lock);
+		spin_unlock(&cn->guc_state.lock);
 
 		set_context_guc_id_invalid(cn);
 
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-12-10 23:03 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-09 18:48 [Intel-gfx] [PATCH] drm/i915/guc: Use correct context lock when callig clr_context_registered Matthew Brost
2021-12-09 19:14 ` Daniele Ceraolo Spurio
2021-12-10  8:41   ` Tvrtko Ursulin
2021-12-10 10:30     ` Jani Nikula
2021-12-10 17:50     ` Matthew Brost
2021-12-10  8:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-12-10 23:03 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox