public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/guc: Don't error on reset of banned context
@ 2022-01-07  0:31 John.C.Harrison
  2022-01-07  0:35 ` John Harrison
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: John.C.Harrison @ 2022-01-07  0:31 UTC (permalink / raw)
  To: Intel-GFX; +Cc: DRI-Devel

From: John Harrison <John.C.Harrison@Intel.com>

There is a race (already documented in the code) whereby a context can
be (re-)queued for submission at the same time as it is being banned
due to a hang and reset. That leads to a hang/reset report from GuC
for a context which i915 thinks is already banned.

While the race is indented to be fixed in a future GuC update, there
is no actual harm beyond the wasted execution time of that new hang
detection period. The context has already been banned for bad
behaviour so a fresh hang is hardly surprising and certainly isn't
going to be losing any work that wouldn't already have been lost if
there was no race.

So don't treat this situation as an error. The error message is seen
by the CI system as something fatal and causes test failures. Instead,
just print an informational so the user at least knows a context reset
occurred (given that the error capture is being skipped).

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 9989d121127d..e8a32a7e7daf 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -3978,6 +3978,10 @@ static void guc_handle_context_reset(struct intel_guc *guc,
 		   !context_blocked(ce))) {
 		capture_error_state(guc, ce);
 		guc_context_replay(ce);
+	} else if (intel_context_is_banned(ce)) {
+		drm_info(&guc_to_gt(guc)->i915->drm,
+			 "Reset notificaion for banned context 0x%04X on %s",
+			 ce->guc_id.id, ce->engine->name);
 	} else {
 		drm_err(&guc_to_gt(guc)->i915->drm,
 			"Invalid GuC engine reset notificaion for 0x%04X on %s: banned = %d, blocked = %d",
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-11 18:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-07  0:31 [Intel-gfx] [PATCH] drm/i915/guc: Don't error on reset of banned context John.C.Harrison
2022-01-07  0:35 ` John Harrison
2022-01-07  1:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-01-07 17:06 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-01-11 18:45 ` [Intel-gfx] [PATCH] " Matthew Brost

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox