From: Kandpal Suraj <suraj.kandpal@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: carsten.haitzler@arm.com, jani.nikula@intel.com,
quic_abhinavk@quicinc.com, laurent.pinchart@ideasonboard.com,
dmitry.baryshkov@linaro.org
Subject: [Intel-gfx] [PATCH 2/6] drm/arm/komeda : change driver to use drm_writeback_connector.base pointer
Date: Wed, 2 Feb 2022 14:24:25 +0530 [thread overview]
Message-ID: <20220202085429.22261-3-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20220202085429.22261-1-suraj.kandpal@intel.com>
Making changes to komeda driver because we had to change
drm_writeback_connector.base into a pointer the reason for which is
expained in the Patch (drm: add writeback pointers to drm_connector).
Signed-off-by: Kandpal Suraj <suraj.kandpal@intel.com>
Reviewed-by: Carsten Haitzler <carsten.haitzler@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +-
drivers/gpu/drm/arm/display/komeda/komeda_kms.h | 3 ++-
.../gpu/drm/arm/display/komeda/komeda_wb_connector.c | 11 ++++++-----
3 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
index 59172acb9738..eb37f41c1790 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
@@ -265,7 +265,7 @@ komeda_crtc_do_flush(struct drm_crtc *crtc,
if (slave && has_bit(slave->id, kcrtc_st->affected_pipes))
komeda_pipeline_update(slave, old->state);
- conn_st = wb_conn ? wb_conn->base.base.state : NULL;
+ conn_st = wb_conn ? wb_conn->base.base->state : NULL;
if (conn_st && conn_st->writeback_job)
drm_writeback_queue_job(&wb_conn->base, conn_st);
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.h b/drivers/gpu/drm/arm/display/komeda/komeda_kms.h
index 456f3c435719..8d83883a1d99 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.h
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.h
@@ -53,6 +53,7 @@ struct komeda_plane_state {
* struct komeda_wb_connector
*/
struct komeda_wb_connector {
+ struct drm_connector conn;
/** @base: &drm_writeback_connector */
struct drm_writeback_connector base;
@@ -136,7 +137,7 @@ struct komeda_kms_dev {
static inline bool is_writeback_only(struct drm_crtc_state *st)
{
struct komeda_wb_connector *wb_conn = to_kcrtc(st->crtc)->wb_conn;
- struct drm_connector *conn = wb_conn ? &wb_conn->base.base : NULL;
+ struct drm_connector *conn = wb_conn ? wb_conn->base.base : NULL;
return conn && (st->connector_mask == BIT(drm_connector_index(conn)));
}
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
index e465cc4879c9..2c3dec59fd88 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
@@ -51,7 +51,7 @@ komeda_wb_encoder_atomic_check(struct drm_encoder *encoder,
return -EINVAL;
}
- wb_layer = to_kconn(to_wb_conn(conn_st->connector))->wb_layer;
+ wb_layer = to_kconn(drm_connector_to_writeback(conn_st->connector))->wb_layer;
/*
* No need for a full modested when the only connector changed is the
@@ -123,7 +123,7 @@ komeda_wb_connector_fill_modes(struct drm_connector *connector,
static void komeda_wb_connector_destroy(struct drm_connector *connector)
{
drm_connector_cleanup(connector);
- kfree(to_kconn(to_wb_conn(connector)));
+ kfree(to_kconn(drm_connector_to_writeback(connector)));
}
static const struct drm_connector_funcs komeda_wb_connector_funcs = {
@@ -155,7 +155,8 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms,
kwb_conn->wb_layer = kcrtc->master->wb_layer;
wb_conn = &kwb_conn->base;
- wb_conn->encoder.possible_crtcs = BIT(drm_crtc_index(&kcrtc->base));
+ wb_conn->base = &kwb_conn->conn;
+ wb_conn->encoder->possible_crtcs = BIT(drm_crtc_index(&kcrtc->base));
formats = komeda_get_layer_fourcc_list(&mdev->fmt_tbl,
kwb_conn->wb_layer->layer_type,
@@ -171,9 +172,9 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms,
return err;
}
- drm_connector_helper_add(&wb_conn->base, &komeda_wb_conn_helper_funcs);
+ drm_connector_helper_add(wb_conn->base, &komeda_wb_conn_helper_funcs);
- info = &kwb_conn->base.base.display_info;
+ info = &kwb_conn->base.base->display_info;
info->bpc = __fls(kcrtc->master->improc->supported_color_depths);
info->color_formats = kcrtc->master->improc->supported_color_formats;
--
2.17.1
next prev parent reply other threads:[~2022-02-02 8:46 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 8:54 [Intel-gfx] [PATCH 0/6] drm writeback connector changes Kandpal Suraj
2022-02-02 8:54 ` [Intel-gfx] [PATCH 1/6] drm: add writeback pointers to drm_connector Kandpal Suraj
2022-02-02 10:28 ` Dmitry Baryshkov
2022-02-03 8:46 ` Kandpal, Suraj
2022-02-02 11:17 ` kernel test robot
2022-02-02 20:07 ` kernel test robot
2022-02-02 8:54 ` Kandpal Suraj [this message]
2022-02-02 8:54 ` [Intel-gfx] [PATCH 3/6] drm/vkms: change vkms driver to use drm_writeback_connector.base pointer Kandpal Suraj
2022-02-02 8:54 ` [Intel-gfx] [PATCH 4/6] drm/vc4: vc4 driver changes to accommodate changes done in drm_writeback_connector structure Kandpal Suraj
2022-02-02 8:54 ` [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes Kandpal Suraj
2022-02-02 12:42 ` Laurent Pinchart
2022-02-02 13:15 ` Jani Nikula
2022-02-02 13:26 ` Laurent Pinchart
2022-02-02 15:38 ` Jani Nikula
2022-02-26 18:27 ` Rob Clark
2022-02-28 8:03 ` Laurent Pinchart
2022-02-28 12:09 ` Jani Nikula
2022-02-28 12:28 ` Laurent Pinchart
2022-02-28 13:42 ` Laurent Pinchart
2022-03-02 18:28 ` Abhinav Kumar
2022-03-02 18:31 ` Laurent Pinchart
2022-03-03 17:32 ` Abhinav Kumar
2022-03-04 9:56 ` Kandpal, Suraj
2022-03-04 10:39 ` Dmitry Baryshkov
2022-03-04 10:47 ` Kandpal, Suraj
2022-03-04 11:25 ` Dmitry Baryshkov
2022-03-04 14:16 ` Kandpal, Suraj
2022-03-04 20:47 ` Abhinav Kumar
2022-03-08 14:30 ` Kandpal, Suraj
2022-03-08 19:44 ` Abhinav Kumar
2022-02-06 23:32 ` Dmitry Baryshkov
2022-02-07 7:20 ` Abhinav Kumar
2022-02-10 1:40 ` Abhinav Kumar
2022-02-10 4:58 ` Laurent Pinchart
2022-02-22 3:32 ` Dmitry Baryshkov
2022-02-22 7:34 ` Laurent Pinchart
2022-02-24 0:27 ` Abhinav Kumar
2022-02-02 13:34 ` Ville Syrjälä
2022-02-02 13:40 ` Dmitry Baryshkov
2022-02-02 15:57 ` Jani Nikula
2022-02-23 6:17 ` Kandpal, Suraj
2022-02-25 23:26 ` Abhinav Kumar
2022-02-26 5:10 ` Kandpal, Suraj
2022-02-28 8:00 ` Laurent Pinchart
2022-02-28 8:07 ` Dmitry Baryshkov
2022-02-28 8:28 ` Laurent Pinchart
2022-02-02 8:54 ` [Intel-gfx] [PATCH 6/6] drm/arm: changes to malidp " Kandpal Suraj
2022-02-02 10:01 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm writeback connector changes Patchwork
2022-02-02 10:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-02 12:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220202085429.22261-3-suraj.kandpal@intel.com \
--to=suraj.kandpal@intel.com \
--cc=carsten.haitzler@arm.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=quic_abhinavk@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox