From: Kandpal Suraj <suraj.kandpal@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: carsten.haitzler@arm.com, jani.nikula@intel.com,
quic_abhinavk@quicinc.com, laurent.pinchart@ideasonboard.com,
dmitry.baryshkov@linaro.org
Subject: [Intel-gfx] [PATCH 6/6] drm/arm: changes to malidp driver resulting from drm_writeback_connector structure changes
Date: Wed, 2 Feb 2022 14:24:29 +0530 [thread overview]
Message-ID: <20220202085429.22261-7-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20220202085429.22261-1-suraj.kandpal@intel.com>
Changing malidp driver to accomadate the change of
drm_writeback_connector.base and drm_writeback_connector.encoder
to a pointer the reason for which is explained in the
Patch(drm: add writeback pointers to drm_connector).
Signed-off-by: Kandpal Suraj <suraj.kandpal@intel.com>
---
drivers/gpu/drm/arm/malidp_crtc.c | 2 +-
drivers/gpu/drm/arm/malidp_drv.h | 2 ++
drivers/gpu/drm/arm/malidp_mw.c | 12 ++++++++----
3 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c
index 494075ddbef6..294aacd4beef 100644
--- a/drivers/gpu/drm/arm/malidp_crtc.c
+++ b/drivers/gpu/drm/arm/malidp_crtc.c
@@ -424,7 +424,7 @@ static int malidp_crtc_atomic_check(struct drm_crtc *crtc,
u32 new_mask = crtc_state->connector_mask;
if ((old_mask ^ new_mask) ==
- (1 << drm_connector_index(&malidp->mw_connector.base)))
+ (1 << drm_connector_index(malidp->mw_connector.base)))
crtc_state->connectors_changed = false;
}
diff --git a/drivers/gpu/drm/arm/malidp_drv.h b/drivers/gpu/drm/arm/malidp_drv.h
index cdfddfabf2d1..971810a685f1 100644
--- a/drivers/gpu/drm/arm/malidp_drv.h
+++ b/drivers/gpu/drm/arm/malidp_drv.h
@@ -31,6 +31,8 @@ struct malidp_error_stats {
struct malidp_drm {
struct malidp_hw_device *dev;
struct drm_crtc crtc;
+ struct drm_connector connector;
+ struct drm_encoder encoder;
struct drm_writeback_connector mw_connector;
wait_queue_head_t wq;
struct drm_pending_vblank_event *event;
diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c
index f5847a79dd7e..9bd2e400cd3d 100644
--- a/drivers/gpu/drm/arm/malidp_mw.c
+++ b/drivers/gpu/drm/arm/malidp_mw.c
@@ -206,21 +206,25 @@ static u32 *get_writeback_formats(struct malidp_drm *malidp, int *n_formats)
int malidp_mw_connector_init(struct drm_device *drm)
{
struct malidp_drm *malidp = drm->dev_private;
+ struct drm_writeback_connector *wb_conn;
u32 *formats;
int ret, n_formats;
if (!malidp->dev->hw->enable_memwrite)
return 0;
- malidp->mw_connector.encoder.possible_crtcs = 1 << drm_crtc_index(&malidp->crtc);
- drm_connector_helper_add(&malidp->mw_connector.base,
+ wb_conn = &malidp->mw_connector;
+ wb_conn->base = &malidp->connector;
+ wb_conn->encoder = &malidp->encoder;
+ malidp->mw_connector.encoder->possible_crtcs = 1 << drm_crtc_index(&malidp->crtc);
+ drm_connector_helper_add(wb_conn->base,
&malidp_mw_connector_helper_funcs);
formats = get_writeback_formats(malidp, &n_formats);
if (!formats)
return -ENOMEM;
- ret = drm_writeback_connector_init(drm, &malidp->mw_connector,
+ ret = drm_writeback_connector_init(drm, wb_conn,
&malidp_mw_connector_funcs,
&malidp_mw_encoder_helper_funcs,
formats, n_formats);
@@ -236,7 +240,7 @@ void malidp_mw_atomic_commit(struct drm_device *drm,
{
struct malidp_drm *malidp = drm->dev_private;
struct drm_writeback_connector *mw_conn = &malidp->mw_connector;
- struct drm_connector_state *conn_state = mw_conn->base.state;
+ struct drm_connector_state *conn_state = mw_conn->base->state;
struct malidp_hw_device *hwdev = malidp->dev;
struct malidp_mw_connector_state *mw_state;
--
2.17.1
next prev parent reply other threads:[~2022-02-02 8:46 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 8:54 [Intel-gfx] [PATCH 0/6] drm writeback connector changes Kandpal Suraj
2022-02-02 8:54 ` [Intel-gfx] [PATCH 1/6] drm: add writeback pointers to drm_connector Kandpal Suraj
2022-02-02 10:28 ` Dmitry Baryshkov
2022-02-03 8:46 ` Kandpal, Suraj
2022-02-02 11:17 ` kernel test robot
2022-02-02 20:07 ` kernel test robot
2022-02-02 8:54 ` [Intel-gfx] [PATCH 2/6] drm/arm/komeda : change driver to use drm_writeback_connector.base pointer Kandpal Suraj
2022-02-02 8:54 ` [Intel-gfx] [PATCH 3/6] drm/vkms: change vkms " Kandpal Suraj
2022-02-02 8:54 ` [Intel-gfx] [PATCH 4/6] drm/vc4: vc4 driver changes to accommodate changes done in drm_writeback_connector structure Kandpal Suraj
2022-02-02 8:54 ` [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes Kandpal Suraj
2022-02-02 12:42 ` Laurent Pinchart
2022-02-02 13:15 ` Jani Nikula
2022-02-02 13:26 ` Laurent Pinchart
2022-02-02 15:38 ` Jani Nikula
2022-02-26 18:27 ` Rob Clark
2022-02-28 8:03 ` Laurent Pinchart
2022-02-28 12:09 ` Jani Nikula
2022-02-28 12:28 ` Laurent Pinchart
2022-02-28 13:42 ` Laurent Pinchart
2022-03-02 18:28 ` Abhinav Kumar
2022-03-02 18:31 ` Laurent Pinchart
2022-03-03 17:32 ` Abhinav Kumar
2022-03-04 9:56 ` Kandpal, Suraj
2022-03-04 10:39 ` Dmitry Baryshkov
2022-03-04 10:47 ` Kandpal, Suraj
2022-03-04 11:25 ` Dmitry Baryshkov
2022-03-04 14:16 ` Kandpal, Suraj
2022-03-04 20:47 ` Abhinav Kumar
2022-03-08 14:30 ` Kandpal, Suraj
2022-03-08 19:44 ` Abhinav Kumar
2022-02-06 23:32 ` Dmitry Baryshkov
2022-02-07 7:20 ` Abhinav Kumar
2022-02-10 1:40 ` Abhinav Kumar
2022-02-10 4:58 ` Laurent Pinchart
2022-02-22 3:32 ` Dmitry Baryshkov
2022-02-22 7:34 ` Laurent Pinchart
2022-02-24 0:27 ` Abhinav Kumar
2022-02-02 13:34 ` Ville Syrjälä
2022-02-02 13:40 ` Dmitry Baryshkov
2022-02-02 15:57 ` Jani Nikula
2022-02-23 6:17 ` Kandpal, Suraj
2022-02-25 23:26 ` Abhinav Kumar
2022-02-26 5:10 ` Kandpal, Suraj
2022-02-28 8:00 ` Laurent Pinchart
2022-02-28 8:07 ` Dmitry Baryshkov
2022-02-28 8:28 ` Laurent Pinchart
2022-02-02 8:54 ` Kandpal Suraj [this message]
2022-02-02 10:01 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm writeback connector changes Patchwork
2022-02-02 10:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-02 12:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220202085429.22261-7-suraj.kandpal@intel.com \
--to=suraj.kandpal@intel.com \
--cc=carsten.haitzler@arm.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=quic_abhinavk@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox