Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, Sam Ravnborg <sam@ravnborg.org>
Subject: [Intel-gfx] [PATCH 20/22] drm/panel: Use drm_mode_duplicate()
Date: Fri, 18 Feb 2022 12:04:01 +0200	[thread overview]
Message-ID: <20220218100403.7028-21-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20220218100403.7028-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Replace the hand rolled drm_mode_duplicate() with the
real thing.

@is_dup@
@@
drm_mode_duplicate(...)
{ ... }

@depends on !is_dup@
expression dev, oldmode;
identifier newmode;
@@
- newmode = drm_mode_create(dev);
+ newmode = drm_mode_duplicate(dev, oldmode);
  ...
- drm_mode_copy(newmode, oldmode);

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/panel/panel-truly-nt35597.c    | 3 +--
 drivers/gpu/drm/panel/panel-visionox-rm69299.c | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c
index b24b92d93ea5..9ca5c7ff41d6 100644
--- a/drivers/gpu/drm/panel/panel-truly-nt35597.c
+++ b/drivers/gpu/drm/panel/panel-truly-nt35597.c
@@ -446,7 +446,7 @@ static int truly_nt35597_get_modes(struct drm_panel *panel,
 	const struct nt35597_config *config;
 
 	config = ctx->config;
-	mode = drm_mode_create(connector->dev);
+	mode = drm_mode_duplicate(connector->dev, config->dm);
 	if (!mode) {
 		dev_err(ctx->dev, "failed to create a new display mode\n");
 		return 0;
@@ -454,7 +454,6 @@ static int truly_nt35597_get_modes(struct drm_panel *panel,
 
 	connector->display_info.width_mm = config->width_mm;
 	connector->display_info.height_mm = config->height_mm;
-	drm_mode_copy(mode, config->dm);
 	mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
 	drm_mode_probed_add(connector, mode);
 
diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
index eb43503ec97b..db2443ac81d3 100644
--- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c
+++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
@@ -168,7 +168,8 @@ static int visionox_rm69299_get_modes(struct drm_panel *panel,
 	struct visionox_rm69299 *ctx = panel_to_ctx(panel);
 	struct drm_display_mode *mode;
 
-	mode = drm_mode_create(connector->dev);
+	mode = drm_mode_duplicate(connector->dev,
+				  &visionox_rm69299_1080x2248_60hz);
 	if (!mode) {
 		dev_err(ctx->panel.dev, "failed to create a new display mode\n");
 		return 0;
@@ -176,7 +177,6 @@ static int visionox_rm69299_get_modes(struct drm_panel *panel,
 
 	connector->display_info.width_mm = 74;
 	connector->display_info.height_mm = 131;
-	drm_mode_copy(mode, &visionox_rm69299_1080x2248_60hz);
 	mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
 	drm_mode_probed_add(connector, mode);
 
-- 
2.34.1


  parent reply	other threads:[~2022-02-18 10:05 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18 10:03 [Intel-gfx] [PATCH 00/22] drm: Review of mode copies Ville Syrjala
2022-02-18 10:03 ` [Intel-gfx] [PATCH 01/22] drm: Add drm_mode_init() Ville Syrjala
2022-02-18 11:22   ` Andrzej Hajda
2022-02-18 11:56     ` Ville Syrjälä
2022-02-18 12:23       ` Andrzej Hajda
2022-02-18 16:34   ` Harry Wentland
2022-02-18 10:03 ` [Intel-gfx] [PATCH 02/22] drm/amdgpu: Remove pointless on stack mode copies Ville Syrjala
2022-02-18 16:28   ` Harry Wentland
2022-03-15 15:57     ` Alex Deucher
2022-02-18 10:03 ` [Intel-gfx] [PATCH 03/22] drm/amdgpu: Use drm_mode_init() for on-stack modes Ville Syrjala
2022-02-18 16:30   ` Harry Wentland
2022-02-18 10:03 ` [Intel-gfx] [PATCH 04/22] drm/amdgpu: Use drm_mode_copy() Ville Syrjala
2022-02-18 16:32   ` Harry Wentland
2022-03-15 18:50     ` Alex Deucher
2022-02-18 10:03 ` [Intel-gfx] [PATCH 05/22] drm/radeon: " Ville Syrjala
2022-03-15 18:49   ` Alex Deucher
2022-02-18 10:03 ` [Intel-gfx] [PATCH 06/22] drm/bridge: " Ville Syrjala
2022-02-18 11:25   ` Andrzej Hajda
2022-02-18 17:47   ` Laurent Pinchart
2022-02-18 10:03 ` [Intel-gfx] [PATCH 07/22] drm/gma500: " Ville Syrjala
2022-03-16 13:16   ` Patrik Jakobsson
2022-02-18 10:03 ` [Intel-gfx] [PATCH 08/22] drm/hisilicon: Use drm_mode_init() for on-stack modes Ville Syrjala
2022-02-18 10:03 ` [Intel-gfx] [PATCH 09/22] drm/imx: Use drm_mode_duplicate() Ville Syrjala
2022-02-18 11:42   ` Philipp Zabel
2022-02-18 10:03 ` [Intel-gfx] [PATCH 10/22] drm/msm: Nuke weird on stack mode copy Ville Syrjala
2022-03-23 10:19   ` Dmitry Baryshkov
2022-02-18 10:03 ` [Intel-gfx] [PATCH 11/22] drm/msm: Use drm_mode_init() for on-stack modes Ville Syrjala
2022-03-23 10:11   ` Dmitry Baryshkov
2022-03-23 20:04   ` Abhinav Kumar
2022-02-18 10:03 ` [Intel-gfx] [PATCH 12/22] drm/msm: Use drm_mode_copy() Ville Syrjala
2022-03-23 10:12   ` Dmitry Baryshkov
2022-03-23 20:09   ` Abhinav Kumar
2022-02-18 10:03 ` [Intel-gfx] [PATCH 13/22] drm/mtk: Use drm_mode_init() for on-stack modes Ville Syrjala
2022-02-18 10:03 ` [Intel-gfx] [PATCH 14/22] drm/rockchip: Use drm_mode_copy() Ville Syrjala
2022-02-18 10:03 ` [Intel-gfx] [PATCH 15/22] drm/sti: " Ville Syrjala
2022-02-18 10:03 ` [Intel-gfx] [PATCH 16/22] drm/tilcdc: " Ville Syrjala
2022-03-15  4:54   ` Tomi Valkeinen
2022-02-18 10:03 ` [Intel-gfx] [PATCH 17/22] drm/vc4: " Ville Syrjala
2022-02-21 10:13   ` [Intel-gfx] (subset) " Maxime Ripard
2022-02-18 10:03 ` [Intel-gfx] [PATCH 18/22] drm/i915: Use drm_mode_init() for on-stack modes Ville Syrjala
2022-03-16  8:00   ` Jani Nikula
2022-03-21 18:57     ` Ville Syrjälä
2022-03-21 20:48       ` Julia Lawall
2022-02-18 10:04 ` [Intel-gfx] [PATCH 19/22] drm/i915: Use drm_mode_copy() Ville Syrjala
2022-03-16  8:04   ` Jani Nikula
2022-02-18 10:04 ` Ville Syrjala [this message]
2022-02-18 11:51   ` [Intel-gfx] [PATCH 20/22] drm/panel: Use drm_mode_duplicate() Sam Ravnborg
2022-02-18 10:04 ` [Intel-gfx] [PATCH 21/22] drm: Use drm_mode_init() for on-stack modes Ville Syrjala
2022-03-22 11:10   ` Andrzej Hajda
2022-02-18 10:04 ` [Intel-gfx] [PATCH 22/22] drm: Use drm_mode_copy() Ville Syrjala
2022-03-22 11:19   ` Andrzej Hajda
2022-02-18 13:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Review of mode copies Patchwork
2022-02-18 14:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-19  5:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-14 22:11 ` [Intel-gfx] [PATCH 00/22] " Ville Syrjälä
2022-03-15 18:52   ` Alex Deucher
2022-03-21 22:37     ` Ville Syrjälä
2022-03-23 10:39       ` Dmitry Baryshkov
2022-03-23 15:10         ` Ville Syrjälä
2022-03-23 20:50         ` Abhinav Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220218100403.7028-21-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox