From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: Leo Li <sunpeng.li@amd.com>,
intel-gfx@lists.freedesktop.org,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
amd-gfx@lists.freedesktop.org,
Nikola Cornij <nikola.cornij@amd.com>,
Aurabindo Pillai <aurabindo.pillai@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Harry Wentland <harry.wentland@amd.com>
Subject: [Intel-gfx] [PATCH 02/22] drm/amdgpu: Remove pointless on stack mode copies
Date: Fri, 18 Feb 2022 12:03:43 +0200 [thread overview]
Message-ID: <20220218100403.7028-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20220218100403.7028-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
These on stack copies of the modes appear to be pointless.
Just look at the originals directly.
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: Nikola Cornij <nikola.cornij@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 32 +++++++++----------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 21dba337dab0..65aab0d086b6 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -10139,27 +10139,27 @@ static bool
is_timing_unchanged_for_freesync(struct drm_crtc_state *old_crtc_state,
struct drm_crtc_state *new_crtc_state)
{
- struct drm_display_mode old_mode, new_mode;
+ const struct drm_display_mode *old_mode, *new_mode;
if (!old_crtc_state || !new_crtc_state)
return false;
- old_mode = old_crtc_state->mode;
- new_mode = new_crtc_state->mode;
+ old_mode = &old_crtc_state->mode;
+ new_mode = &new_crtc_state->mode;
- if (old_mode.clock == new_mode.clock &&
- old_mode.hdisplay == new_mode.hdisplay &&
- old_mode.vdisplay == new_mode.vdisplay &&
- old_mode.htotal == new_mode.htotal &&
- old_mode.vtotal != new_mode.vtotal &&
- old_mode.hsync_start == new_mode.hsync_start &&
- old_mode.vsync_start != new_mode.vsync_start &&
- old_mode.hsync_end == new_mode.hsync_end &&
- old_mode.vsync_end != new_mode.vsync_end &&
- old_mode.hskew == new_mode.hskew &&
- old_mode.vscan == new_mode.vscan &&
- (old_mode.vsync_end - old_mode.vsync_start) ==
- (new_mode.vsync_end - new_mode.vsync_start))
+ if (old_mode->clock == new_mode->clock &&
+ old_mode->hdisplay == new_mode->hdisplay &&
+ old_mode->vdisplay == new_mode->vdisplay &&
+ old_mode->htotal == new_mode->htotal &&
+ old_mode->vtotal != new_mode->vtotal &&
+ old_mode->hsync_start == new_mode->hsync_start &&
+ old_mode->vsync_start != new_mode->vsync_start &&
+ old_mode->hsync_end == new_mode->hsync_end &&
+ old_mode->vsync_end != new_mode->vsync_end &&
+ old_mode->hskew == new_mode->hskew &&
+ old_mode->vscan == new_mode->vscan &&
+ (old_mode->vsync_end - old_mode->vsync_start) ==
+ (new_mode->vsync_end - new_mode->vsync_start))
return true;
return false;
--
2.34.1
next prev parent reply other threads:[~2022-02-18 10:04 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 10:03 [Intel-gfx] [PATCH 00/22] drm: Review of mode copies Ville Syrjala
2022-02-18 10:03 ` [Intel-gfx] [PATCH 01/22] drm: Add drm_mode_init() Ville Syrjala
2022-02-18 11:22 ` Andrzej Hajda
2022-02-18 11:56 ` Ville Syrjälä
2022-02-18 12:23 ` Andrzej Hajda
2022-02-18 16:34 ` Harry Wentland
2022-02-18 10:03 ` Ville Syrjala [this message]
2022-02-18 16:28 ` [Intel-gfx] [PATCH 02/22] drm/amdgpu: Remove pointless on stack mode copies Harry Wentland
2022-03-15 15:57 ` Alex Deucher
2022-02-18 10:03 ` [Intel-gfx] [PATCH 03/22] drm/amdgpu: Use drm_mode_init() for on-stack modes Ville Syrjala
2022-02-18 16:30 ` Harry Wentland
2022-02-18 10:03 ` [Intel-gfx] [PATCH 04/22] drm/amdgpu: Use drm_mode_copy() Ville Syrjala
2022-02-18 16:32 ` Harry Wentland
2022-03-15 18:50 ` Alex Deucher
2022-02-18 10:03 ` [Intel-gfx] [PATCH 05/22] drm/radeon: " Ville Syrjala
2022-03-15 18:49 ` Alex Deucher
2022-02-18 10:03 ` [Intel-gfx] [PATCH 06/22] drm/bridge: " Ville Syrjala
2022-02-18 11:25 ` Andrzej Hajda
2022-02-18 17:47 ` Laurent Pinchart
2022-02-18 10:03 ` [Intel-gfx] [PATCH 07/22] drm/gma500: " Ville Syrjala
2022-03-16 13:16 ` Patrik Jakobsson
2022-02-18 10:03 ` [Intel-gfx] [PATCH 08/22] drm/hisilicon: Use drm_mode_init() for on-stack modes Ville Syrjala
2022-02-18 10:03 ` [Intel-gfx] [PATCH 09/22] drm/imx: Use drm_mode_duplicate() Ville Syrjala
2022-02-18 11:42 ` Philipp Zabel
2022-02-18 10:03 ` [Intel-gfx] [PATCH 10/22] drm/msm: Nuke weird on stack mode copy Ville Syrjala
2022-03-23 10:19 ` Dmitry Baryshkov
2022-02-18 10:03 ` [Intel-gfx] [PATCH 11/22] drm/msm: Use drm_mode_init() for on-stack modes Ville Syrjala
2022-03-23 10:11 ` Dmitry Baryshkov
2022-03-23 20:04 ` Abhinav Kumar
2022-02-18 10:03 ` [Intel-gfx] [PATCH 12/22] drm/msm: Use drm_mode_copy() Ville Syrjala
2022-03-23 10:12 ` Dmitry Baryshkov
2022-03-23 20:09 ` Abhinav Kumar
2022-02-18 10:03 ` [Intel-gfx] [PATCH 13/22] drm/mtk: Use drm_mode_init() for on-stack modes Ville Syrjala
2022-02-18 10:03 ` [Intel-gfx] [PATCH 14/22] drm/rockchip: Use drm_mode_copy() Ville Syrjala
2022-02-18 10:03 ` [Intel-gfx] [PATCH 15/22] drm/sti: " Ville Syrjala
2022-02-18 10:03 ` [Intel-gfx] [PATCH 16/22] drm/tilcdc: " Ville Syrjala
2022-03-15 4:54 ` Tomi Valkeinen
2022-02-18 10:03 ` [Intel-gfx] [PATCH 17/22] drm/vc4: " Ville Syrjala
2022-02-21 10:13 ` [Intel-gfx] (subset) " Maxime Ripard
2022-02-18 10:03 ` [Intel-gfx] [PATCH 18/22] drm/i915: Use drm_mode_init() for on-stack modes Ville Syrjala
2022-03-16 8:00 ` Jani Nikula
2022-03-21 18:57 ` Ville Syrjälä
2022-03-21 20:48 ` Julia Lawall
2022-02-18 10:04 ` [Intel-gfx] [PATCH 19/22] drm/i915: Use drm_mode_copy() Ville Syrjala
2022-03-16 8:04 ` Jani Nikula
2022-02-18 10:04 ` [Intel-gfx] [PATCH 20/22] drm/panel: Use drm_mode_duplicate() Ville Syrjala
2022-02-18 11:51 ` Sam Ravnborg
2022-02-18 10:04 ` [Intel-gfx] [PATCH 21/22] drm: Use drm_mode_init() for on-stack modes Ville Syrjala
2022-03-22 11:10 ` Andrzej Hajda
2022-02-18 10:04 ` [Intel-gfx] [PATCH 22/22] drm: Use drm_mode_copy() Ville Syrjala
2022-03-22 11:19 ` Andrzej Hajda
2022-02-18 13:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Review of mode copies Patchwork
2022-02-18 14:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-19 5:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-14 22:11 ` [Intel-gfx] [PATCH 00/22] " Ville Syrjälä
2022-03-15 18:52 ` Alex Deucher
2022-03-21 22:37 ` Ville Syrjälä
2022-03-23 10:39 ` Dmitry Baryshkov
2022-03-23 15:10 ` Ville Syrjälä
2022-03-23 20:50 ` Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218100403.7028-3-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nikola.cornij@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox