From: Michael Cheng <michael.cheng@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: michael.cheng@intel.com, lucas.demarchi@intel.com,
dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v11 4/6] drm/i915/gt: Re-work reset_csb
Date: Tue, 22 Feb 2022 21:58:58 -0800 [thread overview]
Message-ID: <20220223055900.415627-5-michael.cheng@intel.com> (raw)
In-Reply-To: <20220223055900.415627-1-michael.cheng@intel.com>
Use drm_clflush_virt_range instead of directly invoking clflush. This
will prevent compiler errors when building for non-x86 architectures.
v2(Michael Cheng): Remove extra clflush
v3(Michael Cheng): Remove memory barrier since drm_clflush_virt_range
takes care of it.
v4(Michael Cheng): Get the size of value and not the size of the pointer
when passing in execlists->csb_write. Thanks to Matt
Roper for pointing this out.
Signed-off-by: Michael Cheng <michael.cheng@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
index e5e73a1b2e4e..89aef3ce53f0 100644
--- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
@@ -2945,9 +2945,8 @@ reset_csb(struct intel_engine_cs *engine, struct i915_request **inactive)
{
struct intel_engine_execlists * const execlists = &engine->execlists;
- mb(); /* paranoia: read the CSB pointers from after the reset */
- clflush(execlists->csb_write);
- mb();
+ drm_clflush_virt_range(execlists->csb_write,
+ sizeof(execlists->csb_write[0]));
inactive = process_csb(engine, inactive); /* drain preemption events */
--
2.25.1
next prev parent reply other threads:[~2022-02-23 5:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 5:58 [Intel-gfx] [PATCH v11 0/6] Use drm_clflush* instead of clflush Michael Cheng
2022-02-23 5:58 ` [Intel-gfx] [PATCH v11 1/6] drm: Add arch arm64 for drm_clflush_virt_range Michael Cheng
2022-02-23 9:56 ` kernel test robot
2022-02-23 12:46 ` kernel test robot
2022-02-23 17:43 ` kernel test robot
2022-02-23 5:58 ` [Intel-gfx] [PATCH v11 2/6] drm/i915/gt: Re-work intel_write_status_page Michael Cheng
2022-02-23 5:58 ` [Intel-gfx] [PATCH v11 3/6] drm/i915/gt: Drop invalidate_csb_entries Michael Cheng
2022-02-23 5:58 ` Michael Cheng [this message]
2022-02-23 5:58 ` [Intel-gfx] [PATCH v11 5/6] drm/i915/: Re-work clflush_write32 Michael Cheng
2022-02-23 5:59 ` [Intel-gfx] [PATCH v11 6/6] drm/i915/gt: replace cache_clflush_range Michael Cheng
2022-02-23 8:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Use drm_clflush* instead of clflush (rev10) Patchwork
2022-02-23 8:10 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-23 8:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-24 4:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Use drm_clflush* instead of clflush (rev11) Patchwork
2022-02-24 4:05 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-24 4:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-24 16:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223055900.415627-5-michael.cheng@intel.com \
--to=michael.cheng@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox