Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915: Fix cursor coordinates on bigjoiner slave
@ 2022-02-15  6:23 Ville Syrjala
  2022-02-16  6:37 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Ville Syrjala @ 2022-02-15  6:23 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Adjust the cursor dst coordinates appripriately when it's on
the bigjoiner slave pipe. intel_atomic_plane_check_clipping()
already did this but with the cursor we discard those results
(apart from uapi.visible and error checks) since the hardware
will be doing the clipping for us.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_cursor.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/drivers/gpu/drm/i915/display/intel_cursor.c
index 2ade8fdd9bdd..5b600679674f 100644
--- a/drivers/gpu/drm/i915/display/intel_cursor.c
+++ b/drivers/gpu/drm/i915/display/intel_cursor.c
@@ -152,6 +152,9 @@ static int intel_check_cursor(struct intel_crtc_state *crtc_state,
 	/* Use the unclipped src/dst rectangles, which we program to hw */
 	plane_state->uapi.src = src;
 	plane_state->uapi.dst = dst;
+	if (crtc_state->bigjoiner_slave)
+		drm_rect_translate(&plane_state->uapi.dst,
+				   -crtc_state->pipe_src_w, 0);
 
 	ret = intel_cursor_check_surface(plane_state);
 	if (ret)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-02-24 19:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-15  6:23 [Intel-gfx] [PATCH] drm/i915: Fix cursor coordinates on bigjoiner slave Ville Syrjala
2022-02-16  6:37 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2022-02-17  8:22 ` [Intel-gfx] [PATCH] " Lee Shawn C
2022-02-17 19:14 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Fix cursor coordinates on bigjoiner slave (rev2) Patchwork
2022-02-23 14:00 ` [Intel-gfx] [v2] drm/i915: Fix cursor coordinates on bigjoiner slave Lee Shawn C
2022-02-24  7:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix cursor coordinates on bigjoiner slave (rev3) Patchwork
2022-02-24 19:40 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox