Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [CI] HAX: drm/i915: Add softdep
@ 2022-04-15 21:56 Lucas De Marchi
  2022-04-15 22:23 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Lucas De Marchi @ 2022-04-15 21:56 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

CI is having several issues due to unbinding i915 while the sound driver
is still doing something. It's particularly harmful when it's not idle
and we attempt to remove i915.

We still need to fix the snd driver so we can more reliably remove i915,
but this can't block other i915 tests. By adding a post softdep we make sure
that on module removal, kmod first removes snd_hda_intel, and only after
that removes i915.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---

From some local tests I had success when making sure sound driver got
unloaded before unloading i915. Submitting for CI and if nothing
explodes we may consider it for topic/core-for-CI.

 drivers/gpu/drm/i915/i915_module.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_module.c b/drivers/gpu/drm/i915/i915_module.c
index 65acd7bf75d0..4e3725a9c375 100644
--- a/drivers/gpu/drm/i915/i915_module.c
+++ b/drivers/gpu/drm/i915/i915_module.c
@@ -123,3 +123,5 @@ MODULE_AUTHOR("Intel Corporation");
 
 MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL and additional rights");
+
+MODULE_SOFTDEP("post: snd_hda_intel");
-- 
2.35.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-04-16  0:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-15 21:56 [Intel-gfx] [CI] HAX: drm/i915: Add softdep Lucas De Marchi
2022-04-15 22:23 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-04-15 22:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-04-16  0:31 ` [Intel-gfx] [CI] " Lucas De Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox