* [Intel-gfx] [PATCH 1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON()
@ 2022-05-04 18:37 Jani Nikula
2022-05-04 18:37 ` [Intel-gfx] [PATCH 2/3] drm/i915: remove single-use GEM_DEBUG_EXEC() Jani Nikula
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Jani Nikula @ 2022-05-04 18:37 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
There are already too many choices here, take away the unused ones.
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_gem.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h
index d0752e5553db..b7b257f54d2e 100644
--- a/drivers/gpu/drm/i915/i915_gem.h
+++ b/drivers/gpu/drm/i915/i915_gem.h
@@ -54,9 +54,7 @@ struct drm_i915_private;
} while(0)
#define GEM_WARN_ON(expr) WARN_ON(expr)
-#define GEM_DEBUG_DECL(var) var
#define GEM_DEBUG_EXEC(expr) expr
-#define GEM_DEBUG_BUG_ON(expr) GEM_BUG_ON(expr)
#define GEM_DEBUG_WARN_ON(expr) GEM_WARN_ON(expr)
#else
@@ -66,9 +64,7 @@ struct drm_i915_private;
#define GEM_BUG_ON(expr) BUILD_BUG_ON_INVALID(expr)
#define GEM_WARN_ON(expr) ({ unlikely(!!(expr)); })
-#define GEM_DEBUG_DECL(var)
#define GEM_DEBUG_EXEC(expr) do { } while (0)
-#define GEM_DEBUG_BUG_ON(expr)
#define GEM_DEBUG_WARN_ON(expr) ({ BUILD_BUG_ON_INVALID(expr); 0; })
#endif
--
2.30.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Intel-gfx] [PATCH 2/3] drm/i915: remove single-use GEM_DEBUG_EXEC() 2022-05-04 18:37 [Intel-gfx] [PATCH 1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() Jani Nikula @ 2022-05-04 18:37 ` Jani Nikula 2022-05-05 11:04 ` Tvrtko Ursulin 2022-05-04 18:37 ` [Intel-gfx] [PATCH 3/3] drm/i915/display: stop using BUG() Jani Nikula ` (3 subsequent siblings) 4 siblings, 1 reply; 10+ messages in thread From: Jani Nikula @ 2022-05-04 18:37 UTC (permalink / raw) To: intel-gfx; +Cc: jani.nikula Reduce the magic of what's going on in GEM_DEBUG_EXEC() by expanding it inline and being explicit about it. It's as single use case anyway, so the macro feels overkill. Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/gt/intel_ring.c | 3 ++- drivers/gpu/drm/i915/i915_gem.h | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c index 40ffcb94e379..15ec64d881c4 100644 --- a/drivers/gpu/drm/i915/gt/intel_ring.c +++ b/drivers/gpu/drm/i915/gt/intel_ring.c @@ -299,7 +299,8 @@ u32 *intel_ring_begin(struct i915_request *rq, unsigned int num_dwords) GEM_BUG_ON(ring->emit > ring->size - bytes); GEM_BUG_ON(ring->space < bytes); cs = ring->vaddr + ring->emit; - GEM_DEBUG_EXEC(memset32(cs, POISON_INUSE, bytes / sizeof(*cs))); + if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) + memset32(cs, POISON_INUSE, bytes / sizeof(*cs)); ring->emit += bytes; ring->space -= bytes; diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h index b7b257f54d2e..a2be323a4be5 100644 --- a/drivers/gpu/drm/i915/i915_gem.h +++ b/drivers/gpu/drm/i915/i915_gem.h @@ -54,7 +54,6 @@ struct drm_i915_private; } while(0) #define GEM_WARN_ON(expr) WARN_ON(expr) -#define GEM_DEBUG_EXEC(expr) expr #define GEM_DEBUG_WARN_ON(expr) GEM_WARN_ON(expr) #else @@ -64,7 +63,6 @@ struct drm_i915_private; #define GEM_BUG_ON(expr) BUILD_BUG_ON_INVALID(expr) #define GEM_WARN_ON(expr) ({ unlikely(!!(expr)); }) -#define GEM_DEBUG_EXEC(expr) do { } while (0) #define GEM_DEBUG_WARN_ON(expr) ({ BUILD_BUG_ON_INVALID(expr); 0; }) #endif -- 2.30.2 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915: remove single-use GEM_DEBUG_EXEC() 2022-05-04 18:37 ` [Intel-gfx] [PATCH 2/3] drm/i915: remove single-use GEM_DEBUG_EXEC() Jani Nikula @ 2022-05-05 11:04 ` Tvrtko Ursulin 2022-05-10 9:24 ` Jani Nikula 0 siblings, 1 reply; 10+ messages in thread From: Tvrtko Ursulin @ 2022-05-05 11:04 UTC (permalink / raw) To: Jani Nikula, intel-gfx On 04/05/2022 19:37, Jani Nikula wrote: > Reduce the magic of what's going on in GEM_DEBUG_EXEC() by expanding it > inline and being explicit about it. It's as single use case anyway, so > the macro feels overkill. > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_ring.c | 3 ++- > drivers/gpu/drm/i915/i915_gem.h | 2 -- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c > index 40ffcb94e379..15ec64d881c4 100644 > --- a/drivers/gpu/drm/i915/gt/intel_ring.c > +++ b/drivers/gpu/drm/i915/gt/intel_ring.c > @@ -299,7 +299,8 @@ u32 *intel_ring_begin(struct i915_request *rq, unsigned int num_dwords) > GEM_BUG_ON(ring->emit > ring->size - bytes); > GEM_BUG_ON(ring->space < bytes); > cs = ring->vaddr + ring->emit; > - GEM_DEBUG_EXEC(memset32(cs, POISON_INUSE, bytes / sizeof(*cs))); > + if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) > + memset32(cs, POISON_INUSE, bytes / sizeof(*cs)); > ring->emit += bytes; > ring->space -= bytes; > > diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h > index b7b257f54d2e..a2be323a4be5 100644 > --- a/drivers/gpu/drm/i915/i915_gem.h > +++ b/drivers/gpu/drm/i915/i915_gem.h > @@ -54,7 +54,6 @@ struct drm_i915_private; > } while(0) > #define GEM_WARN_ON(expr) WARN_ON(expr) > > -#define GEM_DEBUG_EXEC(expr) expr > #define GEM_DEBUG_WARN_ON(expr) GEM_WARN_ON(expr) > > #else > @@ -64,7 +63,6 @@ struct drm_i915_private; > #define GEM_BUG_ON(expr) BUILD_BUG_ON_INVALID(expr) > #define GEM_WARN_ON(expr) ({ unlikely(!!(expr)); }) > > -#define GEM_DEBUG_EXEC(expr) do { } while (0) > #define GEM_DEBUG_WARN_ON(expr) ({ BUILD_BUG_ON_INVALID(expr); 0; }) > #endif > Yeah one user after time passed suggests removing is the right course of action. Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915: remove single-use GEM_DEBUG_EXEC() 2022-05-05 11:04 ` Tvrtko Ursulin @ 2022-05-10 9:24 ` Jani Nikula 0 siblings, 0 replies; 10+ messages in thread From: Jani Nikula @ 2022-05-10 9:24 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx On Thu, 05 May 2022, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote: > On 04/05/2022 19:37, Jani Nikula wrote: >> Reduce the magic of what's going on in GEM_DEBUG_EXEC() by expanding it >> inline and being explicit about it. It's as single use case anyway, so >> the macro feels overkill. >> >> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> --- >> drivers/gpu/drm/i915/gt/intel_ring.c | 3 ++- >> drivers/gpu/drm/i915/i915_gem.h | 2 -- >> 2 files changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c >> index 40ffcb94e379..15ec64d881c4 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_ring.c >> +++ b/drivers/gpu/drm/i915/gt/intel_ring.c >> @@ -299,7 +299,8 @@ u32 *intel_ring_begin(struct i915_request *rq, unsigned int num_dwords) >> GEM_BUG_ON(ring->emit > ring->size - bytes); >> GEM_BUG_ON(ring->space < bytes); >> cs = ring->vaddr + ring->emit; >> - GEM_DEBUG_EXEC(memset32(cs, POISON_INUSE, bytes / sizeof(*cs))); >> + if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) >> + memset32(cs, POISON_INUSE, bytes / sizeof(*cs)); >> ring->emit += bytes; >> ring->space -= bytes; >> >> diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h >> index b7b257f54d2e..a2be323a4be5 100644 >> --- a/drivers/gpu/drm/i915/i915_gem.h >> +++ b/drivers/gpu/drm/i915/i915_gem.h >> @@ -54,7 +54,6 @@ struct drm_i915_private; >> } while(0) >> #define GEM_WARN_ON(expr) WARN_ON(expr) >> >> -#define GEM_DEBUG_EXEC(expr) expr >> #define GEM_DEBUG_WARN_ON(expr) GEM_WARN_ON(expr) >> >> #else >> @@ -64,7 +63,6 @@ struct drm_i915_private; >> #define GEM_BUG_ON(expr) BUILD_BUG_ON_INVALID(expr) >> #define GEM_WARN_ON(expr) ({ unlikely(!!(expr)); }) >> >> -#define GEM_DEBUG_EXEC(expr) do { } while (0) >> #define GEM_DEBUG_WARN_ON(expr) ({ BUILD_BUG_ON_INVALID(expr); 0; }) >> #endif >> > > Yeah one user after time passed suggests removing is the right course of > action. > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Thanks, pushed the first two to din. BR, Jani. > > Regards, > > Tvrtko -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915/display: stop using BUG() 2022-05-04 18:37 [Intel-gfx] [PATCH 1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() Jani Nikula 2022-05-04 18:37 ` [Intel-gfx] [PATCH 2/3] drm/i915: remove single-use GEM_DEBUG_EXEC() Jani Nikula @ 2022-05-04 18:37 ` Jani Nikula 2022-05-05 11:07 ` Tvrtko Ursulin 2022-05-04 22:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() Patchwork ` (2 subsequent siblings) 4 siblings, 1 reply; 10+ messages in thread From: Jani Nikula @ 2022-05-04 18:37 UTC (permalink / raw) To: intel-gfx; +Cc: jani.nikula Avoid bringing the entire machine down even if there's a bug that shouldn't happen, but won't corrupt the system either. Log them loudly and limp on. Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_ddi.c | 11 ++++++----- drivers/gpu/drm/i915/display/intel_display.c | 19 +++++++++++-------- .../drm/i915/display/intel_display_types.h | 15 +++++++++------ 3 files changed, 26 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 9e6fa59eabba..52cf6fb9994a 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -455,6 +455,9 @@ intel_ddi_transcoder_func_reg_val_get(struct intel_encoder *encoder, temp |= TRANS_DDI_SELECT_PORT(port); switch (crtc_state->pipe_bpp) { + default: + MISSING_CASE(crtc_state->pipe_bpp); + fallthrough; case 18: temp |= TRANS_DDI_BPC_6; break; @@ -467,8 +470,6 @@ intel_ddi_transcoder_func_reg_val_get(struct intel_encoder *encoder, case 36: temp |= TRANS_DDI_BPC_12; break; - default: - BUG(); } if (crtc_state->hw.adjusted_mode.flags & DRM_MODE_FLAG_PVSYNC) @@ -478,6 +479,9 @@ intel_ddi_transcoder_func_reg_val_get(struct intel_encoder *encoder, if (cpu_transcoder == TRANSCODER_EDP) { switch (pipe) { + default: + MISSING_CASE(pipe); + fallthrough; case PIPE_A: /* On Haswell, can only use the always-on power well for * eDP when not using the panel fitter, and when not @@ -494,9 +498,6 @@ intel_ddi_transcoder_func_reg_val_get(struct intel_encoder *encoder, case PIPE_C: temp |= TRANS_DDI_EDP_INPUT_C_ONOFF; break; - default: - BUG(); - break; } } diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 0decf3d24237..1a421dda36d7 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -500,6 +500,9 @@ void vlv_wait_port_ready(struct drm_i915_private *dev_priv, i915_reg_t dpll_reg; switch (dig_port->base.port) { + default: + MISSING_CASE(dig_port->base.port); + fallthrough; case PORT_B: port_mask = DPLL_PORTB_READY_MASK; dpll_reg = DPLL(0); @@ -513,8 +516,6 @@ void vlv_wait_port_ready(struct drm_i915_private *dev_priv, port_mask = DPLL_PORTD_READY_MASK; dpll_reg = DPIO_PHY_STATUS; break; - default: - BUG(); } if (intel_de_wait_for_register(dev_priv, dpll_reg, @@ -3157,6 +3158,10 @@ static void i9xx_set_pipeconf(const struct intel_crtc_state *crtc_state) PIPECONF_DITHER_TYPE_SP; switch (crtc_state->pipe_bpp) { + default: + /* Case prevented by intel_choose_pipe_bpp_dither. */ + MISSING_CASE(crtc_state->pipe_bpp); + fallthrough; case 18: pipeconf |= PIPECONF_BPC_6; break; @@ -3166,9 +3171,6 @@ static void i9xx_set_pipeconf(const struct intel_crtc_state *crtc_state) case 30: pipeconf |= PIPECONF_BPC_10; break; - default: - /* Case prevented by intel_choose_pipe_bpp_dither. */ - BUG(); } } @@ -3464,6 +3466,10 @@ static void ilk_set_pipeconf(const struct intel_crtc_state *crtc_state) val = 0; switch (crtc_state->pipe_bpp) { + default: + /* Case prevented by intel_choose_pipe_bpp_dither. */ + MISSING_CASE(crtc_state->pipe_bpp); + fallthrough; case 18: val |= PIPECONF_BPC_6; break; @@ -3476,9 +3482,6 @@ static void ilk_set_pipeconf(const struct intel_crtc_state *crtc_state) case 36: val |= PIPECONF_BPC_12; break; - default: - /* Case prevented by intel_choose_pipe_bpp_dither. */ - BUG(); } if (crtc_state->dither) diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h index 408152f9f46a..8b10ef5153f2 100644 --- a/drivers/gpu/drm/i915/display/intel_display_types.h +++ b/drivers/gpu/drm/i915/display/intel_display_types.h @@ -1727,13 +1727,14 @@ static inline enum dpio_channel vlv_dig_port_to_channel(struct intel_digital_port *dig_port) { switch (dig_port->base.port) { + default: + MISSING_CASE(dig_port->base.port); + fallthrough; case PORT_B: case PORT_D: return DPIO_CH0; case PORT_C: return DPIO_CH1; - default: - BUG(); } } @@ -1741,13 +1742,14 @@ static inline enum dpio_phy vlv_dig_port_to_phy(struct intel_digital_port *dig_port) { switch (dig_port->base.port) { + default: + MISSING_CASE(dig_port->base.port); + fallthrough; case PORT_B: case PORT_C: return DPIO_PHY0; case PORT_D: return DPIO_PHY1; - default: - BUG(); } } @@ -1755,13 +1757,14 @@ static inline enum dpio_channel vlv_pipe_to_channel(enum pipe pipe) { switch (pipe) { + default: + MISSING_CASE(pipe); + fallthrough; case PIPE_A: case PIPE_C: return DPIO_CH0; case PIPE_B: return DPIO_CH1; - default: - BUG(); } } -- 2.30.2 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915/display: stop using BUG() 2022-05-04 18:37 ` [Intel-gfx] [PATCH 3/3] drm/i915/display: stop using BUG() Jani Nikula @ 2022-05-05 11:07 ` Tvrtko Ursulin 2022-05-05 11:27 ` Jani Nikula 0 siblings, 1 reply; 10+ messages in thread From: Tvrtko Ursulin @ 2022-05-05 11:07 UTC (permalink / raw) To: Jani Nikula, intel-gfx On 04/05/2022 19:37, Jani Nikula wrote: > Avoid bringing the entire machine down even if there's a bug that > shouldn't happen, but won't corrupt the system either. Log them loudly > and limp on. > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 11 ++++++----- > drivers/gpu/drm/i915/display/intel_display.c | 19 +++++++++++-------- > .../drm/i915/display/intel_display_types.h | 15 +++++++++------ > 3 files changed, 26 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > index 9e6fa59eabba..52cf6fb9994a 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -455,6 +455,9 @@ intel_ddi_transcoder_func_reg_val_get(struct intel_encoder *encoder, > temp |= TRANS_DDI_SELECT_PORT(port); > > switch (crtc_state->pipe_bpp) { > + default: > + MISSING_CASE(crtc_state->pipe_bpp); > + fallthrough; > case 18: > temp |= TRANS_DDI_BPC_6; > break; No idea of how this "limp" would look in practice and if it is safe. Same approach taken elsewhere in the patch so I'm afraid someone with display know how will have to look at it. Regards, Tvrtko > @@ -467,8 +470,6 @@ intel_ddi_transcoder_func_reg_val_get(struct intel_encoder *encoder, > case 36: > temp |= TRANS_DDI_BPC_12; > break; > - default: > - BUG(); > } > > if (crtc_state->hw.adjusted_mode.flags & DRM_MODE_FLAG_PVSYNC) > @@ -478,6 +479,9 @@ intel_ddi_transcoder_func_reg_val_get(struct intel_encoder *encoder, > > if (cpu_transcoder == TRANSCODER_EDP) { > switch (pipe) { > + default: > + MISSING_CASE(pipe); > + fallthrough; > case PIPE_A: > /* On Haswell, can only use the always-on power well for > * eDP when not using the panel fitter, and when not > @@ -494,9 +498,6 @@ intel_ddi_transcoder_func_reg_val_get(struct intel_encoder *encoder, > case PIPE_C: > temp |= TRANS_DDI_EDP_INPUT_C_ONOFF; > break; > - default: > - BUG(); > - break; > } > } > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index 0decf3d24237..1a421dda36d7 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -500,6 +500,9 @@ void vlv_wait_port_ready(struct drm_i915_private *dev_priv, > i915_reg_t dpll_reg; > > switch (dig_port->base.port) { > + default: > + MISSING_CASE(dig_port->base.port); > + fallthrough; > case PORT_B: > port_mask = DPLL_PORTB_READY_MASK; > dpll_reg = DPLL(0); > @@ -513,8 +516,6 @@ void vlv_wait_port_ready(struct drm_i915_private *dev_priv, > port_mask = DPLL_PORTD_READY_MASK; > dpll_reg = DPIO_PHY_STATUS; > break; > - default: > - BUG(); > } > > if (intel_de_wait_for_register(dev_priv, dpll_reg, > @@ -3157,6 +3158,10 @@ static void i9xx_set_pipeconf(const struct intel_crtc_state *crtc_state) > PIPECONF_DITHER_TYPE_SP; > > switch (crtc_state->pipe_bpp) { > + default: > + /* Case prevented by intel_choose_pipe_bpp_dither. */ > + MISSING_CASE(crtc_state->pipe_bpp); > + fallthrough; > case 18: > pipeconf |= PIPECONF_BPC_6; > break; > @@ -3166,9 +3171,6 @@ static void i9xx_set_pipeconf(const struct intel_crtc_state *crtc_state) > case 30: > pipeconf |= PIPECONF_BPC_10; > break; > - default: > - /* Case prevented by intel_choose_pipe_bpp_dither. */ > - BUG(); > } > } > > @@ -3464,6 +3466,10 @@ static void ilk_set_pipeconf(const struct intel_crtc_state *crtc_state) > val = 0; > > switch (crtc_state->pipe_bpp) { > + default: > + /* Case prevented by intel_choose_pipe_bpp_dither. */ > + MISSING_CASE(crtc_state->pipe_bpp); > + fallthrough; > case 18: > val |= PIPECONF_BPC_6; > break; > @@ -3476,9 +3482,6 @@ static void ilk_set_pipeconf(const struct intel_crtc_state *crtc_state) > case 36: > val |= PIPECONF_BPC_12; > break; > - default: > - /* Case prevented by intel_choose_pipe_bpp_dither. */ > - BUG(); > } > > if (crtc_state->dither) > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h > index 408152f9f46a..8b10ef5153f2 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > @@ -1727,13 +1727,14 @@ static inline enum dpio_channel > vlv_dig_port_to_channel(struct intel_digital_port *dig_port) > { > switch (dig_port->base.port) { > + default: > + MISSING_CASE(dig_port->base.port); > + fallthrough; > case PORT_B: > case PORT_D: > return DPIO_CH0; > case PORT_C: > return DPIO_CH1; > - default: > - BUG(); > } > } > > @@ -1741,13 +1742,14 @@ static inline enum dpio_phy > vlv_dig_port_to_phy(struct intel_digital_port *dig_port) > { > switch (dig_port->base.port) { > + default: > + MISSING_CASE(dig_port->base.port); > + fallthrough; > case PORT_B: > case PORT_C: > return DPIO_PHY0; > case PORT_D: > return DPIO_PHY1; > - default: > - BUG(); > } > } > > @@ -1755,13 +1757,14 @@ static inline enum dpio_channel > vlv_pipe_to_channel(enum pipe pipe) > { > switch (pipe) { > + default: > + MISSING_CASE(pipe); > + fallthrough; > case PIPE_A: > case PIPE_C: > return DPIO_CH0; > case PIPE_B: > return DPIO_CH1; > - default: > - BUG(); > } > } > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915/display: stop using BUG() 2022-05-05 11:07 ` Tvrtko Ursulin @ 2022-05-05 11:27 ` Jani Nikula 0 siblings, 0 replies; 10+ messages in thread From: Jani Nikula @ 2022-05-05 11:27 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx On Thu, 05 May 2022, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote: > On 04/05/2022 19:37, Jani Nikula wrote: >> Avoid bringing the entire machine down even if there's a bug that >> shouldn't happen, but won't corrupt the system either. Log them loudly >> and limp on. >> >> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> --- >> drivers/gpu/drm/i915/display/intel_ddi.c | 11 ++++++----- >> drivers/gpu/drm/i915/display/intel_display.c | 19 +++++++++++-------- >> .../drm/i915/display/intel_display_types.h | 15 +++++++++------ >> 3 files changed, 26 insertions(+), 19 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c >> index 9e6fa59eabba..52cf6fb9994a 100644 >> --- a/drivers/gpu/drm/i915/display/intel_ddi.c >> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c >> @@ -455,6 +455,9 @@ intel_ddi_transcoder_func_reg_val_get(struct intel_encoder *encoder, >> temp |= TRANS_DDI_SELECT_PORT(port); >> >> switch (crtc_state->pipe_bpp) { >> + default: >> + MISSING_CASE(crtc_state->pipe_bpp); >> + fallthrough; >> case 18: >> temp |= TRANS_DDI_BPC_6; >> break; > > No idea of how this "limp" would look in practice and if it is safe. Worst case it's a black screen I think, but that's infinitely better than bringing the entire box down. > Same approach taken elsewhere in the patch so I'm afraid someone with > display know how will have to look at it. Cc: Ville. BR, Jani. > > Regards, > > Tvrtko > >> @@ -467,8 +470,6 @@ intel_ddi_transcoder_func_reg_val_get(struct intel_encoder *encoder, >> case 36: >> temp |= TRANS_DDI_BPC_12; >> break; >> - default: >> - BUG(); >> } >> >> if (crtc_state->hw.adjusted_mode.flags & DRM_MODE_FLAG_PVSYNC) >> @@ -478,6 +479,9 @@ intel_ddi_transcoder_func_reg_val_get(struct intel_encoder *encoder, >> >> if (cpu_transcoder == TRANSCODER_EDP) { >> switch (pipe) { >> + default: >> + MISSING_CASE(pipe); >> + fallthrough; >> case PIPE_A: >> /* On Haswell, can only use the always-on power well for >> * eDP when not using the panel fitter, and when not >> @@ -494,9 +498,6 @@ intel_ddi_transcoder_func_reg_val_get(struct intel_encoder *encoder, >> case PIPE_C: >> temp |= TRANS_DDI_EDP_INPUT_C_ONOFF; >> break; >> - default: >> - BUG(); >> - break; >> } >> } >> >> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c >> index 0decf3d24237..1a421dda36d7 100644 >> --- a/drivers/gpu/drm/i915/display/intel_display.c >> +++ b/drivers/gpu/drm/i915/display/intel_display.c >> @@ -500,6 +500,9 @@ void vlv_wait_port_ready(struct drm_i915_private *dev_priv, >> i915_reg_t dpll_reg; >> >> switch (dig_port->base.port) { >> + default: >> + MISSING_CASE(dig_port->base.port); >> + fallthrough; >> case PORT_B: >> port_mask = DPLL_PORTB_READY_MASK; >> dpll_reg = DPLL(0); >> @@ -513,8 +516,6 @@ void vlv_wait_port_ready(struct drm_i915_private *dev_priv, >> port_mask = DPLL_PORTD_READY_MASK; >> dpll_reg = DPIO_PHY_STATUS; >> break; >> - default: >> - BUG(); >> } >> >> if (intel_de_wait_for_register(dev_priv, dpll_reg, >> @@ -3157,6 +3158,10 @@ static void i9xx_set_pipeconf(const struct intel_crtc_state *crtc_state) >> PIPECONF_DITHER_TYPE_SP; >> >> switch (crtc_state->pipe_bpp) { >> + default: >> + /* Case prevented by intel_choose_pipe_bpp_dither. */ >> + MISSING_CASE(crtc_state->pipe_bpp); >> + fallthrough; >> case 18: >> pipeconf |= PIPECONF_BPC_6; >> break; >> @@ -3166,9 +3171,6 @@ static void i9xx_set_pipeconf(const struct intel_crtc_state *crtc_state) >> case 30: >> pipeconf |= PIPECONF_BPC_10; >> break; >> - default: >> - /* Case prevented by intel_choose_pipe_bpp_dither. */ >> - BUG(); >> } >> } >> >> @@ -3464,6 +3466,10 @@ static void ilk_set_pipeconf(const struct intel_crtc_state *crtc_state) >> val = 0; >> >> switch (crtc_state->pipe_bpp) { >> + default: >> + /* Case prevented by intel_choose_pipe_bpp_dither. */ >> + MISSING_CASE(crtc_state->pipe_bpp); >> + fallthrough; >> case 18: >> val |= PIPECONF_BPC_6; >> break; >> @@ -3476,9 +3482,6 @@ static void ilk_set_pipeconf(const struct intel_crtc_state *crtc_state) >> case 36: >> val |= PIPECONF_BPC_12; >> break; >> - default: >> - /* Case prevented by intel_choose_pipe_bpp_dither. */ >> - BUG(); >> } >> >> if (crtc_state->dither) >> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h >> index 408152f9f46a..8b10ef5153f2 100644 >> --- a/drivers/gpu/drm/i915/display/intel_display_types.h >> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h >> @@ -1727,13 +1727,14 @@ static inline enum dpio_channel >> vlv_dig_port_to_channel(struct intel_digital_port *dig_port) >> { >> switch (dig_port->base.port) { >> + default: >> + MISSING_CASE(dig_port->base.port); >> + fallthrough; >> case PORT_B: >> case PORT_D: >> return DPIO_CH0; >> case PORT_C: >> return DPIO_CH1; >> - default: >> - BUG(); >> } >> } >> >> @@ -1741,13 +1742,14 @@ static inline enum dpio_phy >> vlv_dig_port_to_phy(struct intel_digital_port *dig_port) >> { >> switch (dig_port->base.port) { >> + default: >> + MISSING_CASE(dig_port->base.port); >> + fallthrough; >> case PORT_B: >> case PORT_C: >> return DPIO_PHY0; >> case PORT_D: >> return DPIO_PHY1; >> - default: >> - BUG(); >> } >> } >> >> @@ -1755,13 +1757,14 @@ static inline enum dpio_channel >> vlv_pipe_to_channel(enum pipe pipe) >> { >> switch (pipe) { >> + default: >> + MISSING_CASE(pipe); >> + fallthrough; >> case PIPE_A: >> case PIPE_C: >> return DPIO_CH0; >> case PIPE_B: >> return DPIO_CH1; >> - default: >> - BUG(); >> } >> } >> -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() 2022-05-04 18:37 [Intel-gfx] [PATCH 1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() Jani Nikula 2022-05-04 18:37 ` [Intel-gfx] [PATCH 2/3] drm/i915: remove single-use GEM_DEBUG_EXEC() Jani Nikula 2022-05-04 18:37 ` [Intel-gfx] [PATCH 3/3] drm/i915/display: stop using BUG() Jani Nikula @ 2022-05-04 22:08 ` Patchwork 2022-05-05 3:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2022-05-05 11:04 ` [Intel-gfx] [PATCH 1/3] " Tvrtko Ursulin 4 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2022-05-04 22:08 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 10511 bytes --] == Series Details == Series: series starting with [1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() URL : https://patchwork.freedesktop.org/series/103560/ State : success == Summary == CI Bug Log - changes from CI_DRM_11606 -> Patchwork_103560v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/index.html Participating hosts (42 -> 41) ------------------------------ Additional (2): bat-rpls-1 fi-rkl-11600 Missing (3): bat-dg2-8 fi-bsw-cyan bat-dg1-5 Known issues ------------ Here are the changes found in Patchwork_103560v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_huc_copy@huc-copy: - fi-rkl-11600: NOTRUN -> [SKIP][1] ([i915#2190]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@basic: - fi-rkl-11600: NOTRUN -> [SKIP][2] ([i915#4613]) +3 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-rkl-11600/igt@gem_lmem_swapping@basic.html * igt@gem_tiled_pread_basic: - fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#3282]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html * igt@i915_pm_backlight@basic-brightness: - fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#3012]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html * igt@i915_selftest@live@hangcheck: - fi-hsw-4770: [PASS][5] -> [INCOMPLETE][6] ([i915#4785]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html - fi-snb-2600: [PASS][7] -> [INCOMPLETE][8] ([i915#3921]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/fi-snb-2600/igt@i915_selftest@live@hangcheck.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-snb-2600/igt@i915_selftest@live@hangcheck.html * igt@i915_selftest@live@mman: - fi-bdw-5557u: [PASS][9] -> [INCOMPLETE][10] ([i915#5704]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/fi-bdw-5557u/igt@i915_selftest@live@mman.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-bdw-5557u/igt@i915_selftest@live@mman.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-pnv-d510: NOTRUN -> [SKIP][11] ([fdo#109271]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-pnv-d510/igt@kms_chamelium@common-hpd-after-suspend.html - fi-hsw-g3258: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-hsw-g3258/igt@kms_chamelium@common-hpd-after-suspend.html * igt@kms_chamelium@dp-crc-fast: - fi-rkl-11600: NOTRUN -> [SKIP][13] ([fdo#111827]) +8 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-rkl-11600/igt@kms_chamelium@dp-crc-fast.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-rkl-11600: NOTRUN -> [SKIP][14] ([i915#4070] / [i915#4103]) +1 similar issue [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_force_connector_basic@force-load-detect: - fi-rkl-11600: NOTRUN -> [SKIP][15] ([fdo#109285] / [i915#4098]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - fi-rkl-11600: NOTRUN -> [SKIP][16] ([i915#4070] / [i915#533]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-rkl-11600/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_psr@primary_mmap_gtt: - fi-rkl-11600: NOTRUN -> [SKIP][17] ([i915#1072]) +3 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-rkl-11600/igt@kms_psr@primary_mmap_gtt.html * igt@kms_setmode@basic-clone-single-crtc: - fi-rkl-11600: NOTRUN -> [SKIP][18] ([i915#3555] / [i915#4098]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-userptr: - fi-rkl-11600: NOTRUN -> [SKIP][19] ([i915#3301] / [i915#3708]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-rkl-11600/igt@prime_vgem@basic-userptr.html * igt@prime_vgem@basic-write: - fi-rkl-11600: NOTRUN -> [SKIP][20] ([i915#3291] / [i915#3708]) +2 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-rkl-11600/igt@prime_vgem@basic-write.html * igt@runner@aborted: - fi-hsw-4770: NOTRUN -> [FAIL][21] ([fdo#109271] / [i915#4312] / [i915#5594]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-hsw-4770/igt@runner@aborted.html #### Possible fixes #### * igt@core_hotunplug@unbind-rebind: - {bat-rpls-2}: [DMESG-WARN][22] ([i915#4391]) -> [PASS][23] [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/bat-rpls-2/igt@core_hotunplug@unbind-rebind.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/bat-rpls-2/igt@core_hotunplug@unbind-rebind.html * igt@gem_exec_suspend@basic-s0@smem: - {fi-ehl-2}: [DMESG-WARN][24] ([i915#5122]) -> [PASS][25] [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/fi-ehl-2/igt@gem_exec_suspend@basic-s0@smem.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-ehl-2/igt@gem_exec_suspend@basic-s0@smem.html * igt@gem_ringfill@basic-all: - {bat-dg2-9}: [FAIL][26] ([i915#5886]) -> [PASS][27] [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/bat-dg2-9/igt@gem_ringfill@basic-all.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/bat-dg2-9/igt@gem_ringfill@basic-all.html * igt@i915_selftest@live@client: - {bat-dg2-9}: [DMESG-FAIL][28] ([i915#5879]) -> [PASS][29] [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/bat-dg2-9/igt@i915_selftest@live@client.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/bat-dg2-9/igt@i915_selftest@live@client.html * igt@i915_selftest@live@hangcheck: - fi-hsw-g3258: [INCOMPLETE][30] ([i915#3303] / [i915#4785]) -> [PASS][31] [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html * igt@i915_selftest@live@requests: - fi-pnv-d510: [DMESG-FAIL][32] ([i915#4528]) -> [PASS][33] [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/fi-pnv-d510/igt@i915_selftest@live@requests.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/fi-pnv-d510/igt@i915_selftest@live@requests.html * igt@kms_busy@basic@flip: - {bat-adlp-6}: [DMESG-WARN][34] ([i915#3576]) -> [PASS][35] [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/bat-adlp-6/igt@kms_busy@basic@flip.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/bat-adlp-6/igt@kms_busy@basic@flip.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391 [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594 [i915#5704]: https://gitlab.freedesktop.org/drm/intel/issues/5704 [i915#5879]: https://gitlab.freedesktop.org/drm/intel/issues/5879 [i915#5886]: https://gitlab.freedesktop.org/drm/intel/issues/5886 Build changes ------------- * Linux: CI_DRM_11606 -> Patchwork_103560v1 CI-20190529: 20190529 CI_DRM_11606: 8c54eb62d24a1240ce9ebb2adf65dc80ff746c4f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6465: f6bb4399881a806fbff75ce3df89b60286d55917 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_103560v1: 8c54eb62d24a1240ce9ebb2adf65dc80ff746c4f @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits a2052182150a drm/i915/display: stop using BUG() 34b097289a67 drm/i915: remove single-use GEM_DEBUG_EXEC() 51f677533c9e drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/index.html [-- Attachment #2: Type: text/html, Size: 12139 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() 2022-05-04 18:37 [Intel-gfx] [PATCH 1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() Jani Nikula ` (2 preceding siblings ...) 2022-05-04 22:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() Patchwork @ 2022-05-05 3:20 ` Patchwork 2022-05-05 11:04 ` [Intel-gfx] [PATCH 1/3] " Tvrtko Ursulin 4 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2022-05-05 3:20 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 38718 bytes --] == Series Details == Series: series starting with [1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() URL : https://patchwork.freedesktop.org/series/103560/ State : success == Summary == CI Bug Log - changes from CI_DRM_11606_full -> Patchwork_103560v1_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (13 -> 13) ------------------------------ No changes in participating hosts Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_103560v1_full: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@kms_plane_multiple@atomic-pipe-d-tiling-x: - {shard-dg1}: NOTRUN -> [FAIL][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-dg1-17/igt@kms_plane_multiple@atomic-pipe-d-tiling-x.html Known issues ------------ Here are the changes found in Patchwork_103560v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_fair@basic-flow@rcs0: - shard-skl: NOTRUN -> [SKIP][2] ([fdo#109271]) +48 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl9/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [PASS][3] -> [FAIL][4] ([i915#2842]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_flush@basic-uc-set-default: - shard-snb: [PASS][5] -> [SKIP][6] ([fdo#109271]) +3 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-snb4/igt@gem_exec_flush@basic-uc-set-default.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-snb6/igt@gem_exec_flush@basic-uc-set-default.html * igt@gem_lmem_swapping@heavy-verify-multi: - shard-kbl: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl3/igt@gem_lmem_swapping@heavy-verify-multi.html * igt@gem_lmem_swapping@verify-random: - shard-apl: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4613]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-apl8/igt@gem_lmem_swapping@verify-random.html * igt@gen9_exec_parse@allowed-single: - shard-glk: [PASS][9] -> [DMESG-WARN][10] ([i915#5566] / [i915#716]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-glk2/igt@gen9_exec_parse@allowed-single.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-glk7/igt@gen9_exec_parse@allowed-single.html - shard-apl: [PASS][11] -> [DMESG-WARN][12] ([i915#5566] / [i915#716]) +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-apl2/igt@gen9_exec_parse@allowed-single.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-apl6/igt@gen9_exec_parse@allowed-single.html * igt@i915_selftest@live@hangcheck: - shard-snb: [PASS][13] -> [INCOMPLETE][14] ([i915#3921]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-snb4/igt@i915_selftest@live@hangcheck.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-snb7/igt@i915_selftest@live@hangcheck.html * igt@kms_big_fb@linear-16bpp-rotate-90: - shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271]) +49 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-apl8/igt@kms_big_fb@linear-16bpp-rotate-90.html * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip: - shard-iclb: NOTRUN -> [SKIP][16] ([fdo#110723]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb7/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html * igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc: - shard-skl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#3886]) +2 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl3/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc: - shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#3886]) +1 similar issue [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-apl8/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs: - shard-kbl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#3886]) +1 similar issue [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl3/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs: - shard-kbl: NOTRUN -> [SKIP][20] ([fdo#109271]) +48 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl3/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs.html * igt@kms_chamelium@hdmi-edid-change-during-suspend: - shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111827]) +5 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-apl4/igt@kms_chamelium@hdmi-edid-change-during-suspend.html * igt@kms_chamelium@vga-hpd-after-suspend: - shard-skl: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +1 similar issue [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl3/igt@kms_chamelium@vga-hpd-after-suspend.html * igt@kms_color_chamelium@pipe-a-ctm-max: - shard-iclb: NOTRUN -> [SKIP][23] ([fdo#109284] / [fdo#111827]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb7/igt@kms_color_chamelium@pipe-a-ctm-max.html * igt@kms_color_chamelium@pipe-c-ctm-limited-range: - shard-kbl: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827]) +2 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl3/igt@kms_color_chamelium@pipe-c-ctm-limited-range.html * igt@kms_cursor_crc@pipe-a-cursor-32x32-onscreen: - shard-iclb: NOTRUN -> [SKIP][25] ([fdo#109278]) +1 similar issue [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb7/igt@kms_cursor_crc@pipe-a-cursor-32x32-onscreen.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: NOTRUN -> [FAIL][26] ([i915#2346]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-apl: [PASS][27] -> [FAIL][28] ([i915#4767]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-apl7/igt@kms_fbcon_fbt@fbc-suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2: - shard-glk: [PASS][29] -> [FAIL][30] ([i915#79]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-apl: [PASS][31] -> [DMESG-WARN][32] ([i915#180]) +2 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1: - shard-skl: [PASS][33] -> [FAIL][34] ([i915#2122]) +1 similar issue [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-skl1/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl5/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling: - shard-iclb: [PASS][35] -> [SKIP][36] ([i915#3701]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-iclb6/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +7 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-rte: - shard-iclb: NOTRUN -> [SKIP][39] ([fdo#109280]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-rte.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [PASS][40] -> [FAIL][41] ([fdo#108145] / [i915#265]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: NOTRUN -> [SKIP][42] ([i915#3536]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_plane_scaling@upscale-with-rotation-factor-0-25@pipe-b-edp-1-upscale-with-rotation: - shard-iclb: NOTRUN -> [SKIP][43] ([i915#5176]) +2 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb7/igt@kms_plane_scaling@upscale-with-rotation-factor-0-25@pipe-b-edp-1-upscale-with-rotation.html * igt@kms_psr2_sf@overlay-plane-update-continuous-sf: - shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#658]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl1/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html * igt@kms_psr@psr2_no_drrs: - shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#109441]) +2 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-iclb2/igt@kms_psr@psr2_no_drrs.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb7/igt@kms_psr@psr2_no_drrs.html * igt@prime_nv_test@nv_i915_sharing: - shard-iclb: NOTRUN -> [SKIP][47] ([fdo#109291]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb7/igt@prime_nv_test@nv_i915_sharing.html * igt@syncobj_timeline@transfer-timeline-point: - shard-skl: NOTRUN -> [DMESG-FAIL][48] ([i915#5098]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl7/igt@syncobj_timeline@transfer-timeline-point.html * igt@sysfs_clients@pidname: - shard-apl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#2994]) +1 similar issue [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-apl8/igt@sysfs_clients@pidname.html * igt@sysfs_clients@recycle-many: - shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#2994]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl3/igt@sysfs_clients@recycle-many.html #### Possible fixes #### * igt@drm_buddy@all@buddy_alloc_smoke: - shard-skl: [INCOMPLETE][51] ([i915#5800]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-skl5/igt@drm_buddy@all@buddy_alloc_smoke.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl2/igt@drm_buddy@all@buddy_alloc_smoke.html * igt@gem_exec_fence@submit3@vecs0: - shard-skl: [DMESG-WARN][53] ([i915#1982]) -> [PASS][54] +1 similar issue [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-skl10/igt@gem_exec_fence@submit3@vecs0.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl7/igt@gem_exec_fence@submit3@vecs0.html * igt@gem_exec_flush@basic-uc-rw-default: - shard-snb: [SKIP][55] ([fdo#109271]) -> [PASS][56] +1 similar issue [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-snb6/igt@gem_exec_flush@basic-uc-rw-default.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-snb5/igt@gem_exec_flush@basic-uc-rw-default.html * igt@gem_exec_suspend@basic-s3@smem: - shard-kbl: [DMESG-WARN][57] ([i915#180]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl7/igt@gem_exec_suspend@basic-s3@smem.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl3/igt@gem_exec_suspend@basic-s3@smem.html * igt@gem_workarounds@suspend-resume-context: - shard-skl: [INCOMPLETE][59] ([i915#4939] / [i915#5129]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-skl6/igt@gem_workarounds@suspend-resume-context.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl3/igt@gem_workarounds@suspend-resume-context.html * igt@gen9_exec_parse@allowed-single: - shard-skl: [DMESG-WARN][61] ([i915#5566] / [i915#716]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-skl5/igt@gen9_exec_parse@allowed-single.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl1/igt@gen9_exec_parse@allowed-single.html * igt@i915_pm_rpm@modeset-lpsp-stress-no-wait: - {shard-rkl}: [SKIP][63] ([i915#1397]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-4/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html * igt@i915_pm_rps@waitboost: - {shard-rkl}: [FAIL][65] ([i915#4016]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-2/igt@i915_pm_rps@waitboost.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@i915_pm_rps@waitboost.html * igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc: - {shard-rkl}: [SKIP][67] ([i915#1845] / [i915#4098]) -> [PASS][68] +10 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-1/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html * igt@kms_color@pipe-a-ctm-0-75: - {shard-rkl}: [SKIP][69] ([i915#1149] / [i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][70] +1 similar issue [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-1/igt@kms_color@pipe-a-ctm-0-75.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@kms_color@pipe-a-ctm-0-75.html * igt@kms_cursor_crc@pipe-a-cursor-64x21-rapid-movement: - {shard-rkl}: [SKIP][71] ([fdo#112022] / [i915#4070]) -> [PASS][72] +2 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-2/igt@kms_cursor_crc@pipe-a-cursor-64x21-rapid-movement.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-64x21-rapid-movement.html * igt@kms_cursor_edge_walk@pipe-a-128x128-left-edge: - {shard-rkl}: [SKIP][73] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][74] +1 similar issue [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-5/igt@kms_cursor_edge_walk@pipe-a-128x128-left-edge.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@kms_cursor_edge_walk@pipe-a-128x128-left-edge.html * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy: - {shard-rkl}: [SKIP][75] ([fdo#111825] / [i915#4070]) -> [PASS][76] +4 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-2/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-glk: [FAIL][77] ([i915#2346]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled: - {shard-rkl}: [SKIP][79] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][80] +2 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-2/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled.html * igt@kms_flip@wf_vblank-ts-check-interruptible@c-edp1: - shard-skl: [FAIL][81] ([i915#2122]) -> [PASS][82] +4 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-skl3/igt@kms_flip@wf_vblank-ts-check-interruptible@c-edp1.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl6/igt@kms_flip@wf_vblank-ts-check-interruptible@c-edp1.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff: - shard-glk: [DMESG-FAIL][83] ([i915#118]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-glk5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-glk2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-apl: [DMESG-WARN][85] ([i915#180]) -> [PASS][86] +2 similar issues [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-apl3/igt@kms_frontbuffer_tracking@fbc-suspend.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-apl8/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbc-tiling-y: - {shard-rkl}: [SKIP][87] ([i915#1849] / [i915#4098]) -> [PASS][88] +13 similar issues [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-tiling-y.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-tiling-y.html * igt@kms_invalid_mode@bad-hsync-start: - {shard-rkl}: [SKIP][89] ([i915#4278]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-1/igt@kms_invalid_mode@bad-hsync-start.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@kms_invalid_mode@bad-hsync-start.html * igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence: - {shard-rkl}: [SKIP][91] ([i915#4098]) -> [PASS][92] [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-4/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html * igt@kms_plane@pixel-format-source-clamping@pipe-b-planes: - {shard-rkl}: [SKIP][93] ([i915#1849] / [i915#3558]) -> [PASS][94] +1 similar issue [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-5/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html * igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb: - {shard-rkl}: [SKIP][95] ([i915#4070] / [i915#4098]) -> [PASS][96] [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-4/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [FAIL][97] ([fdo#108145] / [i915#265]) -> [PASS][98] +3 similar issues [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr@dpms: - {shard-rkl}: [SKIP][99] ([i915#1072]) -> [PASS][100] [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-rkl-2/igt@kms_psr@dpms.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-rkl-6/igt@kms_psr@dpms.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [SKIP][101] ([fdo#109441]) -> [PASS][102] [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-iclb6/igt@kms_psr@psr2_primary_page_flip.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html #### Warnings #### * igt@gem_eio@unwedge-stress: - shard-tglb: [FAIL][103] ([i915#5784]) -> [TIMEOUT][104] ([i915#3063]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-tglb1/igt@gem_eio@unwedge-stress.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-tglb6/igt@gem_eio@unwedge-stress.html * igt@gem_exec_balancer@parallel: - shard-iclb: [SKIP][105] ([i915#4525]) -> [DMESG-WARN][106] ([i915#5614]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-iclb5/igt@gem_exec_balancer@parallel.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb2/igt@gem_exec_balancer@parallel.html * igt@gem_exec_balancer@parallel-bb-first: - shard-iclb: [DMESG-WARN][107] ([i915#5614]) -> [SKIP][108] ([i915#4525]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-iclb2/igt@gem_exec_balancer@parallel-bb-first.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb7/igt@gem_exec_balancer@parallel-bb-first.html * igt@gem_exec_balancer@parallel-ordering: - shard-iclb: [SKIP][109] ([i915#4525]) -> [DMESG-FAIL][110] ([i915#5614]) [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-iclb5/igt@gem_exec_balancer@parallel-ordering.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb2/igt@gem_exec_balancer@parallel-ordering.html * igt@kms_draw_crc@draw-method-rgb565-render-xtiled: - shard-glk: [FAIL][111] ([i915#5160]) -> [DMESG-FAIL][112] ([i915#118]) [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-glk5/igt@kms_draw_crc@draw-method-rgb565-render-xtiled.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-glk2/igt@kms_draw_crc@draw-method-rgb565-render-xtiled.html * igt@kms_psr2_sf@cursor-plane-update-sf: - shard-iclb: [SKIP][113] ([fdo#111068] / [i915#658]) -> [SKIP][114] ([i915#2920]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-iclb6/igt@kms_psr2_sf@cursor-plane-update-sf.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html * igt@runner@aborted: - shard-kbl: ([FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl7/igt@runner@aborted.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl7/igt@runner@aborted.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl6/igt@runner@aborted.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl6/igt@runner@aborted.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl3/igt@runner@aborted.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl3/igt@runner@aborted.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl1/igt@runner@aborted.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl1/igt@runner@aborted.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl1/igt@runner@aborted.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl4/igt@runner@aborted.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl1/igt@runner@aborted.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl4/igt@runner@aborted.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11606/shard-kbl6/igt@runner@aborted.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl7/igt@runner@aborted.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl7/igt@runner@aborted.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl7/igt@runner@aborted.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl7/igt@runner@aborted.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl1/igt@runner@aborted.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl6/igt@runner@aborted.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl3/igt@runner@aborted.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl1/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl7/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl7/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl1/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl3/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl1/igt@runner@aborted.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl7/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/shard-kbl4/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302 [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307 [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644 [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112022]: https://bugs.freedesktop.org/show_bug.cgi?id=112022 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149 [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755 [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902 [i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002 [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012 [i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319 [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528 [i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742 [i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804 [i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921 [i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936 [i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369 [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767 [i915#4807]: https://gitlab.freedesktop.org/drm/intel/issues/4807 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4842]: https://gitlab.freedesktop.org/drm/intel/issues/4842 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860 [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873 [i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879 [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881 [i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939 [i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991 [i915#5076]: https://gitlab.freedesktop.org/drm/intel/issues/5076 [i915#5098]: https://gitlab.freedesktop.org/drm/intel/issues/5098 [i915#5129]: https://gitlab.freedesktop.org/drm/intel/issues/5129 [i915#5160]: https://gitlab.freedesktop.org/drm/intel/issues/5160 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257 [i915#5266]: https://gitlab.freedesktop.org/drm/intel/issues/5266 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287 [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5312]: https://gitlab.freedesktop.org/drm/intel/issues/5312 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439 [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5614]: https://gitlab.freedesktop.org/drm/intel/issues/5614 [i915#5691]: https://gitlab.freedesktop.org/drm/intel/issues/5691 [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#5800]: https://gitlab.freedesktop.org/drm/intel/issues/5800 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 Build changes ------------- * Linux: CI_DRM_11606 -> Patchwork_103560v1 CI-20190529: 20190529 CI_DRM_11606: 8c54eb62d24a1240ce9ebb2adf65dc80ff746c4f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6465: f6bb4399881a806fbff75ce3df89b60286d55917 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_103560v1: 8c54eb62d24a1240ce9ebb2adf65dc80ff746c4f @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103560v1/index.html [-- Attachment #2: Type: text/html, Size: 39118 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() 2022-05-04 18:37 [Intel-gfx] [PATCH 1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() Jani Nikula ` (3 preceding siblings ...) 2022-05-05 3:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2022-05-05 11:04 ` Tvrtko Ursulin 4 siblings, 0 replies; 10+ messages in thread From: Tvrtko Ursulin @ 2022-05-05 11:04 UTC (permalink / raw) To: Jani Nikula, intel-gfx On 04/05/2022 19:37, Jani Nikula wrote: > There are already too many choices here, take away the unused ones. > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/i915_gem.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h > index d0752e5553db..b7b257f54d2e 100644 > --- a/drivers/gpu/drm/i915/i915_gem.h > +++ b/drivers/gpu/drm/i915/i915_gem.h > @@ -54,9 +54,7 @@ struct drm_i915_private; > } while(0) > #define GEM_WARN_ON(expr) WARN_ON(expr) > > -#define GEM_DEBUG_DECL(var) var > #define GEM_DEBUG_EXEC(expr) expr > -#define GEM_DEBUG_BUG_ON(expr) GEM_BUG_ON(expr) > #define GEM_DEBUG_WARN_ON(expr) GEM_WARN_ON(expr) > > #else > @@ -66,9 +64,7 @@ struct drm_i915_private; > #define GEM_BUG_ON(expr) BUILD_BUG_ON_INVALID(expr) > #define GEM_WARN_ON(expr) ({ unlikely(!!(expr)); }) > > -#define GEM_DEBUG_DECL(var) > #define GEM_DEBUG_EXEC(expr) do { } while (0) > -#define GEM_DEBUG_BUG_ON(expr) > #define GEM_DEBUG_WARN_ON(expr) ({ BUILD_BUG_ON_INVALID(expr); 0; }) > #endif > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-05-10 9:24 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-05-04 18:37 [Intel-gfx] [PATCH 1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() Jani Nikula 2022-05-04 18:37 ` [Intel-gfx] [PATCH 2/3] drm/i915: remove single-use GEM_DEBUG_EXEC() Jani Nikula 2022-05-05 11:04 ` Tvrtko Ursulin 2022-05-10 9:24 ` Jani Nikula 2022-05-04 18:37 ` [Intel-gfx] [PATCH 3/3] drm/i915/display: stop using BUG() Jani Nikula 2022-05-05 11:07 ` Tvrtko Ursulin 2022-05-05 11:27 ` Jani Nikula 2022-05-04 22:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON() Patchwork 2022-05-05 3:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2022-05-05 11:04 ` [Intel-gfx] [PATCH 1/3] " Tvrtko Ursulin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox