* [Intel-gfx] [PATCH] drm/i915/display: clean up comments
@ 2022-07-01 20:32 Tom Rix
2022-07-01 21:25 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-07-01 23:52 ` [Intel-gfx] [PATCH] " Matt Roper
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2022-07-01 20:32 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, tvrtko.ursulin,
airlied, daniel, jose.souza, jouni.hogander, gwan-gyeong.mun,
ville.syrjala, matthew.d.roper
Cc: Tom Rix, intel-gfx, linux-kernel, dri-devel
spelling changes
resoluition -> resolution
dont -> don't
commmit -> commit
Invalidade -> Invalidate
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 7d61c55184e5..e6a870641cd2 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -555,7 +555,7 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)
/*
* TODO: 7 lines of IO_BUFFER_WAKE and FAST_WAKE are default
* values from BSpec. In order to setting an optimal power
- * consumption, lower than 4k resoluition mode needs to decrese
+ * consumption, lower than 4k resolution mode needs to decrease
* IO_BUFFER_WAKE and FAST_WAKE. And higher than 4K resolution
* mode needs to increase IO_BUFFER_WAKE and FAST_WAKE.
*/
@@ -959,7 +959,7 @@ void intel_psr_compute_config(struct intel_dp *intel_dp,
int psr_setup_time;
/*
- * Current PSR panels dont work reliably with VRR enabled
+ * Current PSR panels don't work reliably with VRR enabled
* So if VRR is enabled, do not enable PSR.
*/
if (crtc_state->vrr.enable)
@@ -1664,7 +1664,7 @@ static void intel_psr2_sel_fetch_pipe_alignment(const struct intel_crtc_state *c
*
* Plane scaling and rotation is not supported by selective fetch and both
* properties can change without a modeset, so need to be check at every
- * atomic commmit.
+ * atomic commit.
*/
static bool psr2_sel_fetch_plane_state_supported(const struct intel_plane_state *plane_state)
{
@@ -2203,7 +2203,7 @@ static void _psr_invalidate_handle(struct intel_dp *intel_dp)
}
/**
- * intel_psr_invalidate - Invalidade PSR
+ * intel_psr_invalidate - Invalidate PSR
* @dev_priv: i915 device
* @frontbuffer_bits: frontbuffer plane tracking bits
* @origin: which operation caused the invalidate
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: clean up comments
2022-07-01 20:32 [Intel-gfx] [PATCH] drm/i915/display: clean up comments Tom Rix
@ 2022-07-01 21:25 ` Patchwork
2022-07-01 23:52 ` [Intel-gfx] [PATCH] " Matt Roper
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2022-07-01 21:25 UTC (permalink / raw)
To: Tom Rix; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 12469 bytes --]
== Series Details ==
Series: drm/i915/display: clean up comments
URL : https://patchwork.freedesktop.org/series/105877/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11841 -> Patchwork_105877v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_105877v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_105877v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/index.html
Participating hosts (41 -> 41)
------------------------------
Additional (3): fi-hsw-4770 bat-dg2-9 bat-jsl-1
Missing (3): fi-bsw-kefka fi-tgl-dsi fi-tgl-u2
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_105877v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@basic-rte:
- fi-cfl-8109u: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11841/fi-cfl-8109u/igt@i915_pm_rpm@basic-rte.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-cfl-8109u/igt@i915_pm_rpm@basic-rte.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@coherency:
- {bat-adln-1}: NOTRUN -> [DMESG-FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/bat-adln-1/igt@i915_selftest@live@coherency.html
Known issues
------------
Here are the changes found in Patchwork_105877v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-rkl-11600: NOTRUN -> [FAIL][4] ([fdo#103375])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_lmem_swapping@basic:
- fi-bdw-gvtdvm: NOTRUN -> [SKIP][5] ([fdo#109271]) +31 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-bdw-gvtdvm/igt@gem_lmem_swapping@basic.html
* igt@gem_softpin@allocator-basic-reserve:
- fi-hsw-4770: NOTRUN -> [SKIP][6] ([fdo#109271]) +9 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-hsw-4770/igt@gem_softpin@allocator-basic-reserve.html
* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#3012])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-hsw-4770/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][8] -> [INCOMPLETE][9] ([i915#5847])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11841/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-bsw-nick/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gem:
- fi-blb-e6850: NOTRUN -> [DMESG-FAIL][10] ([i915#4528])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-blb-e6850/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [PASS][11] -> [DMESG-FAIL][12] ([i915#4494] / [i915#4957])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11841/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-bdw-gvtdvm: NOTRUN -> [INCOMPLETE][13] ([i915#4817])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-bdw-gvtdvm/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-icl-u2: NOTRUN -> [SKIP][14] ([i915#5903])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-icl-u2/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_busy@basic@flip:
- bat-adlp-4: [PASS][15] -> [DMESG-WARN][16] ([i915#3576]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11841/bat-adlp-4/igt@kms_busy@basic@flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/bat-adlp-4/igt@kms_busy@basic@flip.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-rkl-11600: NOTRUN -> [SKIP][17] ([fdo#111827])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-rkl-11600/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-icl-u2: NOTRUN -> [SKIP][18] ([fdo#111827])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- fi-hsw-4770: NOTRUN -> [SKIP][19] ([fdo#109271] / [fdo#111827]) +8 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-hsw-4770/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-bdw-gvtdvm: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +7 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-bdw-gvtdvm/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_psr@sprite_plane_onoff:
- fi-hsw-4770: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#1072]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html
* igt@runner@aborted:
- fi-bsw-nick: NOTRUN -> [FAIL][22] ([fdo#109271] / [i915#3428] / [i915#4312])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-bsw-nick/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_parallel@engines@fds:
- fi-bdw-gvtdvm: [INCOMPLETE][23] -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11841/fi-bdw-gvtdvm/igt@gem_exec_parallel@engines@fds.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-bdw-gvtdvm/igt@gem_exec_parallel@engines@fds.html
* igt@i915_module_load@reload:
- {bat-adln-1}: [DMESG-WARN][25] ([i915#6297]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11841/bat-adln-1/igt@i915_module_load@reload.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/bat-adln-1/igt@i915_module_load@reload.html
* igt@i915_selftest@live@gt_mocs:
- fi-icl-u2: [INCOMPLETE][27] ([i915#4890]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11841/fi-icl-u2/igt@i915_selftest@live@gt_mocs.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-icl-u2/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [DMESG-FAIL][29] ([i915#4494] / [i915#4957]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11841/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-blb-e6850: [DMESG-FAIL][31] ([i915#4528]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11841/fi-blb-e6850/igt@i915_selftest@live@requests.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-blb-e6850/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [INCOMPLETE][33] ([i915#5982]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11841/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_busy@basic@flip:
- {bat-adlp-6}: [DMESG-WARN][35] ([i915#3576]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11841/bat-adlp-6/igt@kms_busy@basic@flip.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/bat-adlp-6/igt@kms_busy@basic@flip.html
* igt@kms_busy@basic@modeset:
- bat-adlp-4: [DMESG-WARN][37] ([i915#3576]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11841/bat-adlp-4/igt@kms_busy@basic@modeset.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/bat-adlp-4/igt@kms_busy@basic@modeset.html
- {bat-adln-1}: [DMESG-WARN][39] ([i915#3576]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11841/bat-adln-1/igt@kms_busy@basic@modeset.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/bat-adln-1/igt@kms_busy@basic@modeset.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4890]: https://gitlab.freedesktop.org/drm/intel/issues/4890
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#5847]: https://gitlab.freedesktop.org/drm/intel/issues/5847
[i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6297]: https://gitlab.freedesktop.org/drm/intel/issues/6297
Build changes
-------------
* Linux: CI_DRM_11841 -> Patchwork_105877v1
CI-20190529: 20190529
CI_DRM_11841: 5ad538f9740c12845ca64cdf7148c2b3e6d993e9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6554: 2824470eeed46d448ccc8111f96736da3abe66b5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105877v1: 5ad538f9740c12845ca64cdf7148c2b3e6d993e9 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
721df48bd4bb drm/i915/display: clean up comments
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105877v1/index.html
[-- Attachment #2: Type: text/html, Size: 13138 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: clean up comments
2022-07-01 20:32 [Intel-gfx] [PATCH] drm/i915/display: clean up comments Tom Rix
2022-07-01 21:25 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2022-07-01 23:52 ` Matt Roper
1 sibling, 0 replies; 3+ messages in thread
From: Matt Roper @ 2022-07-01 23:52 UTC (permalink / raw)
To: Tom Rix; +Cc: dri-devel, airlied, intel-gfx, linux-kernel, rodrigo.vivi
On Fri, Jul 01, 2022 at 04:32:36PM -0400, Tom Rix wrote:
> spelling changes
> resoluition -> resolution
> dont -> don't
> commmit -> commit
> Invalidade -> Invalidate
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
and applied to drm-intel-next. Thanks for the patch.
Matt
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 7d61c55184e5..e6a870641cd2 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -555,7 +555,7 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)
> /*
> * TODO: 7 lines of IO_BUFFER_WAKE and FAST_WAKE are default
> * values from BSpec. In order to setting an optimal power
> - * consumption, lower than 4k resoluition mode needs to decrese
> + * consumption, lower than 4k resolution mode needs to decrease
> * IO_BUFFER_WAKE and FAST_WAKE. And higher than 4K resolution
> * mode needs to increase IO_BUFFER_WAKE and FAST_WAKE.
> */
> @@ -959,7 +959,7 @@ void intel_psr_compute_config(struct intel_dp *intel_dp,
> int psr_setup_time;
>
> /*
> - * Current PSR panels dont work reliably with VRR enabled
> + * Current PSR panels don't work reliably with VRR enabled
> * So if VRR is enabled, do not enable PSR.
> */
> if (crtc_state->vrr.enable)
> @@ -1664,7 +1664,7 @@ static void intel_psr2_sel_fetch_pipe_alignment(const struct intel_crtc_state *c
> *
> * Plane scaling and rotation is not supported by selective fetch and both
> * properties can change without a modeset, so need to be check at every
> - * atomic commmit.
> + * atomic commit.
> */
> static bool psr2_sel_fetch_plane_state_supported(const struct intel_plane_state *plane_state)
> {
> @@ -2203,7 +2203,7 @@ static void _psr_invalidate_handle(struct intel_dp *intel_dp)
> }
>
> /**
> - * intel_psr_invalidate - Invalidade PSR
> + * intel_psr_invalidate - Invalidate PSR
> * @dev_priv: i915 device
> * @frontbuffer_bits: frontbuffer plane tracking bits
> * @origin: which operation caused the invalidate
> --
> 2.27.0
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-01 23:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-01 20:32 [Intel-gfx] [PATCH] drm/i915/display: clean up comments Tom Rix
2022-07-01 21:25 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-07-01 23:52 ` [Intel-gfx] [PATCH] " Matt Roper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox