* [Intel-gfx] [PATCH i-g-t] tests/i915/gem_create: use 48b addressing
@ 2022-07-15 11:19 Matthew Auld
2022-07-18 7:17 ` Zbigniew Kempczyński
2022-07-18 9:04 ` Das, Nirmoy
0 siblings, 2 replies; 3+ messages in thread
From: Matthew Auld @ 2022-07-15 11:19 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx
The object here could be very large (8G+), so make sure we allow using
the entire address space, to avoid sometimes hitting -ENOSPC.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6446
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
---
tests/i915/gem_create.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
index 1b694c6a..ff022713 100644
--- a/tests/i915/gem_create.c
+++ b/tests/i915/gem_create.c
@@ -538,7 +538,9 @@ static int upload(int fd, uint32_t handle)
* for sure placed in one of requested regions.
*/
exec[0].handle = handle;
+ exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
exec[1].handle = batch_create_size(fd, PAGE_SIZE);
+ exec[1].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
return __gem_execbuf(fd, &execbuf);
}
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] tests/i915/gem_create: use 48b addressing
2022-07-15 11:19 [Intel-gfx] [PATCH i-g-t] tests/i915/gem_create: use 48b addressing Matthew Auld
@ 2022-07-18 7:17 ` Zbigniew Kempczyński
2022-07-18 9:04 ` Das, Nirmoy
1 sibling, 0 replies; 3+ messages in thread
From: Zbigniew Kempczyński @ 2022-07-18 7:17 UTC (permalink / raw)
To: Matthew Auld; +Cc: igt-dev, intel-gfx
On Fri, Jul 15, 2022 at 12:19:37PM +0100, Matthew Auld wrote:
> The object here could be very large (8G+), so make sure we allow using
> the entire address space, to avoid sometimes hitting -ENOSPC.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6446
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
Yes, on DG1 we've often never entered > 32b offsets.
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
> ---
> tests/i915/gem_create.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
> index 1b694c6a..ff022713 100644
> --- a/tests/i915/gem_create.c
> +++ b/tests/i915/gem_create.c
> @@ -538,7 +538,9 @@ static int upload(int fd, uint32_t handle)
> * for sure placed in one of requested regions.
> */
> exec[0].handle = handle;
> + exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> exec[1].handle = batch_create_size(fd, PAGE_SIZE);
> + exec[1].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
>
> return __gem_execbuf(fd, &execbuf);
> }
> --
> 2.36.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] tests/i915/gem_create: use 48b addressing
2022-07-15 11:19 [Intel-gfx] [PATCH i-g-t] tests/i915/gem_create: use 48b addressing Matthew Auld
2022-07-18 7:17 ` Zbigniew Kempczyński
@ 2022-07-18 9:04 ` Das, Nirmoy
1 sibling, 0 replies; 3+ messages in thread
From: Das, Nirmoy @ 2022-07-18 9:04 UTC (permalink / raw)
To: Matthew Auld, igt-dev; +Cc: intel-gfx
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
On 7/15/2022 1:19 PM, Matthew Auld wrote:
> The object here could be very large (8G+), so make sure we allow using
> the entire address space, to avoid sometimes hitting -ENOSPC.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6446
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
> ---
> tests/i915/gem_create.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
> index 1b694c6a..ff022713 100644
> --- a/tests/i915/gem_create.c
> +++ b/tests/i915/gem_create.c
> @@ -538,7 +538,9 @@ static int upload(int fd, uint32_t handle)
> * for sure placed in one of requested regions.
> */
> exec[0].handle = handle;
> + exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> exec[1].handle = batch_create_size(fd, PAGE_SIZE);
> + exec[1].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
>
> return __gem_execbuf(fd, &execbuf);
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-18 9:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-15 11:19 [Intel-gfx] [PATCH i-g-t] tests/i915/gem_create: use 48b addressing Matthew Auld
2022-07-18 7:17 ` Zbigniew Kempczyński
2022-07-18 9:04 ` Das, Nirmoy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox