Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tomas Winkler <tomas.winkler@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org,
	Alexander Usyskin <alexander.usyskin@intel.com>,
	linux-kernel@vger.kernel.org,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tomas Winkler <tomas.winkler@intel.com>,
	Vitaly Lubart <vitaly.lubart@intel.com>
Subject: [Intel-gfx] [PATCH v7 09/15] mei: bus: export common mkhi definitions into a separate header
Date: Sat,  6 Aug 2022 15:26:30 +0300	[thread overview]
Message-ID: <20220806122636.43068-10-tomas.winkler@intel.com> (raw)
In-Reply-To: <20220806122636.43068-1-tomas.winkler@intel.com>

From: Vitaly Lubart <vitaly.lubart@intel.com>

Exported common mkhi definitions from bus-fixup.c into a separate
header file mkhi.h for other driver usage.

Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/bus-fixup.c | 31 +------------------------
 drivers/misc/mei/mkhi.h      | 45 ++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 30 deletions(-)
 create mode 100644 drivers/misc/mei/mkhi.h

diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c
index 24e91a9ea558..811c94ebf250 100644
--- a/drivers/misc/mei/bus-fixup.c
+++ b/drivers/misc/mei/bus-fixup.c
@@ -15,6 +15,7 @@
 
 #include "mei_dev.h"
 #include "client.h"
+#include "mkhi.h"
 
 #define MEI_UUID_NFC_INFO UUID_LE(0xd2de1625, 0x382d, 0x417d, \
 			0x48, 0xa4, 0xef, 0xab, 0xba, 0x8a, 0x12, 0x06)
@@ -89,20 +90,6 @@ struct mei_os_ver {
 	u8  reserved2;
 } __packed;
 
-#define MKHI_FEATURE_PTT 0x10
-
-struct mkhi_rule_id {
-	__le16 rule_type;
-	u8 feature_id;
-	u8 reserved;
-} __packed;
-
-struct mkhi_fwcaps {
-	struct mkhi_rule_id id;
-	u8 len;
-	u8 data[];
-} __packed;
-
 struct mkhi_fw_ver_block {
 	u16 minor;
 	u8 major;
@@ -115,22 +102,6 @@ struct mkhi_fw_ver {
 	struct mkhi_fw_ver_block ver[MEI_MAX_FW_VER_BLOCKS];
 } __packed;
 
-#define MKHI_FWCAPS_GROUP_ID 0x3
-#define MKHI_FWCAPS_SET_OS_VER_APP_RULE_CMD 6
-#define MKHI_GEN_GROUP_ID 0xFF
-#define MKHI_GEN_GET_FW_VERSION_CMD 0x2
-struct mkhi_msg_hdr {
-	u8  group_id;
-	u8  command;
-	u8  reserved;
-	u8  result;
-} __packed;
-
-struct mkhi_msg {
-	struct mkhi_msg_hdr hdr;
-	u8 data[];
-} __packed;
-
 #define MKHI_OSVER_BUF_LEN (sizeof(struct mkhi_msg_hdr) + \
 			    sizeof(struct mkhi_fwcaps) + \
 			    sizeof(struct mei_os_ver))
diff --git a/drivers/misc/mei/mkhi.h b/drivers/misc/mei/mkhi.h
new file mode 100644
index 000000000000..27a9b476904e
--- /dev/null
+++ b/drivers/misc/mei/mkhi.h
@@ -0,0 +1,45 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2003-2020, Intel Corporation. All rights reserved.
+ * Intel Management Engine Interface (Intel MEI) Linux driver
+ */
+
+#ifndef _MEI_MKHI_H_
+#define _MEI_MKHI_H_
+
+#include "mei_dev.h"
+
+#define MKHI_FEATURE_PTT 0x10
+
+#define MKHI_FWCAPS_GROUP_ID 0x3
+#define MKHI_FWCAPS_SET_OS_VER_APP_RULE_CMD 6
+#define MKHI_GEN_GROUP_ID 0xFF
+#define MKHI_GEN_GET_FW_VERSION_CMD 0x2
+
+#define MCHI_GROUP_ID  0xA
+
+struct mkhi_rule_id {
+	__le16 rule_type;
+	u8 feature_id;
+	u8 reserved;
+} __packed;
+
+struct mkhi_fwcaps {
+	struct mkhi_rule_id id;
+	u8 len;
+	u8 data[];
+} __packed;
+
+struct mkhi_msg_hdr {
+	u8  group_id;
+	u8  command;
+	u8  reserved;
+	u8  result;
+} __packed;
+
+struct mkhi_msg {
+	struct mkhi_msg_hdr hdr;
+	u8 data[];
+} __packed;
+
+#endif /* _MEI_MKHI_H_ */
-- 
2.37.1


  parent reply	other threads:[~2022-08-06 12:34 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-06 12:26 [Intel-gfx] [PATCH v7 00/15] GSC support for XeHP SDV and DG2 Tomas Winkler
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 01/15] drm/i915/gsc: skip irq initialization if using polling Tomas Winkler
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 02/15] mei: add kdoc for struct mei_aux_device Tomas Winkler
2022-09-01 15:30   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 03/15] mei: add slow_firmware flag to the mei auxiliary device Tomas Winkler
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 04/15] drm/i915/gsc: add slow_firmware flag to the gsc device definition Tomas Winkler
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 05/15] drm/i915/gsc: add GSC XeHP SDV platform definition Tomas Winkler
2022-09-01 15:31   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 06/15] mei: gsc: use polling instead of interrupts Tomas Winkler
2022-09-01 16:00   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 07/15] mei: gsc: wait for reset thread on stop Tomas Winkler
2022-09-01 16:07   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 08/15] mei: extend timeouts on slow devices Tomas Winkler
2022-09-01 17:00   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` Tomas Winkler [this message]
2022-09-01 20:54   ` [Intel-gfx] [PATCH v7 09/15] mei: bus: export common mkhi definitions into a separate header Ceraolo Spurio, Daniele
2022-09-03 10:05     ` Winkler, Tomas
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 10/15] mei: mkhi: add memory ready command Tomas Winkler
2022-09-01 15:08   ` Greg Kroah-Hartman
2022-09-01 20:56   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 11/15] mei: gsc: setup gsc extended operational memory Tomas Winkler
2022-09-01 21:02   ` Ceraolo Spurio, Daniele
2022-09-04  7:29     ` Usyskin, Alexander
2022-09-04 22:26       ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 12/15] mei: gsc: add transition to PXP mode in resume flow Tomas Winkler
2022-09-01 21:19   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 13/15] mei: debugfs: add pxp mode to devstate in debugfs Tomas Winkler
2022-09-01 21:20   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 14/15] drm/i915/gsc: allocate extended operational memory in LMEM Tomas Winkler
2022-09-01 16:31   ` Teres Alexis, Alan Previn
2022-09-02  8:25   ` Matthew Auld
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 15/15] HAX: drm/i915: force INTEL_MEI_GSC on for CI Tomas Winkler
2022-08-06 12:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GSC support for XeHP SDV and DG2 (rev2) Patchwork
2022-08-06 12:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-08-06 13:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-06 14:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-01 15:09 ` [Intel-gfx] [PATCH v7 00/15] GSC support for XeHP SDV and DG2 Greg Kroah-Hartman
2022-09-09 10:24   ` Joonas Lahtinen
2022-09-09 15:17     ` Ceraolo Spurio, Daniele
2022-09-09 16:33       ` Vivi, Rodrigo
2022-09-09 17:16         ` Lucas De Marchi
2022-09-12 12:51         ` Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220806122636.43068-10-tomas.winkler@intel.com \
    --to=tomas.winkler@intel.com \
    --cc=airlied@linux.ie \
    --cc=alexander.usyskin@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=vitaly.lubart@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox