Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tomas Winkler <tomas.winkler@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org,
	Alexander Usyskin <alexander.usyskin@intel.com>,
	linux-kernel@vger.kernel.org,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tomas Winkler <tomas.winkler@intel.com>,
	Vitaly Lubart <vitaly.lubart@intel.com>
Subject: [Intel-gfx] [PATCH v7 13/15] mei: debugfs: add pxp mode to devstate in debugfs
Date: Sat,  6 Aug 2022 15:26:34 +0300	[thread overview]
Message-ID: <20220806122636.43068-14-tomas.winkler@intel.com> (raw)
In-Reply-To: <20220806122636.43068-1-tomas.winkler@intel.com>

Add pxp mode devstate to debugfs to monitor pxp state machine progress.
This is useful to debug issues in scenarios in which the pxp state
needs to be re-initialized, like during power transitions such as
suspend/resume. With this debugfs the state could be monitored
to ensure that pxp is in the ready state.

CC: Vitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/debugfs.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c
index 1ce61e9e24fc..4074fec866a6 100644
--- a/drivers/misc/mei/debugfs.c
+++ b/drivers/misc/mei/debugfs.c
@@ -86,6 +86,20 @@ static int mei_dbgfs_active_show(struct seq_file *m, void *unused)
 }
 DEFINE_SHOW_ATTRIBUTE(mei_dbgfs_active);
 
+static const char *mei_dev_pxp_mode_str(enum mei_dev_pxp_mode state)
+{
+#define MEI_PXP_MODE(state) case MEI_DEV_PXP_##state: return #state
+	switch (state) {
+	MEI_PXP_MODE(DEFAULT);
+	MEI_PXP_MODE(INIT);
+	MEI_PXP_MODE(SETUP);
+	MEI_PXP_MODE(READY);
+	default:
+		return "unknown";
+	}
+#undef MEI_PXP_MODE
+}
+
 static int mei_dbgfs_devstate_show(struct seq_file *m, void *unused)
 {
 	struct mei_device *dev = m->private;
@@ -112,6 +126,9 @@ static int mei_dbgfs_devstate_show(struct seq_file *m, void *unused)
 	seq_printf(m, "pg:  %s, %s\n",
 		   mei_pg_is_enabled(dev) ? "ENABLED" : "DISABLED",
 		   mei_pg_state_str(mei_pg_state(dev)));
+
+	seq_printf(m, "pxp: %s\n", mei_dev_pxp_mode_str(dev->pxp_mode));
+
 	return 0;
 }
 DEFINE_SHOW_ATTRIBUTE(mei_dbgfs_devstate);
-- 
2.37.1


  parent reply	other threads:[~2022-08-06 12:34 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-06 12:26 [Intel-gfx] [PATCH v7 00/15] GSC support for XeHP SDV and DG2 Tomas Winkler
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 01/15] drm/i915/gsc: skip irq initialization if using polling Tomas Winkler
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 02/15] mei: add kdoc for struct mei_aux_device Tomas Winkler
2022-09-01 15:30   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 03/15] mei: add slow_firmware flag to the mei auxiliary device Tomas Winkler
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 04/15] drm/i915/gsc: add slow_firmware flag to the gsc device definition Tomas Winkler
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 05/15] drm/i915/gsc: add GSC XeHP SDV platform definition Tomas Winkler
2022-09-01 15:31   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 06/15] mei: gsc: use polling instead of interrupts Tomas Winkler
2022-09-01 16:00   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 07/15] mei: gsc: wait for reset thread on stop Tomas Winkler
2022-09-01 16:07   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 08/15] mei: extend timeouts on slow devices Tomas Winkler
2022-09-01 17:00   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 09/15] mei: bus: export common mkhi definitions into a separate header Tomas Winkler
2022-09-01 20:54   ` Ceraolo Spurio, Daniele
2022-09-03 10:05     ` Winkler, Tomas
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 10/15] mei: mkhi: add memory ready command Tomas Winkler
2022-09-01 15:08   ` Greg Kroah-Hartman
2022-09-01 20:56   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 11/15] mei: gsc: setup gsc extended operational memory Tomas Winkler
2022-09-01 21:02   ` Ceraolo Spurio, Daniele
2022-09-04  7:29     ` Usyskin, Alexander
2022-09-04 22:26       ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 12/15] mei: gsc: add transition to PXP mode in resume flow Tomas Winkler
2022-09-01 21:19   ` Ceraolo Spurio, Daniele
2022-08-06 12:26 ` Tomas Winkler [this message]
2022-09-01 21:20   ` [Intel-gfx] [PATCH v7 13/15] mei: debugfs: add pxp mode to devstate in debugfs Ceraolo Spurio, Daniele
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 14/15] drm/i915/gsc: allocate extended operational memory in LMEM Tomas Winkler
2022-09-01 16:31   ` Teres Alexis, Alan Previn
2022-09-02  8:25   ` Matthew Auld
2022-08-06 12:26 ` [Intel-gfx] [PATCH v7 15/15] HAX: drm/i915: force INTEL_MEI_GSC on for CI Tomas Winkler
2022-08-06 12:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GSC support for XeHP SDV and DG2 (rev2) Patchwork
2022-08-06 12:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-08-06 13:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-06 14:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-01 15:09 ` [Intel-gfx] [PATCH v7 00/15] GSC support for XeHP SDV and DG2 Greg Kroah-Hartman
2022-09-09 10:24   ` Joonas Lahtinen
2022-09-09 15:17     ` Ceraolo Spurio, Daniele
2022-09-09 16:33       ` Vivi, Rodrigo
2022-09-09 17:16         ` Lucas De Marchi
2022-09-12 12:51         ` Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220806122636.43068-14-tomas.winkler@intel.com \
    --to=tomas.winkler@intel.com \
    --cc=airlied@linux.ie \
    --cc=alexander.usyskin@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=vitaly.lubart@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox