Re: [Intel-gfx] [PULL] gvt-fixes

[Zhenyu Wang <zhenyuw@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3284 bytes --]

On 2022.08.18 15:43:32 +0000, Vivi, Rodrigo wrote:
> On Thu, 2022-08-18 at 17:27 +0300, Jani Nikula wrote:
> 
>     On Thu, 18 Aug 2022, Jani Nikula <jani.nikula@intel.com> wrote:
> 
>         On Wed, 17 Aug 2022, "Colin King (gmail)" <colin.i.king@gmail.com>
>         wrote:
> 
>             On 17/08/2022 21:07, Vivi, Rodrigo wrote:
> 
>                 On Tue, 2022-08-16 at 12:43 +0800, Zhenyu Wang wrote:
> 
>                     On 2022.08.16 12:05:08 +0800, Zhenyu Wang wrote:
> 
>                         On 2022.08.15 19:32:45 -0400, Rodrigo Vivi wrote:
> 
>                             On Mon, Aug 15, 2022 at 10:38:55AM +0800, Zhenyu
>                             Wang wrote:
> 
>                     oh, surprise! I just found Colin's email is actually
>                     defined in
>                     .mailmap,
>                     so all his commits in kernel are changed for @intel.com
>                     address as in
>                     mailmap...
> 
> 
>                 Colin, would you mind to get the Sign-off-by in the patches the
>                 same
>                 as your authorship so the tools don't get confused?
>                 (starting with modifying in tree this already merged patch)
> 
> 
>             Since my patches are generally trivial janitorial fixed done in my
>             spare
>             time I'm going to get the .mailmap changed to use my gmail email
>             address
>             rather than my Intel one (since I don't do kernel work in my
>             current role).
> 
>             This should clean up the confusion. Apologies.
> 
> 
>         Everyone hold your horses.
> 
>         I think our tooling should handle the mailmap stuff. The commit *is*
>         fine, it's just that the when we check it, we let mailmap alter it. We
>         should check the commit without mailmap modifications.
> 
> 
>     In this case, it's actually not about Colin's Signed-off-by or mailmap
>     at all! Like the error message from dim says, "committer Signed-off-by
>     missing". Committer, not author!
> 
>     $ git show -s tags/gvt-fixes-2022-08-15^ --pretty=fuller
>     commit d6632370536d0b80be3bfc90dd67e1f693335a75
>     Author:     Colin Ian King <colin.king@intel.com>
>     AuthorDate: Tue Mar 15 20:24:49 2022 +0000
>     Commit:     Zhenyu Wang <zhenyuw@linux.intel.com>
>     CommitDate: Mon Aug 15 10:51:15 2022 +0800
> 
>         drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"
>        
>         There is a spelling mistake in a gvt_vgpu_err error message. Fix it.
>        
>         Fixes: 695fbc08d80f ("drm/i915/gvt: replace the gvt_err with
>     gvt_vgpu_err")
>         Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>         Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
>         Link: http://patchwork.freedesktop.org/patch/msgid/
>     20220315202449.2952845-1-colin.i.king@gmail.com
>         Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>
> 
>     Committed by Zhenyu, Signed-off-by Zhi. Maybe caused by rebase by Zhenyu
>     after being committed by Zhi?
> 
> 
> Probably easier if you could rebase it again signing it then?
>

Oops, sorry about that, will re-send.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]