public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 3/8] drm/i915: Use managed allocations for extra uncore objects
Date: Mon, 29 Aug 2022 10:02:33 -0700	[thread overview]
Message-ID: <20220829170238.969875-4-matthew.d.roper@intel.com> (raw)
In-Reply-To: <20220829170238.969875-1-matthew.d.roper@intel.com>

We're slowly transitioning the init-time kzalloc's of the driver over to
DRM-managed allocations; let's make sure the uncore objects allocated
for non-root GTs are thus allocated.

Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_gt.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
index a82b5e2e0d83..cf7aab7adb30 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt.c
@@ -783,7 +783,7 @@ static int intel_gt_tile_setup(struct intel_gt *gt, phys_addr_t phys_addr)
 	if (!gt_is_root(gt)) {
 		struct intel_uncore *uncore;
 
-		uncore = kzalloc(sizeof(*uncore), GFP_KERNEL);
+		uncore = drmm_kzalloc(&gt->i915->drm, sizeof(*uncore), GFP_KERNEL);
 		if (!uncore)
 			return -ENOMEM;
 
@@ -808,10 +808,8 @@ intel_gt_tile_cleanup(struct intel_gt *gt)
 {
 	intel_uncore_cleanup_mmio(gt->uncore);
 
-	if (!gt_is_root(gt)) {
-		kfree(gt->uncore);
+	if (!gt_is_root(gt))
 		kfree(gt);
-	}
 }
 
 int intel_gt_probe_all(struct drm_i915_private *i915)
-- 
2.37.2


  parent reply	other threads:[~2022-08-29 17:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29 17:02 [Intel-gfx] [PATCH 0/8] i915: Add "standalone media" support for MTL Matt Roper
2022-08-29 17:02 ` [Intel-gfx] [PATCH 1/8] drm/i915: Move locking and unclaimed check into mmio_debug_{suspend, resume} Matt Roper
2022-08-30 22:49   ` Sripada, Radhakrishna
2022-08-29 17:02 ` [Intel-gfx] [PATCH 2/8] drm/i915: Only hook up uncore->debug for primary uncore Matt Roper
2022-08-31  0:01   ` Sripada, Radhakrishna
2022-08-29 17:02 ` Matt Roper [this message]
2022-08-31  0:03   ` [Intel-gfx] [PATCH 3/8] drm/i915: Use managed allocations for extra uncore objects Sripada, Radhakrishna
2022-08-29 17:02 ` [Intel-gfx] [PATCH 4/8] drm/i915: Prepare more multi-GT initialization Matt Roper
2022-08-29 20:46   ` [Intel-gfx] [PATCH v2 " Matt Roper
2022-08-31  0:27   ` [Intel-gfx] [PATCH " Sripada, Radhakrishna
2022-08-29 17:02 ` [Intel-gfx] [PATCH 5/8] drm/i915: Rename and expose common GT early init routine Matt Roper
2022-08-31  0:33   ` Sripada, Radhakrishna
2022-08-29 17:02 ` [Intel-gfx] [PATCH 6/8] drm/i915/xelpmp: Expose media as another GT Matt Roper
2022-09-01 23:31   ` Ceraolo Spurio, Daniele
2022-08-29 17:02 ` [Intel-gfx] [PATCH 7/8] drm/i915/mtl: Use primary GT's irq lock for media GT Matt Roper
2022-09-01 23:39   ` Ceraolo Spurio, Daniele
2022-08-29 17:02 ` [Intel-gfx] [PATCH 8/8] drm/i915/mtl: Hook up interrupts for standalone media Matt Roper
2022-09-01 23:42   ` Ceraolo Spurio, Daniele
2022-08-29 20:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Add "standalone media" support for MTL Patchwork
2022-08-29 20:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-08-29 21:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Add "standalone media" support for MTL (rev2) Patchwork
2022-08-29 21:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-31 10:17 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220829170238.969875-4-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox