From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v1 1/1] drm/i915: Skip applying copy engine fuses
Date: Mon, 12 Sep 2022 09:19:38 -0700 [thread overview]
Message-ID: <20220912-copy-engine-v1-1-ef92fd81758d@intel.com> (raw)
In-Reply-To: <20220912-copy-engine-v1-0-ef92fd81758d@intel.com>
Support for reading the fuses to check what are the Link Copy engines
was added in commit ad5f74f34201 ("drm/i915/pvc: read fuses for link
copy engines"). However they were added unconditionally because the
FUSE3 register is present since graphics version 10.
However the bitfield with meml3 fuses only exists since graphics version
12. Moreover, Link Copy engines are currently only available in PVC.
Tying additional copy engines to the meml3 fuses is not correct for
other platforms.
Make sure there is a check for `12.60 <= ver < 12.70`. Later platforms
may extend this function later if it's needed to fuse off copy engines.
Currently it's harmless as the Link Copy engines are still not exported:
info->engine_mask only has BCS0 set and the register is only read for
platforms that do have it.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
index 814f83b5fe59..1f7188129cd1 100644
--- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
@@ -764,6 +764,10 @@ static void engine_mask_apply_copy_fuses(struct intel_gt *gt)
unsigned long meml3_mask;
unsigned long quad;
+ if (!(GRAPHICS_VER_FULL(i915) >= IP_VER(12, 60) &&
+ GRAPHICS_VER_FULL(i915) < IP_VER(12, 70)))
+ return;
+
meml3_mask = intel_uncore_read(gt->uncore, GEN10_MIRROR_FUSE3);
meml3_mask = REG_FIELD_GET(GEN12_MEML3_EN_MASK, meml3_mask);
--
b4 0.10.0-dev-df873
next prev parent reply other threads:[~2022-09-12 16:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 16:19 [Intel-gfx] [PATCH v1 0/1] drm/i915: Copy engine fuses future-proofing Lucas De Marchi
2022-09-12 16:19 ` Lucas De Marchi [this message]
2022-09-12 16:59 ` [Intel-gfx] [PATCH v1 1/1] drm/i915: Skip applying copy engine fuses Andi Shyti
2022-09-12 18:12 ` Lucas De Marchi
2022-09-12 20:12 ` Andi Shyti
2022-09-12 21:11 ` Lucas De Marchi
2022-09-12 18:53 ` Andrzej Hajda
2022-09-13 1:03 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Copy engine fuses future-proofing Patchwork
2022-09-13 9:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Copy engine fuses future-proofing (rev2) Patchwork
2022-09-13 18:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220912-copy-engine-v1-1-ef92fd81758d@intel.com \
--to=lucas.demarchi@intel.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox