Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook
@ 2022-09-13 20:55 Nathan Huckleberry
  2022-09-13 23:19 ` Nathan Chancellor
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Nathan Huckleberry @ 2022-09-13 20:55 UTC (permalink / raw)
  Cc: Lucas De Marchi, llvm, Dan Carpenter, David Airlie, Tom Rix,
	intel-gfx, Nick Desaulniers, linux-kernel, Nathan Huckleberry,
	Nathan Chancellor, dri-devel, Daniel Vetter, Rodrigo Vivi

All of the functions used for intel_dvo_dev_ops.mode_valid have a return
type of enum drm_mode_status, but the mode_valid field in the struct
definition has a return type of int.

The mismatched return type breaks forward edge kCFI since the underlying
function definitions do not match the function hook definition.

The return type of the mode_valid field should be changed from int to
enum drm_mode_status.

Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
 drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
index d96c3cc46e50..50205f064d93 100644
--- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
+++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
@@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
 	 *
 	 * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
 	 */
-	int (*mode_valid)(struct intel_dvo_device *dvo,
-			  struct drm_display_mode *mode);
+	enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
+					   struct drm_display_mode *mode);
 
 	/*
 	 * Callback for preparing mode changes on an output
-- 
2.37.2.789.g6183377224-goog


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-09-19 13:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-13 20:55 [Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook Nathan Huckleberry
2022-09-13 23:19 ` Nathan Chancellor
2022-09-15  7:39   ` Jani Nikula
2022-09-14 10:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-09-14 13:47 ` [Intel-gfx] [PATCH] " Andrzej Hajda
2022-09-15  1:31 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox