From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 1/3] drm/i915: Nuke stale plane cdclk ratio FIXMEs
Date: Fri, 16 Sep 2022 19:52:04 +0300 [thread overview]
Message-ID: <20220916165206.1499-1-ville.syrjala@linux.intel.com> (raw)
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The plane ratio stuff got implemented in
commit bb6ae9e653dc ("drm/i915: Allow planes to
declare their minimum acceptable cdclk") so these
FIXMEs have no business being here.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_cdclk.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index ed05070b7307..a12e86d92783 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -2464,10 +2464,6 @@ static int bdw_modeset_calc_cdclk(struct intel_cdclk_state *cdclk_state)
if (min_cdclk < 0)
return min_cdclk;
- /*
- * FIXME should also account for plane ratio
- * once 64bpp pixel formats are supported.
- */
cdclk = bdw_calc_cdclk(min_cdclk);
cdclk_state->logical.cdclk = cdclk;
@@ -2534,10 +2530,6 @@ static int skl_modeset_calc_cdclk(struct intel_cdclk_state *cdclk_state)
vco = skl_dpll0_vco(cdclk_state);
- /*
- * FIXME should also account for plane ratio
- * once 64bpp pixel formats are supported.
- */
cdclk = skl_calc_cdclk(min_cdclk, vco);
cdclk_state->logical.vco = vco;
--
2.35.1
next reply other threads:[~2022-09-16 16:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 16:52 Ville Syrjala [this message]
2022-09-16 16:52 ` [Intel-gfx] [PATCH 2/3] drm/i915/fbc: Remove stale FIXME Ville Syrjala
2022-09-22 8:15 ` Luca Coelho
2022-09-22 8:31 ` Ville Syrjälä
2022-09-16 16:52 ` [Intel-gfx] [PATCH 3/3] drm/i915: Mark FBC B gone if pipe B is gone Ville Syrjala
2022-09-22 8:18 ` Luca Coelho
2022-09-22 8:29 ` Ville Syrjälä
2022-09-22 8:51 ` Jani Nikula
2022-09-22 9:36 ` Ville Syrjälä
2022-09-22 9:43 ` Ville Syrjälä
2022-09-22 9:57 ` Jani Nikula
2022-09-22 11:37 ` Luca Coelho
2022-09-22 11:57 ` Ville Syrjälä
2022-09-23 6:24 ` Luca Coelho
2022-09-23 7:46 ` Ville Syrjälä
2022-09-26 10:11 ` Luca Coelho
2022-09-22 9:46 ` Luca Coelho
2022-09-16 18:40 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: Nuke stale plane cdclk ratio FIXMEs Patchwork
2022-09-16 18:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-16 23:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-22 8:14 ` [Intel-gfx] [PATCH 1/3] " Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220916165206.1499-1-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox