From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 2/3] drm/i915/fbc: Remove stale FIXME
Date: Fri, 16 Sep 2022 19:52:05 +0300 [thread overview]
Message-ID: <20220916165206.1499-2-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20220916165206.1499-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Remove the old tales about 90/270 degree rotation
effectively preventing FBC. That hasn't been true since
we stopped demanding the fence is present in
commit 691f7ba58d52 ("drm/i915/display/fbc: Make fences
a nice-to-have for GEN9+")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_fbc.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index f38175304928..e97083ea1059 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -1009,7 +1009,8 @@ static bool intel_fbc_is_fence_ok(const struct intel_plane_state *plane_state)
{
struct drm_i915_private *i915 = to_i915(plane_state->uapi.plane->dev);
- /* The use of a CPU fence is one of two ways to detect writes by the
+ /*
+ * The use of a CPU fence is one of two ways to detect writes by the
* CPU to the scanout and trigger updates to the FBC.
*
* The other method is by software tracking (see
@@ -1019,12 +1020,6 @@ static bool intel_fbc_is_fence_ok(const struct intel_plane_state *plane_state)
* Note that is possible for a tiled surface to be unmappable (and
* so have no fence associated with it) due to aperture constraints
* at the time of pinning.
- *
- * FIXME with 90/270 degree rotation we should use the fence on
- * the normal GTT view (the rotated view doesn't even have a
- * fence). Would need changes to the FBC fence Y offset as well.
- * For now this will effectively disable FBC with 90/270 degree
- * rotation.
*/
return DISPLAY_VER(i915) >= 9 ||
(plane_state->flags & PLANE_HAS_FENCE &&
--
2.35.1
next prev parent reply other threads:[~2022-09-16 16:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 16:52 [Intel-gfx] [PATCH 1/3] drm/i915: Nuke stale plane cdclk ratio FIXMEs Ville Syrjala
2022-09-16 16:52 ` Ville Syrjala [this message]
2022-09-22 8:15 ` [Intel-gfx] [PATCH 2/3] drm/i915/fbc: Remove stale FIXME Luca Coelho
2022-09-22 8:31 ` Ville Syrjälä
2022-09-16 16:52 ` [Intel-gfx] [PATCH 3/3] drm/i915: Mark FBC B gone if pipe B is gone Ville Syrjala
2022-09-22 8:18 ` Luca Coelho
2022-09-22 8:29 ` Ville Syrjälä
2022-09-22 8:51 ` Jani Nikula
2022-09-22 9:36 ` Ville Syrjälä
2022-09-22 9:43 ` Ville Syrjälä
2022-09-22 9:57 ` Jani Nikula
2022-09-22 11:37 ` Luca Coelho
2022-09-22 11:57 ` Ville Syrjälä
2022-09-23 6:24 ` Luca Coelho
2022-09-23 7:46 ` Ville Syrjälä
2022-09-26 10:11 ` Luca Coelho
2022-09-22 9:46 ` Luca Coelho
2022-09-16 18:40 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: Nuke stale plane cdclk ratio FIXMEs Patchwork
2022-09-16 18:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-16 23:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-22 8:14 ` [Intel-gfx] [PATCH 1/3] " Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220916165206.1499-2-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox