From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Christian König" <christian.koenig@amd.com>,
dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] drm/ttm: move bo->resource check in vm_access
Date: Fri, 30 Sep 2022 16:39:57 +0100 [thread overview]
Message-ID: <20220930153957.416938-1-matthew.auld@intel.com> (raw)
Touching bo->resource looks like it should require first locking the
object, since this state is dynamic and could potentially change from
under us.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/ttm/ttm_bo_vm.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c
index 38119311284d..8a0de14d8c85 100644
--- a/drivers/gpu/drm/ttm/ttm_bo_vm.c
+++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c
@@ -412,13 +412,15 @@ int ttm_bo_vm_access(struct vm_area_struct *vma, unsigned long addr,
<< PAGE_SHIFT);
int ret;
- if (len < 1 || (offset + len) >> PAGE_SHIFT > bo->resource->num_pages)
- return -EIO;
-
ret = ttm_bo_reserve(bo, true, false, NULL);
if (ret)
return ret;
+ if (len < 1 || (offset + len) >> PAGE_SHIFT > bo->resource->num_pages) {
+ ret = -EIO;
+ goto out_reserve;
+ }
+
switch (bo->resource->mem_type) {
case TTM_PL_SYSTEM:
fallthrough;
@@ -433,6 +435,7 @@ int ttm_bo_vm_access(struct vm_area_struct *vma, unsigned long addr,
ret = -EIO;
}
+out_reserve:
ttm_bo_unreserve(bo);
return ret;
--
2.37.3
next reply other threads:[~2022-09-30 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 15:39 Matthew Auld [this message]
2022-09-30 17:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/ttm: move bo->resource check in vm_access Patchwork
2022-09-30 18:15 ` [Intel-gfx] [PATCH] " Christian König
2022-10-01 14:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930153957.416938-1-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox