Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/ttm: move bo->resource check in vm_access
@ 2022-09-30 15:39 Matthew Auld
  2022-09-30 17:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Matthew Auld @ 2022-09-30 15:39 UTC (permalink / raw)
  To: intel-gfx; +Cc: Christian König, dri-devel

Touching bo->resource looks like it should require first locking the
object, since this state is dynamic and could potentially change from
under us.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/ttm/ttm_bo_vm.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c
index 38119311284d..8a0de14d8c85 100644
--- a/drivers/gpu/drm/ttm/ttm_bo_vm.c
+++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c
@@ -412,13 +412,15 @@ int ttm_bo_vm_access(struct vm_area_struct *vma, unsigned long addr,
 		 << PAGE_SHIFT);
 	int ret;
 
-	if (len < 1 || (offset + len) >> PAGE_SHIFT > bo->resource->num_pages)
-		return -EIO;
-
 	ret = ttm_bo_reserve(bo, true, false, NULL);
 	if (ret)
 		return ret;
 
+	if (len < 1 || (offset + len) >> PAGE_SHIFT > bo->resource->num_pages) {
+		ret = -EIO;
+		goto out_reserve;
+	}
+
 	switch (bo->resource->mem_type) {
 	case TTM_PL_SYSTEM:
 		fallthrough;
@@ -433,6 +435,7 @@ int ttm_bo_vm_access(struct vm_area_struct *vma, unsigned long addr,
 			ret = -EIO;
 	}
 
+out_reserve:
 	ttm_bo_unreserve(bo);
 
 	return ret;
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-01 14:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-30 15:39 [Intel-gfx] [PATCH] drm/ttm: move bo->resource check in vm_access Matthew Auld
2022-09-30 17:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-09-30 18:15 ` [Intel-gfx] [PATCH] " Christian König
2022-10-01 14:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox