Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/edid/firmware: stop using throwaway platform device
@ 2022-10-06 22:21 Jani Nikula
  2022-10-06 23:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 13+ messages in thread
From: Jani Nikula @ 2022-10-06 22:21 UTC (permalink / raw)
  To: dri-devel; +Cc: jani.nikula, intel-gfx, Matthieu CHARETTE

We've used a temporary platform device for firmware EDID loading since
it was introduced in commit da0df92b5731 ("drm: allow loading an EDID as
firmware to override broken monitor"), but there's no explanation why.

Do we need to?

Maybe this fixes the suspend/resume issue?

(Yes, I'll rewrite the commit message if this is the way to go ;)

References: https://lore.kernel.org/r/20220727074152.43059-1-matthieu.charette@gmail.com
Cc: Matthieu CHARETTE <matthieu.charette@gmail.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/drm_edid_load.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid_load.c b/drivers/gpu/drm/drm_edid_load.c
index 37d8ba3ddb46..fbae12130234 100644
--- a/drivers/gpu/drm/drm_edid_load.c
+++ b/drivers/gpu/drm/drm_edid_load.c
@@ -182,18 +182,9 @@ static void *edid_load(struct drm_connector *connector, const char *name,
 		fwdata = generic_edid[builtin];
 		fwsize = sizeof(generic_edid[builtin]);
 	} else {
-		struct platform_device *pdev;
 		int err;
 
-		pdev = platform_device_register_simple(connector_name, -1, NULL, 0);
-		if (IS_ERR(pdev)) {
-			DRM_ERROR("Failed to register EDID firmware platform device "
-				  "for connector \"%s\"\n", connector_name);
-			return ERR_CAST(pdev);
-		}
-
-		err = request_firmware(&fw, name, &pdev->dev);
-		platform_device_unregister(pdev);
+		err = request_firmware(&fw, name, connector->dev->dev);
 		if (err) {
 			DRM_ERROR("Requesting EDID firmware \"%s\" failed (err=%d)\n",
 				  name, err);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-11-13 19:27 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-06 22:21 [Intel-gfx] [PATCH] drm/edid/firmware: stop using throwaway platform device Jani Nikula
2022-10-06 23:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-10-06 23:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-07  9:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-10-11  6:27 ` [Intel-gfx] [PATCH] " Matthieu CHARETTE
2022-10-11  7:20   ` Jani Nikula
2022-10-11 20:45     ` Matthieu CHARETTE
2022-10-12  8:25       ` Jani Nikula
2022-10-12 17:16         ` Matthieu CHARETTE
2022-11-06 15:03           ` Matthieu CHARETTE
2022-11-08 11:27             ` Jani Nikula
2022-11-08 15:40               ` Matthieu CHARETTE
2022-11-13 19:26                 ` Matthieu CHARETTE

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox