* [Intel-gfx] [PATCH i-g-t] tests/i915/module_load: restore gem_sanitycheck for discrete
@ 2022-11-02 15:05 Matthew Auld
2022-11-03 11:10 ` [Intel-gfx] [igt-dev] " Das, Nirmoy
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Auld @ 2022-11-02 15:05 UTC (permalink / raw)
To: igt-dev; +Cc: Priyanka Dandamudi, intel-gfx, Janga Rahul Kumar
This looks to be recently broken in: 5389b3f3
("tests/i915/i915_module_load: Use GEM_BUSY instead of SET_CACHE for
sanity check").
Which fails on discrete platforms, since we switched over to the
gem_busy ioctl, from the set_caching ioctl, which no longer gives
-ENODEV as the expected error.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
tests/i915/i915_module_load.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c
index eebb3167..d3a86b11 100644
--- a/tests/i915/i915_module_load.c
+++ b/tests/i915/i915_module_load.c
@@ -228,7 +228,7 @@ static void gem_sanitycheck(void)
{
struct drm_i915_gem_busy args = {};
int i915 = __drm_open_driver(DRIVER_INTEL);
- int expected = gem_has_lmem(i915) ? -ENODEV : -ENOENT;
+ int expected = -ENOENT;
int err;
err = 0;
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/i915/module_load: restore gem_sanitycheck for discrete
2022-11-02 15:05 [Intel-gfx] [PATCH i-g-t] tests/i915/module_load: restore gem_sanitycheck for discrete Matthew Auld
@ 2022-11-03 11:10 ` Das, Nirmoy
2022-11-03 11:12 ` Das, Nirmoy
0 siblings, 1 reply; 3+ messages in thread
From: Das, Nirmoy @ 2022-11-03 11:10 UTC (permalink / raw)
To: Matthew Auld, igt-dev; +Cc: intel-gfx, Janga Rahul Kumar
Reviewed-by: Nirmoy.das@intel.com
On 11/2/2022 4:05 PM, Matthew Auld wrote:
> This looks to be recently broken in: 5389b3f3
> ("tests/i915/i915_module_load: Use GEM_BUSY instead of SET_CACHE for
> sanity check").
>
> Which fails on discrete platforms, since we switched over to the
> gem_busy ioctl, from the set_caching ioctl, which no longer gives
> -ENODEV as the expected error.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> ---
> tests/i915/i915_module_load.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c
> index eebb3167..d3a86b11 100644
> --- a/tests/i915/i915_module_load.c
> +++ b/tests/i915/i915_module_load.c
> @@ -228,7 +228,7 @@ static void gem_sanitycheck(void)
> {
> struct drm_i915_gem_busy args = {};
> int i915 = __drm_open_driver(DRIVER_INTEL);
> - int expected = gem_has_lmem(i915) ? -ENODEV : -ENOENT;
> + int expected = -ENOENT;
> int err;
>
> err = 0;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/i915/module_load: restore gem_sanitycheck for discrete
2022-11-03 11:10 ` [Intel-gfx] [igt-dev] " Das, Nirmoy
@ 2022-11-03 11:12 ` Das, Nirmoy
0 siblings, 0 replies; 3+ messages in thread
From: Das, Nirmoy @ 2022-11-03 11:12 UTC (permalink / raw)
To: Matthew Auld, igt-dev; +Cc: intel-gfx, Janga Rahul Kumar
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
On 11/3/2022 12:10 PM, Das, Nirmoy wrote:
> Reviewed-by: Nirmoy.das@intel.com
>
> On 11/2/2022 4:05 PM, Matthew Auld wrote:
>> This looks to be recently broken in: 5389b3f3
>> ("tests/i915/i915_module_load: Use GEM_BUSY instead of SET_CACHE for
>> sanity check").
>>
>> Which fails on discrete platforms, since we switched over to the
>> gem_busy ioctl, from the set_caching ioctl, which no longer gives
>> -ENODEV as the expected error.
>>
>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>> Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
>> Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
>> ---
>> tests/i915/i915_module_load.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/i915/i915_module_load.c
>> b/tests/i915/i915_module_load.c
>> index eebb3167..d3a86b11 100644
>> --- a/tests/i915/i915_module_load.c
>> +++ b/tests/i915/i915_module_load.c
>> @@ -228,7 +228,7 @@ static void gem_sanitycheck(void)
>> {
>> struct drm_i915_gem_busy args = {};
>> int i915 = __drm_open_driver(DRIVER_INTEL);
>> - int expected = gem_has_lmem(i915) ? -ENODEV : -ENOENT;
>> + int expected = -ENOENT;
>> int err;
>> err = 0;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-03 11:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-02 15:05 [Intel-gfx] [PATCH i-g-t] tests/i915/module_load: restore gem_sanitycheck for discrete Matthew Auld
2022-11-03 11:10 ` [Intel-gfx] [igt-dev] " Das, Nirmoy
2022-11-03 11:12 ` Das, Nirmoy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox