From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v4 4/9] drm/i915: Use the AUX_IO power domain only for eDP/PSR port
Date: Mon, 14 Nov 2022 14:22:46 +0200 [thread overview]
Message-ID: <20221114122251.21327-5-imre.deak@intel.com> (raw)
In-Reply-To: <20221114122251.21327-1-imre.deak@intel.com>
Use the AUX_IO_A display power domain only for eDP on port A where PSR
is also supported. This is the case where DC states need to be enabled
while the output is enabled - ensured by AUX_IO_A domain not enabling
the DC_OFF power well. Otherwise port A can be treated the same way as
other ports with an external DP output: using the AUX_<port> domain
which disables the unrequired DC states.
This change prepares for the next patch enabling DC states on all ports
supporting eDP/PSR besides port A.
v2:
- Check the encoder PSR capability instead of PSR being enabled in the
crtc_state, as the latter can be changed with a fastset.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 477dd9b72ea3e..d849798c5986a 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -861,8 +861,10 @@ intel_ddi_main_link_aux_domain(struct intel_digital_port *dig_port)
* Note that PSR is enabled only on Port A even though this function
* returns the correct domain for other ports too.
*/
- return dig_port->aux_ch == AUX_CH_A ? POWER_DOMAIN_AUX_IO_A :
- intel_aux_power_domain(dig_port);
+ if (dig_port->aux_ch == AUX_CH_A && intel_encoder_can_psr(&dig_port->base))
+ return POWER_DOMAIN_AUX_IO_A;
+ else
+ return intel_aux_power_domain(dig_port);
}
static void intel_ddi_get_power_domains(struct intel_encoder *encoder,
--
2.37.1
next prev parent reply other threads:[~2022-11-14 12:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 12:22 [Intel-gfx] [PATCH v4 0/9] drm/i915: drm/i915/tgl+: Enable DC power states on all eDP ports Imre Deak
2022-11-14 12:22 ` [Intel-gfx] [PATCH v4 1/9] drm/i915: Fix warn in intel_display_power_*_domain() functions Imre Deak
2022-11-14 12:22 ` [Intel-gfx] [PATCH v4 2/9] drm/i915: Preallocate the debug power domain wakerefs array Imre Deak
2022-11-14 12:22 ` [Intel-gfx] [PATCH v4 3/9] drm/i915: Move the POWER_DOMAIN_AUX_IO_A definition to its logical place Imre Deak
2022-11-14 12:22 ` Imre Deak [this message]
2022-11-14 12:22 ` [Intel-gfx] [PATCH v4 5/9] drm/i915/tgl+: Enable display DC power states on all eDP ports Imre Deak
2022-11-14 12:22 ` [Intel-gfx] [PATCH v4 6/9] drm/i915: Add missing AUX_IO_A power domain->well mappings Imre Deak
2022-11-14 12:22 ` [Intel-gfx] [PATCH v4 7/9] drm/i915: Add missing DC_OFF " Imre Deak
2022-11-14 12:22 ` [Intel-gfx] [PATCH v4 8/9] drm/i915: Factor out function to get/put AUX_IO power for main link Imre Deak
2022-11-14 12:22 ` [Intel-gfx] [PATCH v4 9/9] drm/i915/mtl+: Don't enable the AUX_IO power for non-eDP port main links Imre Deak
2022-11-17 13:24 ` Ville Syrjälä
2022-11-17 13:56 ` Imre Deak
2022-11-14 19:39 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: drm/i915/tgl+: Enable DC power states on all eDP ports Patchwork
2022-11-14 20:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-15 0:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114122251.21327-5-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox