Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Maíra Canal" <mcanal@igalia.com>
To: "Maxime Ripard" <mripard@kernel.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Rob Clark" <robdclark@gmail.com>,
	"Simon Ser" <contact@emersion.fr>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Zack Rusin" <zackr@vmware.com>
Cc: "André Almeida" <andrealmeid@igalia.com>,
	intel-gfx@lists.freedesktop.org,
	"Maíra Canal" <mcanal@igalia.com>,
	dri-devel@lists.freedesktop.org, "Melissa Wen" <mwen@igalia.com>,
	"VMware Graphics Reviewers"
	<linux-graphics-maintainer@vmware.com>
Subject: [Intel-gfx] [PATCH 0/5] Check for valid framebuffer's format
Date: Mon,  9 Jan 2023 07:58:03 -0300	[thread overview]
Message-ID: <20230109105807.18172-1-mcanal@igalia.com> (raw)

This series is a follow-up of [1] in which I introduced a check for valid
formats on drm_gem_fb_create(). During the discussion, I realized that would be
a better idea to put the check inside framebuffer_check() so that it wouldn't
be needed to hit any driver-specific code path when the check fails. Thanks
to Daniel, Simon, Rob and Thomas for the insightful discussion!

Therefore, add the valid format check inside framebuffer_check() and remove
the same check from the drivers. Adding the check to framebuffer_check() will
guarantee that the igt@kms_addfb_basic@addfb25-bad-modifier IGT test passes,
showing the correct behavior of the check.

This patchset was tested on i915, amdgpu, and vc4 with the IGT tests.

[1] https://lore.kernel.org/dri-devel/20230103125322.855089-1-mcanal@igalia.com/T/

Best Regards,
- Maíra Canal

Maíra Canal (5):
  drm/framebuffer: Check for valid formats
  drm/amdgpu: Remove redundant framebuffer format check
  drm/i915: Remove redundant framebuffer format check
  drm/vmwgfx: Remove redundant framebuffer format check
  drm/plane: Unexport drm_any_plane_has_format()

 Documentation/gpu/todo.rst                  |  9 ++++-----
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 10 ----------
 drivers/gpu/drm/drm_framebuffer.c           |  8 ++++++++
 drivers/gpu/drm/drm_plane.c                 |  1 -
 drivers/gpu/drm/i915/display/intel_fb.c     |  9 ---------
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c         | 18 ------------------
 6 files changed, 12 insertions(+), 43 deletions(-)

-- 
2.39.0


             reply	other threads:[~2023-01-09 11:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 10:58 Maíra Canal [this message]
2023-01-09 10:58 ` [Intel-gfx] [PATCH 1/5] drm/framebuffer: Check for valid formats Maíra Canal
2023-01-11 22:48   ` Daniel Vetter
2023-01-09 10:58 ` [Intel-gfx] [PATCH 2/5] drm/amdgpu: Remove redundant framebuffer format check Maíra Canal
2023-01-12 12:17   ` Simon Ser
2023-01-09 10:58 ` [Intel-gfx] [PATCH 3/5] drm/i915: " Maíra Canal
2023-01-12 12:18   ` Simon Ser
2023-01-12 12:43   ` Ville Syrjälä
2023-01-12 14:07     ` Maíra Canal
2023-01-12 15:15       ` Ville Syrjälä
2023-01-09 10:58 ` [Intel-gfx] [PATCH 4/5] drm/vmwgfx: " Maíra Canal
2023-01-12  2:52   ` Zack Rusin
2023-01-09 10:58 ` [Intel-gfx] [PATCH 5/5] drm/plane: Unexport drm_any_plane_has_format() Maíra Canal
2023-01-11 22:50   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230109105807.18172-1-mcanal@igalia.com \
    --to=mcanal@igalia.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=andrealmeid@igalia.com \
    --cc=christian.koenig@amd.com \
    --cc=contact@emersion.fr \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=mwen@igalia.com \
    --cc=robdclark@gmail.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    --cc=tzimmermann@suse.de \
    --cc=zackr@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox