From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: linux-fbdev@vger.kernel.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Javier Martinez Canillas <javierm@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@intel.com>,
Helge Deller <deller@gmx.de>
Subject: [Intel-gfx] [PATCH 05/11] video/aperture: Only kick vgacon when the pdev is decoding vga
Date: Wed, 11 Jan 2023 16:41:06 +0100 [thread overview]
Message-ID: <20230111154112.90575-5-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20230111154112.90575-1-daniel.vetter@ffwll.ch>
Otherwise it's bit silly, and we might throw out the driver for the
screen the user is actually looking at. I haven't found a bug report
for this case yet, but we did get bug reports for the analog case
where we're throwing out the efifb driver.
References: https://bugzilla.kernel.org/show_bug.cgi?id=216303
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org
---
drivers/video/aperture.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/video/aperture.c b/drivers/video/aperture.c
index 3d8c925c7365..6f351a58f6c6 100644
--- a/drivers/video/aperture.c
+++ b/drivers/video/aperture.c
@@ -341,6 +341,9 @@ int aperture_remove_conflicting_pci_devices(struct pci_dev *pdev, const char *na
return ret;
}
+ if (!primary)
+ return 0;
+
/*
* WARNING: Apparently we must kick fbdev drivers before vgacon,
* otherwise the vga fbdev driver falls over.
--
2.39.0
next prev parent reply other threads:[~2023-01-11 15:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 15:41 [Intel-gfx] [PATCH 01/11] drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] [PATCH 02/11] drm/gma500: " Daniel Vetter
2023-01-12 9:04 ` Thomas Zimmermann
2023-01-12 9:59 ` Daniel Vetter
2023-01-12 10:24 ` Thomas Zimmermann
2023-01-12 10:45 ` Daniel Vetter
2023-01-12 12:15 ` Thomas Zimmermann
2023-01-12 15:32 ` Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] [PATCH 03/11] drm/aperture: Remove primary argument Daniel Vetter
2023-01-11 15:49 ` Thomas Zimmermann
2023-01-11 15:41 ` [Intel-gfx] [PATCH 04/11] video/aperture: use generic code to figure out the vga default device Daniel Vetter
2023-01-11 15:59 ` Thomas Zimmermann
2023-01-11 16:51 ` Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter [this message]
2023-01-11 16:03 ` [Intel-gfx] [PATCH 05/11] video/aperture: Only kick vgacon when the pdev is decoding vga Thomas Zimmermann
2023-01-11 16:55 ` Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] [PATCH 06/11] staging/lynxfb: Use pci aperture helper Daniel Vetter
2023-01-11 16:05 ` Thomas Zimmermann
2023-01-11 15:41 ` [Intel-gfx] [PATCH 07/11] fbdev/radeon: use pci aperture helpers Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] [PATCH 08/11] fbdev/hyperv: " Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] [PATCH 09/11] video/aperture: Move vga handling to pci function Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] [PATCH 10/11] video/aperture: Drop primary argument Daniel Vetter
2023-01-11 16:09 ` Thomas Zimmermann
2023-01-11 15:41 ` [Intel-gfx] [PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device Daniel Vetter
2023-01-11 16:20 ` Thomas Zimmermann
2023-01-11 16:37 ` Daniel Vetter
2023-01-12 7:48 ` Thomas Zimmermann
2023-01-11 16:43 ` Javier Martinez Canillas
2023-01-11 16:58 ` Javier Martinez Canillas
2023-01-11 19:21 ` Aaron Plattner
2023-01-12 7:55 ` Thomas Zimmermann
2023-01-12 8:44 ` Javier Martinez Canillas
2023-01-11 15:48 ` [Intel-gfx] [PATCH 01/11] drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers Thomas Zimmermann
2023-01-11 17:02 ` Daniel Vetter
2023-01-11 16:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/11] " Patchwork
2023-01-11 16:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-01-12 9:41 ` [Intel-gfx] [PATCH 01/11] " Thomas Zimmermann
2023-04-04 14:45 ` Thomas Zimmermann
2023-04-18 0:53 ` Jammy Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111154112.90575-5-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox